Community Wad

[migookman]

A few cards done today:

Yare
Wild Mammoth
Waterspout Elemental
Wall of Shadows
Walking Desecration
Withering Wisps
Withering Gaze

[tmxk2012917]

CW stopped on Oct 17th

[Xander9009]

I just noticed two cards have been marked as modified in every version of the CW since V400. Murderous Redcap and The Great Aurora. Their date tags had "2016" instead of just "16". So, yeah. (I'm just amused. I was momentarily really confused why someone was obsessed with constantly changing them.)

I knew the CW wasn't updating properly, but I couldn't spot the pattern, because sometimes it would, and I was pretty sure I'd coded the date functions correctly. Turned out I had, but I'd accidentally made a minor mistake elsewhere. The real kicker was that every time I restarted the program, it ran fine, so I thought it was probably fixed. It would always break the next time. Finally realized why (hopefully...). Let me know if it fails again. It's repacking now. Once it works, it should hopefully be able to just be left alone for a good long while.

[Xander9009]

Problem cards:

Sanctimony http://pastebin.com/zsZX9bUE Does not work. Could be that is not for controller's mana but rather an opponent's.

Scarscale Ritual http://pastebin.com/jV6aGaVx Not prompting to put a -1/-1 counter on a creature. Everything else works.

Scythe of the Wretched http://pastebin.com/xpwxu1Tg Not attaching to the creature that controller gains control of. Everything else works.

Soul Exchange http://pastebin.com/4NPrup4f Does not put counters on returned creature if exiled one is a Thrull. Everything else works.

For Sanctimony, are you testing for manually tapped mountains or for mountains tapped automatically by playing a spell? The auto-tapping of lands does not fire the trigger properly. It's an engine bug that we can't fix. Riiak's manual mana functions include a bit which manually fires the trigger, but that only works for manually tapped lands.

The only solution I can think of once again involves modifying a huge number of cards. This time, it'd be every card that taps something that might possibly be a land for any reason, and marking the reason it was tapped (mana or otherwise). Then, whenever a land becomes tapped, if it wasn't marked by an ability, then it could be safely assumed it was for mana.

Scarscale Ritual: 4 things.
1: In the prerequisite, there's no reason to check if the creature is tapped.
2: It's a lot cleaner to just type filter:CountStopAt(1) == 1. This is a minor speed improvement, since the game doesn't need to count all of the possible targets, just if there is one.
3: When adding counters in a cost, make sure you call PLW_ShutDownDoublingSeason(). It needs to be done in the same RTA immediately before adding the counters. Without it, Doubling Season and similar cards (though there aren't any others for -1/-1 counters that I know of) will add extra counters. They shouldn't though, because they specify "if an effect". These aren't effects though; they're costs.
4: When using a target tag to select something that isn't actually be targeted (such as when the card specifies "choose a ..."), make sure to add 'not_targeted="1"' to the target tag. This lets the game know not consider protection/shroud and not to fire the BECAME_TARGET_OF_SPELL_OR_ABILITY trigger.

However, after all of that, I'm not actually sure why it isn't working. Try this code and see what pops up in-game.

Code: Select all

<RESOLUTION_TIME_ACTION>
   local oTargets = EffectDC():Get_Targets(1)
   if oTargets ~= nil then
      local oTarget = oTargets:Get_CardPtr(0)
      if oTarget ~= nil then
         local iCounterType = MTG():MinusOneMinusOneCounters()
         if iCounterType ~= nil and iCounterType > 0 then
            oTarget:AddCounters(iCounterType, 1)
            Debug("Added counters")
         else
            Debug("iCounterType", iCounterType)
         end
      else
         Debug("oTarget", oTarget)
      end
   else
      Debug("oTargets", oTargets)
   end
</RESOLUTION_TIME_ACTION>

Note that the last two debug messages will only show the name of the variable, not the contents (which, since those will only appear if they're nil, would just be "oTarget (nil)". I've actually updated the CW_GENERAL.LOL file to include a third parameter to force the second's type to be displayed if if type doesn't match a set of expected types. For instance, if the second parameter is 'nil' or 'userdata' and the third parameter is '1' or 'true', then it would display "oTargets: (nil)" or "oTargets (userdata)". ('userdata', for the record, is what data chests, cards, and players are.) So, this would be a great place to put 'Debug("oTargets", oTargets, true)', but that'll throw an exception until you have the updated function file. Suffice it to say for now that if you see the name of any variable, there's something wrong with it. In the case of iCounterType, if it's <= 0, it'll show you its value.

Scythe of the Wretched: TriggerObject() is nil by that point. In the trigger, you protect the pointer so it can be referenced by the rest of the ability. But when you then call PutOntoBattlefield, it changes zones again, which means the pointer needs protected again just like it was in the trigger. Protect the pointer, then resurrect it, then attach the equipment.

Soul Exchange: Two things to try.
1: Line 46 sets int 33 in EffectDC instead of LinkedDC, but the below ability is trying to retrieve from LinkedDC. Set line 46 to use LinkedDC.

2: If that doesn't work, try this code:

Code: Select all

<COST type="Generic">
   <PREREQUISITE>
      local oFilter = ClearFilter()
      oFilter:Add(FE_TYPE, OP_IS, CARD_TYPE_CREATURE)
      oFilter:Add(FE_CONTROLLER, OP_IS, EffectController())
      return oFilter:CountStopAt(1) == 1
   </PREREQUISITE>
   <RESOLUTION_TIME_ACTION>
      local oFilter = ClearFilter()
      oFilter:Add(FE_TYPE, OP_IS, CARD_TYPE_CREATURE)
      oFilter:Add(FE_CONTROLLER, OP_IS, EffectController())
      EffectController():ChooseItem("CARD_QUERY_CHOOSE_CARD_TO_EXILE", EffectDC():Make_Targets(0))
   </RESOLUTION_TIME_ACTION>
   <RESOLUTION_TIME_ACTION>
      local oCreature = EffectDC():Get_Targets(0) and EffectDC():Get_Targets(0):Get_CardPtr(0)
      if oCreature ~= nil then
         if oCreature:GetSubType():Test(CREATURE_TYPE_THRULL) then
            LinkedDC():Set_Int(33, 1)
         end
         oCreature:Exile()
      end
   </RESOLUTION_TIME_ACTION>
</COST>

----

migookman: Is there a particular reason Carrion only allows sacrificing of non-tokens? I figure it's probably just a copy-paste error, but since it also make tokens, I'm not sure if it was to prevent some AI-infinite cycle or something.

[Xander9009]

Hey guys, do you think the cards should be given tags for which main sets they've appeared in? So you could search for something like "Printing sets (contains) -> Nyx" to find all of the Journey in Nyx cards using the deck builder's advanced search?

[migookman]

migookman: Is there a particular reason Carrion only allows sacrificing of non-tokens? I figure it's probably just a copy-paste error, but since it also make tokens, I'm not sure if it was to prevent some AI-infinite cycle or something.

I'm sure it was just a copy/paste error. Even though it was a long time ago, I do remember that Carrion took me several times to get working.

[Splinterverse]

Hey guys, do you think the cards should be given tags for which main sets they've appeared in? So you could search for something like "Printing sets (contains) -> Nyx" to find all of the Journey in Nyx cards using the deck builder's advanced search?

I think that would be helpful. It seems like the current expansion shown is the most recent. I think the expansion tag should probably contain the first appearance expansion and then others could be added elsewhere. Probably too late to make that change though.

[Xander9009]

Hey guys, do you think the cards should be given tags for which main sets they've appeared in? So you could search for something like "Printing sets (contains) -> Nyx" to find all of the Journey in Nyx cards using the deck builder's advanced search?

I think that would be helpful. It seems like the current expansion shown is the most recent. I think the expansion tag should probably contain the first appearance expansion and then others could be added elsewhere. Probably too late to make that change though.

Not at all. With the CW Contents spreadsheet came a complete listing of cards from every set, which could easily be used to iterate through every card in the CW and set the expansion tag to the earliest. The process of adding the reprints to another tag would be automatic as well. It'd probably go up near the top right after the normal expansion line, and it would be formatted just like the <AUTHOR> and <EDITOR> tags with a CDATA section.

Actually, that would all be relatively easy. The difficult thing would be figuring out how to add custom tags to the advanced filtering list. It's written in C#, which I'm minorly familiar with (just today I was actually debugging the issue I mentioned to you before and managed to get it all fixed up), but not so familiar that I'm sure I could successfully make the changes needed. I'm confident I could, but not certain.

I'm going to go see how long it takes me to come up with a complete list of all cards with their earliest printing and a list of all reprints.

[Xander9009]

Done. A big chunk of that time was spent waiting for it to finish the first time (I should have made it stop early to test it but oh well). Had to run it again because I forgot a newline at one point. But it seemed to work. I checked using Fog as a random example card. All of the sets listed on gatherer appeared and all of the sets it listed appeared on gatherer except for CED and CEI, which are apparently Collector's Edition (which likely wouldn't show up on gatherer) and International Collector's Edition (which also wouldn't appear). The cards themselves aren't sorted alphabetically, but that'd be extremely simple (literally just "sort, G_CardList" would do it at the end), but that doesn't matter.

They're currently listed as their English names, but their name as it appears in the CARDNAME tag would be more helpful. But that'd just be one more very simple step (because I and others have already written functions to do so).

Despite taking a half hour to post back, it probably only took about 15 of coding. The rest was waiting for it to run (twice), checking manually on a card that had a lot of sets, looking up what 2ed and 3ed were just to be sure, and looking up what CED and CEI were to figure out why they wouldn't appear in gatherer. And then writing this... So, simple process.

[Splinterverse]

Problem cards:
Scythe of the Wretched http://pastebin.com/xpwxu1Tg Not attaching to the creature that controller gains control of. Everything else works.

Scarscale Ritual: 4 things.
1: In the prerequisite, there's no reason to check if the creature is tapped.
2: It's a lot cleaner to just type filter:CountStopAt(1) == 1. This is a minor speed improvement, since the game doesn't need to count all of the possible targets, just if there is one.
3: When adding counters in a cost, make sure you call PLW_ShutDownDoublingSeason(). It needs to be done in the same RTA immediately before adding the counters. Without it, Doubling Season and similar cards (though there aren't any others for -1/-1 counters that I know of) will add extra counters. They shouldn't though, because they specify "if an effect". These aren't effects though; they're costs.
4: When using a target tag to select something that isn't actually be targeted (such as when the card specifies "choose a ..."), make sure to add 'not_targeted="1"' to the target tag. This lets the game know not consider protection/shroud and not to fire the BECAME_TARGET_OF_SPELL_OR_ABILITY trigger.

However, after all of that, I'm not actually sure why it isn't working. Try this code and see what pops up in-game.

Code: Select all

<RESOLUTION_TIME_ACTION>
   local oTargets = EffectDC():Get_Targets(1)
   if oTargets ~= nil then
      local oTarget = oTargets:Get_CardPtr(0)
      if oTarget ~= nil then
         local iCounterType = MTG():MinusOneMinusOneCounters()
         if iCounterType ~= nil and iCounterType > 0 then
            oTarget:AddCounters(iCounterType, 1)
            Debug("Added counters")
         else
            Debug("iCounterType", iCounterType)
         end
      else
         Debug("oTarget", oTarget)
      end
   else
      Debug("oTargets", oTargets)
   end
</RESOLUTION_TIME_ACTION>

Note that the last two debug messages will only show the name of the variable, not the contents (which, since those will only appear if they're nil, would just be "oTarget (nil)". I've actually updated the CW_GENERAL.LOL file to include a third parameter to force the second's type to be displayed if if type doesn't match a set of expected types. For instance, if the second parameter is 'nil' or 'userdata' and the third parameter is '1' or 'true', then it would display "oTargets: (nil)" or "oTargets (userdata)". ('userdata', for the record, is what data chests, cards, and players are.) So, this would be a great place to put 'Debug("oTargets", oTargets, true)', but that'll throw an exception until you have the updated function file. Suffice it to say for now that if you see the name of any variable, there's something wrong with it. In the case of iCounterType, if it's <= 0, it'll show you its value.

Scythe of the Wretched: TriggerObject() is nil by that point. In the trigger, you protect the pointer so it can be referenced by the rest of the ability. But when you then call PutOntoBattlefield, it changes zones again, which means the pointer needs protected again just like it was in the trigger. Protect the pointer, then resurrect it, then attach the equipment.

Scarscale Ritual is displaying "oTargets" as a result of the debug. It's not adding the counter; I'm guessing it's not getting the value it needs. Maybe I should move it all out of the cost and do it in the main ability? http://pastebin.com/mPw4wiNH

Scythe of the Wretched is not attaching to the new creature after protecting the pointer, but perhaps I protected it incorrectly? http://pastebin.com/GBRFNLqF

On a side note, the player:SetCustomQueryInstructionValue stuff in cards like Brine Seer does not appear to be working as intended. Instead of it displaying the chosen X cost, it displays R1 and a hybrid G/W mana symbol. It's always the same no matter what the chosen value for X is.

[Xander9009]

If it's displaying oTargets, then oTargets is nil. EffectDC():Get_Targets(1) didn't work. I'm not 100% certain why it's not working, but if the targeting isn't getting the creature properly, then it'll either just need the TARGET and TARGET_DEFINITION tags moved out of the COST block, or else it will need to use a ChooseItem function to get the creature to use. If it's the latter, here you go.

Code: Select all

<COST type="Generic">
   <PREREQUISITE>
      local oFilter = ClearFilter()
      oFilter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
      oFilter:Add( FE_CONTROLLER, OP_IS, EffectController() )
      return oFilter:CountStopAt(1) == 1
   </PREREQUISITE>
   <TARGET tag="CW_CARD_QUERY_CHOOSE_CREATURE_TO_GET_MINUSONE_MINUSONE_COUNTER" definition="1" compartment="1" count="1" not_targeted="1" />
   <TARGET_DEFINITION id="1">
      local filter = ClearFilter()
      filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
      filter:Add( FE_CONTROLLER, OP_IS, EffectController() )
   </TARGET_DEFINITION>
   <!-- <RESOLUTION_TIME_ACTION>
      local target_creature = EffectDC():Get_Targets(1) and EffectDC():Get_Targets(1):Get_CardPtr(0)
      PLW_ShutDownDoublingSeason()
      target_creature:AddCounters(MTG():MinusOneMinusOneCounters(), 1)
   </RESOLUTION_TIME_ACTION> -->
   
   <RESOLUTION_TIME_ACTION>
      local oController = EffectController()
      if oController ~= nil then
         local oFilter = ClearFilter()
         oFilter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
         oFilter:Add( FE_CONTROLLER, OP_IS, EffectController() )
         oController:ChooseItem("CW_CARD_QUERY_CHOOSE_CREATURE_TO_GET_MINUSONE_MINUSONE_COUNTER", EffectDC():Make_Targets(1))
      end
   </RESOLUTION_TIME_ACTION>
   <RESOLUTION_TIME_ACTION>
      local oTargets = EffectDC():Get_Targets(1)
      if oTargets ~= nil then
        local oTarget = oTargets:Get_CardPtr(0)
        if oTarget ~= nil then
          local iCounterType = MTG():MinusOneMinusOneCounters()
          if iCounterType ~= nil and iCounterType > 0 then
            oTarget:AddCounters(iCounterType, 1)
            Debug("Added counters")
          else
            Debug("iCounterType", iCounterType)
          end
        else
          Debug("oTarget", oTarget)
        end
      else
        Debug("oTargets", oTargets)
      end
   </RESOLUTION_TIME_ACTION>
</COST>

Of course, if that works, it can be shortened by removing the debug sections and shortening the target retrieval to one line like normal.

For the equipment, best guess? Move the attachment to a new RTA. Since the card is changing zones, the attach function might not work until that RTA has finished. Often times, zone-changes don't fully take effect until the next RTA.

[Splinterverse]

If it's displaying oTargets, then oTargets is nil. EffectDC():Get_Targets(1) didn't work. I'm not 100% certain why it's not working, but if the targeting isn't getting the creature properly, then it'll either just need the TARGET and TARGET_DEFINITION tags moved out of the COST block, or else it will need to use a ChooseItem function to get the creature to use. If it's the latter, here you go.

Code: Select all

<COST type="Generic">
   <PREREQUISITE>
      local oFilter = ClearFilter()
      oFilter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
      oFilter:Add( FE_CONTROLLER, OP_IS, EffectController() )
      return oFilter:CountStopAt(1) == 1
   </PREREQUISITE>
   <TARGET tag="CW_CARD_QUERY_CHOOSE_CREATURE_TO_GET_MINUSONE_MINUSONE_COUNTER" definition="1" compartment="1" count="1" not_targeted="1" />
   <TARGET_DEFINITION id="1">
      local filter = ClearFilter()
      filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
      filter:Add( FE_CONTROLLER, OP_IS, EffectController() )
   </TARGET_DEFINITION>
   <!-- <RESOLUTION_TIME_ACTION>
      local target_creature = EffectDC():Get_Targets(1) and EffectDC():Get_Targets(1):Get_CardPtr(0)
      PLW_ShutDownDoublingSeason()
      target_creature:AddCounters(MTG():MinusOneMinusOneCounters(), 1)
   </RESOLUTION_TIME_ACTION> -->
   
   <RESOLUTION_TIME_ACTION>
      local oController = EffectController()
      if oController ~= nil then
         local oFilter = ClearFilter()
         oFilter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
         oFilter:Add( FE_CONTROLLER, OP_IS, EffectController() )
         oController:ChooseItem("CW_CARD_QUERY_CHOOSE_CREATURE_TO_GET_MINUSONE_MINUSONE_COUNTER", EffectDC():Make_Targets(1))
      end
   </RESOLUTION_TIME_ACTION>
   <RESOLUTION_TIME_ACTION>
      local oTargets = EffectDC():Get_Targets(1)
      if oTargets ~= nil then
        local oTarget = oTargets:Get_CardPtr(0)
        if oTarget ~= nil then
          local iCounterType = MTG():MinusOneMinusOneCounters()
          if iCounterType ~= nil and iCounterType > 0 then
            oTarget:AddCounters(iCounterType, 1)
            Debug("Added counters")
          else
            Debug("iCounterType", iCounterType)
          end
        else
          Debug("oTarget", oTarget)
        end
      else
        Debug("oTargets", oTargets)
      end
   </RESOLUTION_TIME_ACTION>
</COST>

Of course, if that works, it can be shortened by removing the debug sections and shortening the target retrieval to one line like normal.

For the equipment, best guess? Move the attachment to a new RTA. Since the card is changing zones, the attach function might not work until that RTA has finished. Often times, zone-changes don't fully take effect until the next RTA.

Both of the above worked. They will be uploaded later today. Thanks for the help!

[Splinterverse]

I just noticed that the following cards I uploaded on Oct. 16, 2016, didn't make it into the .wad.

I'm a bit concerned because I haven't been checking that all of my uploads are making their way into the .wad. I'm hoping it was an anomaly.

I have just re-uploaded them all.

Coded, tested, and uploaded:
Devouring Greed
Devouring Rage
Dracoplasm
Landslide
Last-Ditch Effort
Naya Soulbeast
Renounce
Scytheclaw
Sea King's Blessing
Seeds of Innocence
Seizures
Selective Memory
Selfless Exorcist
Sensei Golden-Tail
Sentinel
Shimatsu the Bloodcloaked
Shower of Coals
Sworn Defender
Vicious Betrayal
Wood Elemental

Art Uploaded (all are HQ and were missing):
Last-Ditch Effort
Scytheclaw
Seal of the Guildpact
Sensei Golden-Tail

[Xander9009]

Open up drive.google.com. Search it for one of the cards (I used selective memory). Specifically, you're checking if there are any versions in the trash. I don't have any versions of that in the trash, and the current one doesn't have any other versions. That means that, according to google drive, I may not have had access to it ever. However, there's a good chance that if it was deleted/moved, it wouldn't have shown up in my trash on Google Drive, so I need you to check your end.

[Splinterverse]

Open up drive.google.com. Search it for one of the cards (I used selective memory). Specifically, you're checking if there are any versions in the trash. I don't have any versions of that in the trash, and the current one doesn't have any other versions. That means that, according to google drive, I may not have had access to it ever. However, there's a good chance that if it was deleted/moved, it wouldn't have shown up in my trash on Google Drive, so I need you to check your end.

Hmmm... nothing in my trash from that list. Maybe there was a connection issue during upload and I thought they made it?