Community Wad

[fallenangle]

You need to put filter_id="0" in each of the RTAs that use that filter. If you don't your filtered card will always return nil.

Edit: you also need to use 0, FilteredCard() instead of target when you're setting the card pointer or it will never work, since you never define what the target is.

[Xander9009]

This may work better:

Code: Select all

<ACTIVATED_ABILITY>
      <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[{5}, {T}: Prevent all damage that would be dealt to you this turn by attacking creatures without flying.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[{5}, {T}: Prevent all damage that would be dealt to you this turn by attacking creatures without flying.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[{5}, {T}: Prevent all damage that would be dealt to you this turn by attacking creatures without flying.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[{5}, {T}: Prevent all damage that would be dealt to you this turn by attacking creatures without flying.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[<span class=“missing”>(Missing!)</span>]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[{5}, {T}: Prevent all damage that would be dealt to you this turn by attacking creatures without flying.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[{5}, {T}: Prevent all damage that would be dealt to you this turn by attacking creatures without flying.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[{5}, {T}: Prevent all damage that would be dealt to you this turn by attacking creatures without flying.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[{5}, {T}: Prevent all damage that would be dealt to you this turn by attacking creatures without flying.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="zh-CN"><![CDATA[{5}, {T}: Prevent all damage that would be dealt to you this turn by attacking creatures without flying.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="zh-HK"><![CDATA[{5}, {T}: Prevent all damage that would be dealt to you this turn by attacking creatures without flying.]]></LOCALISED_TEXT>
      <COST mana_cost="{5}" type="Mana" />
      <COST type="TapSelf" />
               <FILTER filter_id="0">
         local filter = ClearFilter()
         filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
         filter:Add( FE_CHARACTERISTIC, OP_NOT, CHARACTERISTIC_FLYING )
         filter:Add( FE_IS_ATTACKING, true )
      </FILTER>
      <RESOLUTION_TIME_ACTION>
         if FilteredCard() ~= nil then
            local delayDC = EffectDC():Make_Chest(1)
            delayDC:Set_CardPtr(0, target)
            delayDC:Protect_CardPtr(0)
            MTG():CreateDelayedTrigger(1, delayDC)
         end
      </RESOLUTION_TIME_ACTION>
      <SFX text="TARGET_SUN_PLAY" />
      <AI_AVAILABILITY window_step="upkeep" type="window" />
      <AI_AVAILABILITY window_step="main_1" window_turn="my_turn" type="window" />
      <AI_AVAILABILITY window_step="begin_combat" window_turn="their_turn" type="window" />
      <AI_AVAILABILITY window_step="declare_attackers" window_turn="their_turn" type="window" />
      <AI_AVAILABILITY window_step="declare_blockers" type="window" />
      <AI_AVAILABILITY window_step="main_2" window_turn="my_turn" type="window" />
      <AI_AVAILABILITY window_step="end_of_turn" type="window" />
      <AI_AVAILABILITY window_step="end_of_turn" window_turn="their_turn" type="window" />
      <AI_AVAILABILITY type="in_response" response_source="1" response_target="1" />
      <AI_AVAILABILITY type="in_response" response_source="1" />
      <AI_AVAILABILITY type="in_response" response_target="1" />
   </ACTIVATED_ABILITY>
   <TRIGGERED_ABILITY resource_id="1" replacement_effect="1">
      <TRIGGER value="SOURCE_DEALS_DAMAGE_TO_PLAYER" pre_trigger="1" damage_type="all">
         return SecondaryPlayer() == EffectController()  and TriggerObject() == EffectDC():Get_CardPtr(0)
      </TRIGGER>
      <CLEANUP simple_cleanup="EndOfTurn" />
      <RESOLUTION_TIME_ACTION>
         Damage():PreventAll()
      </RESOLUTION_TIME_ACTION>
   </TRIGGERED_ABILITY>

Finally got around to trying this for Al-abara's Carpet and it didn't work.

On this line "delayDC:Set_CardPtr(0, target)", target isn't a variable that was every defined. You need FilteredCard().

[Splinterverse]

Finished coding for today; all cards below are from missing cards list.

Coded, tested, and uploaded:
Crystal Shard
Ordruun Commando
Prophecy
Psychic Transfer
Pyromancy
Quagnoth
Rainbow Vale
Raka Sanctuary
Rally the Horde
Rasputin Dreamweaver
Razia's Purification
Reap
Relic Putrescence
Remembrance
Repel Intruders
Repopulate
Resistance Fighter
Rethink
Retraced Image
Revered Elder
Rhystic Deluge
Rhystic Lightning
Rhystic Syphon
Righteous Indignation
Riptide Mangler
Rith, the Awakener
Rohgahh of Kher Keep
Rust Elemental
Scarab of the Unseen

Bugs Fixed:
Knacksaw Clique -- was not requiring untap as a cost; tested.

Problem Cards:

-- Al-abara's Carpet http://pastebin.com/uUPAnaaW Doesn't prevent damage. And, oddly, the art is visible in the Deck Builder, but in game it appears as a black rectangle.

-- Rakdos Riteknife http://pastebin.com/bwXFWXAP Two issues -- (1) it doesn't give +1/+0 to equipped creature based on blood counters; (2) it lets you select a player to sacrifice creatures for blood counters, but it doesn't actually cause the sacrifice.

-- Revered Unicorn http://pastebin.com/xd08Ud5Y Something very weird is happening with the cumulative upkeep. The first turn that it adds an age counter is fine. On the second turn, it adds an age counter and then I lose the ability to click on anything in the game. My only choice is to hit ESC and concede. I've tried two separate cumulative upkeep blocks from other cards.

Notes:

-- I did create and upload CW_CARD_QUERY_SPLINTERVERSE. I will continue updating this file only as I code.

-- Rainbow Vale is MM. I added that to the name and file. It did not originally have that. Hopefully that won't cause an issue.


Next:

Back tomorrow to continue coding missing cards (and implementing any suggested fixes for the problem cards). I am now working through cards that begin with P and above.

I attempted and shelved the following cards: Realmwright, Sanctimony, and Song of Blood. If anyone wants the code for those, I will upload them. Sanctimony might work if tested with manual mana tapping cards.

EDIT TO ADD:

What does origin_controller_can_use="1" do in a utility ability? I'm trying to make a stolen card in exile only be playable by the player who stole it. So would I leave this out?

[Splinterverse]

New question . . . if I have a card in the opponent's Exile that I am able to play via a spell I cast recently, how can I get it's converted mana cost as I alternate cast it? I've tried GetConvertedManaCost in the alternate Utility Ability used to cast it, but I think that because it comes out of Exile and into Transition, "EffectSource()" is no longer available to use. Any ideas?

[Xander9009]

Don't bother with Realmwright yet. It's 5 times worse than Urborg, Tomb of Yawgmoth, and that one alone required nearly two days of work for me to get working.

Unfortunately, for the ones you had questions about, I don't see anything wrong initially, and I don't have the time currently to debug them. So, that's my suggestion. Drop in a few Debug("Some message") functions and see how far the code gets (by noting which messages appear). Remember you can do Debug("Some message", variable) to get the contents of 'variable' added to the message easily, except nil values will add nothing.

Once you know how far in the code it's getting, see if you can figure it out from there. If an RTA isn't firing at all, comment out its contents and debug it. Uncomment sections of code within the RTA until you find the exact line causing it to fail.

The only thing I see wrong isn't something that should prevent it from working. In Revered Unicorn, you're multiplying by 2 on lines 77 and 89. This multiplication is for cards where you pay . Since it's only supposed to pay for each counter, not twice the number of counters, it shouldn't multiply.

For Rainbow Vale, it will cause some problems, because if a deck uses a card, then changing the filename will prevent the game from finding the card. So now, that deck is using a non-existent card, which will cause it to crash upon launching. However, its filename was wrong, and you corrected it. Don't worry too much about it. But in future, just let me know if a filename needs changed. I try to do filename changes in batch (and only very rarely) so at the very least users only have to deal with them once in a very rare while.

[Splinterverse]

For Rainbow Vale, it will cause some problems, because if a deck uses a card, then changing the filename will prevent the game from finding the card. So now, that deck is using a non-existent card, which will cause it to crash upon launching. However, its filename was wrong, and you corrected it. Don't worry too much about it. But in future, just let me know if a filename needs changed. I try to do filename changes in batch (and only very rarely) so at the very least users only have to deal with them once in a very rare while.

Rainbow Vale was a brand new card I coded. It didn't come out of the generator tool with MM on it, so I wasn't sure if adding it would be a problem (provided that of course the name inside the file and the filename itself matched).

[Xander9009]

For Rainbow Vale, it will cause some problems, because if a deck uses a card, then changing the filename will prevent the game from finding the card. So now, that deck is using a non-existent card, which will cause it to crash upon launching. However, its filename was wrong, and you corrected it. Don't worry too much about it. But in future, just let me know if a filename needs changed. I try to do filename changes in batch (and only very rarely) so at the very least users only have to deal with them once in a very rare while.

Rainbow Vale was a brand new card I coded. It didn't come out of the generator tool with MM on it, so I wasn't sure if adding it would be a problem (provided that of course the name inside the file and the filename itself matched).

In that case, no, it won't cause any problems, and is the right thing to do.

[thefiremind]

What does origin_controller_can_use="1" do in a utility ability? I'm trying to make a stolen card in exile only be playable by the player who stole it. So would I leave this out?

That attribute allows the controller of the "stealer" to actually use the ability on the stolen card. In case you steal an opponent's card and you grant it the usual "Cast this card" utility ability, you need that attribute. However I noticed that on Magic Duels it doesn't prevent the card's owner from using that ability as well (can't remember if DotP2014 had that problem). Theoretically, the problem should be solved by using

Code: Select all

<AVAILABILITY>
return EffectController() ~= Object():GetOwner()
</AVAILABILITY>

but I'm not sure. At first I was using EffectSource() instead of Object() and Tejahn reported that it wasn't working, so I thought that maybe the block can't access EffectSource, and I used Object. I don't know if it works now.

If you happen to test it let me know.

[Splinterverse]

I've got Psychic Intrusion working as it should with the exception of spending mana of any color to cast the exiled card(s).

I'm thinking that if I can somehow get the cmc of the exiled card and then make it a cost, it will work, but I don't know how to get the cmc as I (the stealer) cast it. It seems like the GetConvertedManaCost() function doesn't work since the card is in transition.

Here's the code in case anyone wants to take a look . . . http://pastebin.com/7zNxsQn5

[tmxk2012917]

I found a bug of Confiscation Coup.

At first, I had 4 energy counters. I cast it and targeted a creature whose converted mana is 6, but I could not control that creature because I did not get extra 4 counters from Confiscation Coup.

[fallenangle]

Splinterverse,

In the utility ability you grant the exiled card, you call EffectSource(), which is Psychic Intrusion, not the exiled card. That may be why it doesn't work.

In addition to that, just using CMC isn't enough, as the cost of cards can be increased by any number of cards, and this increase has no impact on their CMC, if I remember correctly. You need to use an ability that reduces the card's cost by its cost in mana of all colors, then increase its cost by its CMC plus the amount of additional mana it might cost, in colorless mana. I updated Oath of Nissa's second ability to use this code. If Xander added it, you can check the code there.

[Splinterverse]

Splinterverse,

In the utility ability you grant the exiled card, you call EffectSource(), which is Psychic Intrusion, not the exiled card. That may be why it doesn't work.

In addition to that, just using CMC isn't enough, as the cost of cards can be increased by any number of cards, and this increase has no impact on their CMC, if I remember correctly. You need to use an ability that reduces the card's cost by its cost in mana of all colors, then increase its cost by its CMC plus the amount of additional mana it might cost, in colorless mana. I updated Oath of Nissa's second ability to use this code. If Xander added it, you can check the code there.

Oath of Nissa was one of the cards I looked to, but the only one in the .wad says "Non-functional" on that ability. Would you mind pm'ing me the code or posting it here? Glad you've got something working on this front.

[Splinterverse]

I found a bug of Confiscation Coup.

At first, I had 4 energy counters. I cast it and targeted a creature whose converted mana is 6, but I could not control that creature because I did not get extra 4 counters from Confiscation Coup.

I originally coded that card, but there's some stuff that's been added since then that I don't recognize. I'm guessing Xander updated some of the energy cards handling of energy. I'll defer to him on this one.

[Splinterverse]

Finished coding for today; all cards below are from the missing cards list, unless otherwise noted.

Coded, tested, and uploaded:
Morality Shift (this was on Impossible Cards list and was coded/tested by TheFireMind; I also tested it)
Orim's Touch
Ornate Kanzashi
Osai Vultures
Outrider en-Kor
Overburden
Overload
Override
Pistus Strike
Plague Boiler
Planar Chaos
Planar Overlay
Pledge of Loyalty
Plow Through Reito
Power Leak
Preacher
Primal Clay
Primal Plasma
Primordial Ooze
Prismatic Ward
Prohibit
Psychic Allergy
Saproling Infestation
Spirit en-Kor
Warrior en-Kor
Widespread Panic

Art uploaded (all are HQ and were missing):
Outrider en-Kor
Spirit en-Kor
Warrior en-Kor

Bugs Fixed:
Lancers en-Kor -- was not targeting only controller's creatures

Notes:

-- I updated CW_CARD_QUERY_SPLINTERVERSE and uploaded it.

-- For cards like Saproling Infestation to work, all cards with Kicker costs will have to be updated to include the following code in the Kicker utility block:

Code: Select all

<COST type="generic">
<PREREQUISITE>
     return true
</PREREQUISITE>
<RESOLUTION_TIME_ACTION>
     MTG():FireTrigger( TRIGGER_KICKER_PAID, EffectSource() )
</RESOLUTION_TIME_ACTION>
</COST>

I have uploaded three new Kicker cards today and all have this code: Orim's Touch, Overload, and Prohibit. This has been tested successfully with Saproling Infestation.

-- For cards like Widespread Panic to work, all instances of :ShuffleLibrary will have to be accompanied by this code:

Code: Select all

MTG():FireTrigger( SPELL_OR_ABILITY_CAUSED_SHUFFLE, EffectSource() )

I know that's a lot of cards and may not happen, but at least it is an option. I will add it whenever I'm coding cards and have :ShuffleLibrary() present. This has been tested successfully with Widespread Panic.

-- EDIT TO ADD: The Impossible Cards list has also been updated.

Next:

The next solid block of coding time I have available is Wednesday. I might be in before then if I can squeeze some time on it, but definitely Wednesday at the latest.

[Xander9009]

Gonti, Lord of Luxury and Oath of Nissa (and I think Mycosynth Lattice) are still in my testing folder because I've had very little time these last few days. I gave them a very brief test, but they weren't working yet. When I get them working, I'll post about them.

Careful about adding cards like Widespread Panic and Saproling Infestation without making the necessary changes to other cards for them to properly work. Users will almost universally expect that they will work. When they only work a very small number of cards, they'll post a bug report. You should probably keep those cards on your end until their needed code has been distributed, or else put a disclaimer directly on the card in the form of an empty static ability with the ability's text stating it will not fully work yet. Then, when someone gets around to distributing the code, that text can be removed or the card can be added. (This is the same idea behind the (Not functional) text on Oath of Nissa you mentioned.