Formal Request Thread

[Xander9009]

regarding Leyline of Punishment, I made another try:

| Open

Code: Select all

  <TRIGGERED_ABILITY replacement_effect="1">
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Damage can’t be prevented.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Les blessures ne peuvent pas être prévenues.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[El daño no puede ser prevenido.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Schaden kann nicht verhindert werden.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Il danno non può essere prevenuto.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[ダメージは軽減できない。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Damage can’t be prevented.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Повреждения не могуть быть предотвращены.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[O dano não pode ser prevenido.]]></LOCALISED_TEXT>
   <TRIGGER value="SOURCE_DEALS_DAMAGE" pre_trigger="1" damage_type="all" />
   <RESOLUTION_TIME_ACTION>
      local damage = Damage():PreventAll()
      EffectDC():Set_Int(1, damage)
   </RESOLUTION_TIME_ACTION>
   <RESOLUTION_TIME_ACTION>
      local damage = EffectDC():Get_Int(1)
      local source = Damage():GetSource()
      local target_object = Damage():GetReceivingObject()
      local target_player = Damage():GetReceivingPlayer()
      if damage ~= 0 then
         if ( target_object ~= nil ) then
            source:DealUnpreventableDamageTo( damage, target_object )
         elseif ( target_player ~= nil ) then
            source:DealUnpreventableDamageTo( damage, target_player )
         end
      end
    </RESOLUTION_TIME_ACTION>
 </TRIGGERED_ABILITY>

this way it should work as a check: if the damage is unpreventable Damage():PreventAll() will return 0, and the source won't deal damage again. yet I can't make the source deal damage to its target (again) in any case

I haven't looked at the code, but you might be encountering the engine bug I discovered with Deflecting Palm (at least, it appears to be an engine bug). The game seems to have trouble understanding what to do when an ability both prevents damage and deals damage. You have to split those up into two separate abilities such that the one that prevents the damage fires the other ability which deals the damage. Set them up as linked_ability_group="1" and you should be able to pass the numbers from one to the other using LinkedDC():Set_Int(0, damage).

Here's where we discussed it including an example of the delayed trigger solution two posts down: viewtopic.php?f=109&t=11010&start=2700#p172662

[Zambooo]

the code didn't work even before I added the "PreventAll()" part, so there is still something wrong
PS: I asked for the Deflecting Palm fix so I followed the story (even though it doesn't seem like by my code LOL)

[Xander9009]

My bad. I wasn't paying any attention to who requested it.

Have you tried adding in some messages to display the values of the variables at certain points? If you haven't and don't know how, you just put this:
EffectController():DisplayMessage("Damage variable is currently: " .. damage)
"Damage variable is currently: " will display literally on screen followed by whatever 'damage' currently is. Prefix them with numbers in teh order they go off, and you can see where exactly in the code it starts to misbehave.

[Zambooo]

My bad. I wasn't paying any attention to who requested it.

Have you tried adding in some messages to display the values of the variables at certain points? If you haven't and don't know how, you just put this:
EffectController():DisplayMessage("Damage variable is currently: " .. damage)
"Damage variable is currently: " will display literally on screen followed by whatever 'damage' currently is. Prefix them with numbers in teh order they go off, and you can see where exactly in the code it starts to misbehave.

cool! I didn't know about the DisplayMessage function.
though I can't use it to print my 'source' variable (aka Damage():GetSource()).. how can I achieve it?

this is what I get

Code: Select all

[lua] [string "LEYLINE_OF_PUNISHMENT_283205018_TITLE (RESOLUTION_TIME_ACTION)~0x000003c3"]:6: attempt to concatenate local 'source' (a table value)

from this

Does GetSource() return an array? :/

Code: Select all

local source = Damage():GetSource()
EffectController():DisplayMessage("Source variable is currently: " .. source)

[Xander9009]

My bad. I wasn't paying any attention to who requested it.

Have you tried adding in some messages to display the values of the variables at certain points? If you haven't and don't know how, you just put this:
EffectController():DisplayMessage("Damage variable is currently: " .. damage)
"Damage variable is currently: " will display literally on screen followed by whatever 'damage' currently is. Prefix them with numbers in teh order they go off, and you can see where exactly in the code it starts to misbehave.

cool! I didn't know about the DisplayMessage function.
though I can't use it to print my 'source' variable (aka Damage():GetSource()).. how can I achieve it?

this is what I get

Code: Select all

[lua] [string "LEYLINE_OF_PUNISHMENT_283205018_TITLE (RESOLUTION_TIME_ACTION)~0x000003c3"]:6: attempt to concatenate local 'source' (a table value)

from this

Does GetSource() return an array? :/

Code: Select all

local source = Damage():GetSource()
EffectController():DisplayMessage("Source variable is currently: " .. source)

GetSource() returns a card (should, at least), which does make sense as a table. I've never thought of them like that, but yeah. However, you can use GetName() to return a string which can be printed by DisplayMessage(). And yeah, I got the tip to use DisplayMessage() from Neo awhile back. It's quite handy

Code: Select all

local source = Damage():GetSource()
EffectController():DisplayMessage("Source variable is currently: " .. source:GetName())

[Zambooo]

| Open

Code: Select all

  <TRIGGERED_ABILITY replacement_effect="1">
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Damage can’t be prevented.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Les blessures ne peuvent pas être prévenues.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[El daño no puede ser prevenido.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Schaden kann nicht verhindert werden.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Il danno non può essere prevenuto.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[ダメージは軽減できない。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Damage can’t be prevented.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Повреждения не могуть быть предотвращены.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[O dano não pode ser prevenido.]]></LOCALISED_TEXT>
   <TRIGGER value="SOURCE_DEALS_DAMAGE" pre_trigger="1" damage_type="all" />
   <RESOLUTION_TIME_ACTION>
      local damage = Damage():GetAmount()
      EffectController():DisplayMessage("Damage variable is currently: " .. damage)
               
                local source = Damage():GetSource()
      if source == nil then
         EffectController():DisplayMessage("source is nil")
      else
         EffectController():DisplayMessage("Source variable is currently: " .. source:GetName())
      end

      local target_object = Damage():GetReceivingObject()
      if target_object == nil then
         EffectController():DisplayMessage("target_object is nil")
      else
         EffectController():DisplayMessage("Receiving Object is: " .. target_object)
      end

      local target_player = Damage():GetReceivingPlayer()
      if target_player == nil then
         EffectController():DisplayMessage("target_player is nil")
      else
         EffectController():DisplayMessage("Receiving Player is: " .. target_player)
      end

      if damage ~= 0 then
         if ( target_object ~= nil ) then
            source:DealUnpreventableDamageTo( damage, target_object )
         elseif ( target_player ~= nil ) then
            source:DealUnpreventableDamageTo( damage, target_player )
         end
      end
    </RESOLUTION_TIME_ACTION>
   <RESOLUTION_TIME_ACTION>
    Damage():Multiply(1)
    </RESOLUTION_TIME_ACTION>
 </TRIGGERED_ABILITY>

note: i added the "Multiply(1)" part otherwise there would have been no damage at all

now I get this

Code: Select all

[lua] [string "LEYLINE_OF_PUNISHMENT_283205018_TITLE (RESOLUTION_TIME_ACTION)~0x000005ae"]:9: attempt to call method 'GetName' (a nil value)

seems like source is not nil but GetName() returns nil..

[RiiakShiNal]

cool! I didn't know about the DisplayMessage function.
though I can't use it to print my 'source' variable (aka Damage():GetSource()).. how can I achieve it?

this is what I get

Code: Select all

[lua] [string "LEYLINE_OF_PUNISHMENT_283205018_TITLE (RESOLUTION_TIME_ACTION)~0x000003c3"]:6: attempt to concatenate local 'source' (a table value)

from this

Does GetSource() return an array? :/

Code: Select all

local source = Damage():GetSource()
EffectController():DisplayMessage("Source variable is currently: " .. source)

GetSource() returns a card (should, at least), which does make sense as a table. I've never thought of them like that, but yeah. However, you can use GetName() to return a string which can be printed by DisplayMessage(). And yeah, I got the tip to use DisplayMessage() from Neo awhile back. It's quite handy

Code: Select all

local source = Damage():GetSource()
EffectController():DisplayMessage("Source variable is currently: " .. source:GetName())

Technically, C/C++ objects in Lua are implemented as a table of function pointers so cards are "tables". So you can look at them sort of as first looking up the function name as the key in the table with the function pointer being the value and you use that with the provided arguments to call the appropriate object function.

Also the function is actually GetCardName() not GetName().

[Xander9009]

Also the function is actually GetCardName() not GetName().

Oops. I should probably proof read things when I'm giving others advice. Thanks

[Blue Ghost]

Can I request Marath, Will of the Wild, if it's workable, or can be approximated? Thanks.

[Zambooo]

[always talking about Leyline of Punishment]

Code: Select all

local target_player = SecondaryPlayer()
      if target_player == nil then
         EffectController():DisplayMessage("target_player is nil")
      else
         EffectController():DisplayMessage("Receiving Player is: " .. target_player:GetPlayerName())
      end

GetPlayerName() returned a nil value.. how can I print player's Name then? :/

[Xander9009]

[always talking about Leyline of Punishment]

Code: Select all

local target_player = SecondaryPlayer()
      if target_player == nil then
         EffectController():DisplayMessage("target_player is nil")
      else
         EffectController():DisplayMessage("Receiving Player is: " .. target_player:GetPlayerName())
      end

GetPlayerName() returned a nil value.. how can I print player's Name then? :/

IF you need to know what functions can be called on an object (such as a player), look here. You don't have to bookmark it to remember it: click wiki in the top left, go to 2014, and go to functions. If you see the list of player functions, those are all of the functions you can call on an object you know is a player. Unfortunately, getting their name isn't one of those functions. However, what I do usually is use IsAI(). I test in 2-player games, so that tells me if it's getting something valid and the thing it's getting is properly the computer controlled player.

[Zambooo]

ok this is my latest shot

| Open

Code: Select all

  <TRIGGERED_ABILITY replacement_effect="1">
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Damage can’t be prevented.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Les blessures ne peuvent pas être prévenues.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[El daño no puede ser prevenido.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Schaden kann nicht verhindert werden.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Il danno non può essere prevenuto.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[ダメージは軽減できない。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Damage can’t be prevented.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Повреждения не могуть быть предотвращены.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[O dano não pode ser prevenido.]]></LOCALISED_TEXT>
   <TRIGGER value="SOURCE_DEALS_DAMAGE_TO_PLAYER" pre_trigger="1" damage_type="all" />
   <TRIGGER value="SOURCE_DEALS_DAMAGE_TO_OBJECT" pre_trigger="1" damage_type="all" />
   <RESOLUTION_TIME_ACTION>
      local damage = Damage():GetAmount()
      EffectController():DisplayMessage("Damage variable is currently: " .. damage)
      
      local source = Damage():GetSource()
      if source == nil then
         EffectController():DisplayMessage("source is nil")
      else
         EffectController():DisplayMessage("Source variable is currently: " .. source:GetCardName())
      end
      
      local target_object = SecondaryObject()
      if target_object == nil then
         EffectController():DisplayMessage("target_object is nil")
      else
         EffectController():DisplayMessage("Receiving Object is: " .. target_object:GetCardName())
      end
      
      local target_player = SecondaryPlayer()
      if (target_player == nil) then
         EffectController():DisplayMessage("target_player is nil")
      end

      local delayDC = EffectDC():Make_Chest(1)
      delayDC:Set_CardPtr(0, source)
      delayDC:Protect_CardPtr(0)
        delayDC:Set_CardPtr(1, target_object)
        delayDC:Protect_CardPtr(1)
      delayDC:Set_PlayerPtr(0, target_player)
    </RESOLUTION_TIME_ACTION>
   <RESOLUTION_TIME_ACTION>
      local damage = Damage():PreventAll()
      EffectDC():Set_Int(1, damage)
      if damage ~= 0 then
         EffectController():DisplayMessage("Prevented Damage is: " .. damage)
         MTG():CreateDelayedTrigger(1, EffectDC())
      end
   </RESOLUTION_TIME_ACTION>
 </TRIGGERED_ABILITY>
 
 <TRIGGERED_ABILITY resource_id="1" replacement_effect="1">
   <TRIGGER value="STATE_BASED_EFFECTS" pre_trigger="1" />
   <CLEANUP fire_once="1" />
   <RESOLUTION_TIME_ACTION>
      local source = EffectDC():Get_CardPtr(0)
      local target_object = EffectDC():Get_CardPtr(1)
      local target_player = EffectDC():Get_PlayerPtr(0)
      if source ~= nil then
         if ( target_object ~= nil ) then
            source:DealUnpreventableDamageTo( damage, target_object )
         end
         if ( target_player ~= nil ) then
            source:DealUnpreventableDamageTo( damage, target_player )
         end
      end
   </RESOLUTION_TIME_ACTION>
  </TRIGGERED_ABILITY>

sadly it does not work.. can you check if I created the DelayedTrigger correctly?

[Xenoix]

Would anyone mind coding Cream of the Crop ? I see someone had once, but it's been since removed.

[Peeping Peacock]

Did Pull from Eternity ever get coded?

There was a discussion after an attempt at it was made that implied it was possible to code, but after that I don't know if anything happened.

viewtopic.php?f=109&t=11010&p=165993&hilit=Pull+from+Eternity#p165993

[Xander9009]

Not that I know of. I'm currently trying to get the art wad split up into multiple smaller files (for the community wad). Once that's done, I'll be coding the other two requests. If I'm still motivated after I've done those, I'll consider this one.