It is currently 07 Sep 2025, 08:06
   
Text Size

Volrathxp's Custom Dotp 2014 DLC (Last Update: 12/6/2014)

Moderator: CCGHQ Admins

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 12/6/2014

Postby Kithkin » 31 Dec 2014, 11:53

I thought we had fixed the issue with Rattleclaw Mystic. But it is still being cast face up without the overlay token. Funny thing is, that you can "turn it face up" for {2} . Then {U} {G} {R} are being added twice!
User avatar
Kithkin
 
Posts: 456
Joined: 21 Feb 2014, 07:12
Location: Cologne, GERMANY
Has thanked: 11 times
Been thanked: 56 times

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 12/6/2014

Postby propel0 » 31 Dec 2014, 22:20

Sage of the Inward Eye is not granting lifelink and Warden of the Eye's enter the battlefield effect do not seem to be working
propel0
 
Posts: 39
Joined: 13 Aug 2012, 17:34
Has thanked: 2 times
Been thanked: 2 times

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 12/6/2014

Postby Kithkin » 02 Jan 2015, 12:24

Kithkin wrote:I thought we had fixed the issue with Rattleclaw Mystic. But it is still being cast face up without the overlay token. Funny thing is, that you can "turn it face up" for {2} . Then {U} {G} {R} are being added twice!
Remember when i had to delete Neo's KTK dlc to fix an issue with a card? It's similar with Rattleclaw Mystic. Without his mod, the mystic does not work. :(
User avatar
Kithkin
 
Posts: 456
Joined: 21 Feb 2014, 07:12
Location: Cologne, GERMANY
Has thanked: 11 times
Been thanked: 56 times

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 12/6/2014

Postby Kithkin » 11 Jan 2015, 06:51

Bug report

Necromantic Selection -- "return a card to the battlefield" does not work
User avatar
Kithkin
 
Posts: 456
Joined: 21 Feb 2014, 07:12
Location: Cologne, GERMANY
Has thanked: 11 times
Been thanked: 56 times

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 12/6/2014

Postby volrathxp » 19 Jan 2015, 23:42

It should be fairly obvious that I've been heavily MIA. This topic actually stopped notifying me for some weird reason. I'm not sure why that is. I just assumed people stopped commenting on it.

I am quite sorry, but I don't really feel like I have the investment in coding at the moment. There's a lot going on with my life right now (new daughter, possible surgery for her, etc etc) and this hasn't been on my list of priorities, nor has it really been interesting to me either. I haven't really even touched M14 Duels in a month or so (I just played a few games on there today and that's it)

I would not mind if someone wanted to update the cards that do have issues, otherwise most likely they will not get fixed.

So, yeah... I hate to leave it like that, but I'm probably done with this for now. Sorry to the very cool peeps who helped find bugs, you guys are pretty awesome.

I may still hang around and post, though. We'll see.
volrathxp
User avatar
volrathxp
 
Posts: 362
Joined: 23 Jul 2014, 17:34
Has thanked: 9 times
Been thanked: 17 times

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 12/6/2014

Postby Kithkin » 19 Jan 2015, 23:54

volrathxp wrote:It should be fairly obvious that I've been heavily MIA. This topic actually stopped notifying me for some weird reason. I'm not sure why that is. I just assumed people stopped commenting on it.

I am quite sorry, but I don't really feel like I have the investment in coding at the moment. There's a lot going on with my life right now (new daughter, possible surgery for her, etc etc) and this hasn't been on my list of priorities, nor has it really been interesting to me either. I haven't really even touched M14 Duels in a month or so (I just played a few games on there today and that's it)

I would not mind if someone wanted to update the cards that do have issues, otherwise most likely they will not get fixed.

So, yeah... I hate to leave it like that, but I'm probably done with this for now. Sorry to the very cool peeps who helped find bugs, you guys are pretty awesome.

I may still hang around and post, though. We'll see.
Sorry to hear that. It was fun while it lasted. Take care and good luck.
User avatar
Kithkin
 
Posts: 456
Joined: 21 Feb 2014, 07:12
Location: Cologne, GERMANY
Has thanked: 11 times
Been thanked: 56 times

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 12/6/2014

Postby RiiakShiNal » 20 Jan 2015, 00:58

I don't necessarily have a lot of time, but if someone posts the code of the cards that is having problems I can give it a look through to see if the problems can be fixed at least semi-easily.
RiiakShiNal
Programmer
 
Posts: 2188
Joined: 16 May 2011, 21:37
Has thanked: 75 times
Been thanked: 497 times

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 12/6/2014

Postby Xenoix » 15 Feb 2015, 21:14

Perhaps my timing is incorrect, but I can't seem to get Jazal Goldmane's ability to work. I've tried right as attackers were declared, and then after blockers were declared.
Xenoix
 
Posts: 7
Joined: 09 Feb 2015, 07:43
Has thanked: 2 times
Been thanked: 0 time

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 12/6/2014

Postby RiiakShiNal » 16 Feb 2015, 02:55

While technically the ability can be used at any time it should only really be used after attackers have been declared and before end of combat on your turn (doesn't make sense to use it on your opponents turn, but nothing in the rules would stop you from doing that).

If you are having problems with the ability post the code and let us take a look, it could just be you need another set of eyes to look it over.
RiiakShiNal
Programmer
 
Posts: 2188
Joined: 16 May 2011, 21:37
Has thanked: 75 times
Been thanked: 497 times

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 12/6/2014

Postby Xenoix » 16 Feb 2015, 04:01

Code: Select all
<FILTER filter_id="0">
   local filter = ClearFilter()
   filter:Add(FE_TYPE,OP_IS,CARD_TYPE_CREATURE)
   filter:Add(FE_IS_ATTACKING, true)
   filter:Add(FE_CONTROLLER, OP_IS, EffectController())
   EffectDC():Set_Int(0, filter:Count() )
</FILTER>
<CONTINUOUS_ACTION layer="7C">
    if FilteredCard() ~= nil then
       FilteredCard():GetCurrentCharacteristics():Power_Add( EffectDC():Get_Int(0) )
       FilteredCard():GetCurrentCharacteristics():Toughness_Add( EffectDC():Get_Int(0)
    end
</CONTINUOUS_ACTION>
<DURATION simple_duration="UntilEOT" />
  </ACTIVATED_ABILITY>
  <HELP title="MORE_INFO_BADGE_TITLE_0" body="MORE_INFO_BADGE_BODY_0" zone="ZONE_ANY" />
  <SFX text="COMBAT_BLUNT_LARGE_ATTACK" power_boundary_min="4" power_boundary_max="-1" />
  <SFX text="COMBAT_BLUNT_SMALL_ATTACK" power_boundary_min="1" power_boundary_max="3" />
Sorry, I just started altering DOTP about 4 days ago. Can't exactly say I know what I'm looking for yet.
Xenoix
 
Posts: 7
Joined: 09 Feb 2015, 07:43
Has thanked: 2 times
Been thanked: 0 time

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 12/6/2014

Postby Kithkin » 16 Feb 2015, 06:16

RiiakShiNal wrote:While technically the ability can be used at any time it should only really be used after attackers have been declared and before end of combat on your turn (doesn't make sense to use it on your opponents turn, but nothing in the rules would stop you from doing that).

If you are having problems with the ability post the code and let us take a look, it could just be you need another set of eyes to look it over.
If I understand this correctly, Xenoix is not trying to code a new card but rather trying to find out if the card works as intended. Jazal Goldmane has been coded already and is included in VXP'S dlc, although there is no deck containing it. I'll do some tests and try to find out.

Update: The activated ability does not trigger.
[lua] [string "JAZAL_GOLDMANE_1000389567_TITLE (CONTINUOUS_ACTION)~0x0000020e"]:5: ')' expected (to close '(' at line 4) near 'end'

Xander, Jazal Goldmane is not in the CW card pool. I wonder why? Seems to be a good card. :wink:
User avatar
Kithkin
 
Posts: 456
Joined: 21 Feb 2014, 07:12
Location: Cologne, GERMANY
Has thanked: 11 times
Been thanked: 56 times

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 12/6/2014

Postby Xander9009 » 16 Feb 2015, 11:44

I'm not sure why it wasn't included. I just thought of a new way to check whether a card is included or not and found 12 from this mod. I'll get those (which do indeed include Jazal) imported later today. (Then I'll check the other mods and see if any of those were missed).

I would point out that I just looked at the code of the copy in here and it looks like it should be working (although it wouldn't work properly in two headed giant).
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 445 times

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 12/6/2014

Postby RiiakShiNal » 16 Feb 2015, 12:01

Well, as for the script error that is because the line with Toughness_Add() is missing an end parenthesis and should be:
Code: Select all
FilteredCard():GetCurrentCharacteristics():Toughness_Add( EffectDC():Get_Int(0) )
Additionally, this won't work because the CONTINUOUS_ACTION block does not reference the filter using filter_id="0".

Usually though it is not good to set registers inside of a filter block as it can provide undefined results (in other words may not work as expected). It is more reliable to set the count in a PLAY_TIME_ACTION block then use the FILTER block to determine the affected creatures and use the CONTINUOUS_ACTION block to apply the effect. Like this:
| Open
Code: Select all
<PLAY_TIME_ACTION>
   local filter = ClearFilter()
   filter:Add(FE_TYPE,OP_IS,CARD_TYPE_CREATURE)
   filter:Add(FE_IS_ATTACKING, true)
   EffectDC():Set_Int(0, filter:Count() )
</PLAY_TIME_ACTION>
<FILTER filter_id="0">
   local filter = ClearFilter()
   filter:Add(FE_TYPE,OP_IS,CARD_TYPE_CREATURE)
   filter:Add(FE_IS_ATTACKING, true)
   filter:Add(FE_CONTROLLER, OP_IS, EffectController())
</FILTER>
<CONTINUOUS_ACTION layer="7C" filter_id="0">
   if FilteredCard() ~= nil then
      FilteredCard():GetCurrentCharacteristics():Power_Add( EffectDC():Get_Int(0) )
      FilteredCard():GetCurrentCharacteristics():Toughness_Add( EffectDC():Get_Int(0) )
   end
</CONTINUOUS_ACTION>
<DURATION simple_duration="UntilEOT" />
RiiakShiNal
Programmer
 
Posts: 2188
Joined: 16 May 2011, 21:37
Has thanked: 75 times
Been thanked: 497 times

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 12/6/2014

Postby Xander9009 » 16 Feb 2015, 12:08

Good eye. Also, if you're going to split them up, shouldn't we be dropping the controller check from the count filter? Jazal Goldmane increases your creatures power based on the total number of attacking creatures, not just ones you control.

| Open
Code: Select all
<PLAY_TIME_ACTION>
   local filter = ClearFilter()
   filter:Add(FE_TYPE,OP_IS,CARD_TYPE_CREATURE)
   filter:Add(FE_IS_ATTACKING, true)
   EffectDC():Set_Int(0, filter:Count() )
</PLAY_TIME_ACTION>
<FILTER filter_id="0">
   local filter = ClearFilter()
   filter:Add(FE_TYPE,OP_IS,CARD_TYPE_CREATURE)
   filter:Add(FE_IS_ATTACKING, true)
   filter:Add(FE_CONTROLLER, OP_IS, EffectController())
</FILTER>
<CONTINUOUS_ACTION layer="7C" filter_id="0">
   if FilteredCard() ~= nil then
      FilteredCard():GetCurrentCharacteristics():Power_Add( EffectDC():Get_Int(0) )
      FilteredCard():GetCurrentCharacteristics():Toughness_Add( EffectDC():Get_Int(0) )
   end
</CONTINUOUS_ACTION>
<DURATION simple_duration="UntilEOT" />
EDIT: As for the issue with setting registers from inside filter blocks, that makes sense, but I didn't know that. Useful info :)
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 445 times

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 12/6/2014

Postby RiiakShiNal » 16 Feb 2015, 12:29

Actually, I did remove the controller check from the count, but apparently you started writing your post before I removed it.
RiiakShiNal
Programmer
 
Posts: 2188
Joined: 16 May 2011, 21:37
Has thanked: 75 times
Been thanked: 497 times

PreviousNext

Return to 2014

Who is online

Users browsing this forum: No registered users and 24 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 24 users online :: 0 registered, 0 hidden and 24 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 24 guests

Login Form