Collectible Card Game Headquarters

gorem2k wrote:You have to tell me why you don't put this in your mod? I mean, this is lots of your ingredients. Isn't it good enough ?

I'll think about it, and I might make a separate file, just as you did (more or less: I would make a separate core as well). I don't want to mix those with the regular decks which have really few approximations that don't usually alter the game. The approximation level on Planeswalkers is still too high in my opinion to totally mix them with the other cards.

gorem2k wrote:The only thing I like a bit better in my mod is when AI attacks a Planeswalker, for each of them, the card gets zoomed and we see how many counters remain. this sometimes useful when there's 6 or more counters that looks like a thick red line.

The other difference is that you made the choice about attacking a Planeswalker trigger when blockers are declared, which, besides being wrong, gives you less time to think (actually, no time at all). I made the choice trigger when attackers are declared, and then I had to choose about which card to zoom in (zooming in both cards would have required 2 queries for each attacker and I would find them really annoying to click through). I chose to zoom in the attacker because you usually have no more than a couple of Planeswalkers out on the battlefield, while attackers can be a dozen sometimes, so I think it's more important to see exactly which attacker goes against your Planeswalker if you need to decide how to block. You can zoom in the Planeswalker by yourself before declaring blockers, if you really want to.

thefiremind wrote:You can zoom in the Planeswalker by yourself before declaring blockers, if you really want to.

I was using the "attacking and isn't blocked" which is even worse, it's after declare blockers!

I think you didn't understand exactly what I meant. I'm talking about the final combat step; well after we've declared who attacks who. it would be nice to see closer which planeswalker was dealt damage. I myself, always zoom the card at that point. I know this would mean another click but then, these clicks would stop when the planeswalker is dead. anyway I don't want to patronize. It's your say. just wanted you to understand my opinion. I feel like I never make sense to you ..

btw, I always zoom a planeswalker after combat so clicking one more time or zooming a card, either I don't find it annoying.

EDIT: I've re-read my post and I said ".. when AI attacks a planeswalker" I should've said when damage is done.

EDIT2: and if you're open about suggestions, why not embed (grant) a text with the name of planeswalker each creature attacks so we can double check while the declare blockers timer is stopped.

gorem2k wrote:I think you didn't understand exactly what I meant. I'm talking about the final combat step; well after we've declared who attacks who. it would be nice to see closer which planeswalker was dealt damage. I myself, always zoom the card at that point. I know this would mean another click but then, these clicks would stop when the planeswalker is dead. anyway I don't want to patronize. It's your say. just wanted you to understand my opinion. I feel like I never make sense to you ..

btw, I always zoom a planeswalker after combat so clicking one more time or zooming a card, either I don't find it annoying.

EDIT: I've re-read my post and I said ".. when AI attacks a planeswalker" I should've said when damage is done.

You do make sense to me, when you help me understanding what you mean.
My point of view is that an additional query is useful if you can use that information somehow. When damage is being dealt it's too late to do anything, so what do you gain by knowing how many counters remain on the Planeswalker a moment before being able to zoom it in by yourself? I know it would be nice to see the Planeswalker and the creature zoom in side by side just as when you see the animations of creature-against-creature combat damage (maybe this was what you really wanted?), but we can't do that. So, I don't like this idea if I need an additional query to make it, but that's just my opinion.

gorem2k wrote:EDIT2: and if you're open about suggestions, why not embed (grant) a text with the name of planeswalker each creature attacks so we can double check while the declare blockers timer is stopped.

That would be awesome, but it's impossible because we can't have dynamic ability text. It would be possible to make a dummy static ability for each existing Planeswalker, but they would be boring as hell to write.

V9 uploaded. it has many things to fix; I need your help!

gorem2k wrote:· Vraska the Unseen and Domri Rade subtypes aren't recognized.

They are recognized, but they are missing their localised text. You need to declare CARD_SUBTYPE_VRASKA and CARD_SUBTYPE_DOMRI in a TEXT_PERMANENT XML, as I wrote here.

gorem2k wrote:· I don't know how to implement Vraska 's first ability with token manager.

I'm working on a solution through a storage like the one I use for transform cards. It will take a while to complete it, though.
EDIT: My storage wasn't working, I don't know why, so I switched to RiiakShiNal's ObjectDC. Now Vraska seems to work fine, next step is Garruk Relentless.

To exclude Sorin from himself you just have to add

Code: Select all

Filter:Add(FE_CARD_INSTANCE, OP_NOT, EffectSource() )

I just tested the Oracle of Mul Daya and Jace, the Mind Sculptor in your deck and I don't get that problem

East Bay wrote:To exclude Sorin from himself you just have to add

Code: Select all

Filter:Add(FE_CARD_INSTANCE, OP_NOT, EffectSource() )

I just tested the Oracle of Mul Daya and Jace, the Mind Sculptor in your deck and I don't get that problem

last time I added FE_CARD_INSTANCE, OP_NOT, EffectSource() on Sorin, it wasn't working... but now I've added it right after ClearFilter() and before Set_Or() and Tada! Unfortunately, I've uploaded my update just before fixing it.

about Oracle + Jace, maybe you have the latest Steam update or the Core fix ? I have none of these and it still hang when I use the ability.

gorem2k wrote:about Oracle + Jace, maybe you have the latest Steam update or the Core fix ?

Yeah the new update fixed a bug with Oracle and Into the Wilds.

This is great guys. I am just testing it, and I thought you might like to know about a few bugs.

Elspeth's +1 ability doesn't create a token creature, but it does get a loyalty counter. Her giving indestructible ability to my creatures also seem to give to the opponent's as well.

Ajani Vengeant for me doesn't get loyalty counters when I activate his +1 ability, but he sure can lose them.

Garruk Caller of Beast's +1 ability doesn't work.

Edit - is there anyway for these cards to be viewed in Rik's editor, because so far I can't see them.

mr friendly guy wrote:This is great guys. I am just testing it, and I thought you might like to know about a few bugs.

Well, thanks for taking some of your time to report bugs.

mr friendly guy wrote:Elspeth's +1 ability doesn't create a token creature, but it does get a loyalty counter. Her giving indestructible ability to my creatures also seem to give to the opponent's as well.

The soldier token was in my non-planeswalker wad (4440), it's now in both wads (4440 and 4400). It should spawn in my upcoming V11. I've just fixed the indestructible ability.

mr friendly guy wrote:Ajani Vengeant for me doesn't get loyalty counters when I activate his +1 ability, but he sure can lose them.

I'm surprised this happen for Ajani, I thought it was fixed in V9. maybe it is in V10 ?

mr friendly guy wrote:Garruk Caller of Beast's +1 ability doesn't work.

This one won't seem to work if none of the 5 top cards contains any creature. Planeswalker aren't creature. + this card was coded by thefiremind and I seriously doubt it has a bug

mr friendly guy wrote:Edit - is there anyway for these cards to be viewed in Rik's editor, because so far I can't see them.

you can do like me, in the lower window of Deck builder, click on "File Name" tab to sort alphabetically by "File Name", then look for letter P as every planeswalker I do begins with PLW_ . note that you must not add _PLW_GARRUK_THE_VEILCURSED because it's a transform card!

gorem2k wrote:This one won't seem to work if none of the 5 top cards contains any creature. Planeswalker aren't creature. + this card was coded by thefiremind and I seriously doubt it has a bug

Don't trust me so much... I forgot that the Reveal function doesn't reveal cards to their owner because it's usually pointless, but those cards should be revealed to everyone: knowing that a card moves to the bottom of your library is relevant. If you are OK with the old GuidedReveal (some players don't like it), you can remove the first RESOLUTION_TIME_ACTION and change the second as follows:

Code: Select all

    <RESOLUTION_TIME_ACTION>
    for i=0,4 do
       local card = EffectController():Library_GetTop()
       if card ~= nil then
          if card:GetCardType():Test(CARD_TYPE_CREATURE) then
             card:GuidedReveal(ZONE_LIBRARY, ZONE_HAND)
             card:PutInHand()
          else
             card:GuidedReveal(ZONE_LIBRARY, ZONE_LIBRARY)
             card:PutOnBottomOfLibrary() -- if you want to care about the order, this will need to be more complicated
          end
       end
    end
    </RESOLUTION_TIME_ACTION>

I'll probably do the same on my copy, I don't want to add a dummy query just to show the cards to the owner.

You seem to have ironed out most of the bugs. Garruk the Relentless doesn't transform, but it doesn't bother me since I wasn't planning on using him anyway.

I do have a use for Jace in my milling decks.

mr friendly guy wrote:Garruk the Relentless doesn't transform

Don't worry, I took care of him and Vraska. Version 3 of my test is ready!
Garruk the Relentless needs my mod (or at least, DATA_DLC_TFM_OTHER.WAD), while Vraska needs RiiakShiNal's ObjectDC.
I reviewed East Bay's Planeswalkers and threw some other ones in.
The test deck is ready to test the various Chandra versions (red instants and sorceries are required to test them).
And finally, here's something you probably didn't expect: I made a new version of Liliana of the Veil, with a different implementation of her ultimate! It seems to work fine when activated by human players, but I haven't tested my AI-exclusive code, which should split permanents according to the card score (very rudimental, but I expect it to make some good decisions now and then, if it works).
Oh I was forgetting: now the so-called "exceptions" are reversed: I listed the cards that aren't allowed to target Planeswalkers. This made easier for me to keep a separate list for "creature-Gideon".

something is off with v11 download..when I try to open game it keep crashing. I looked into it using errors in riiak deckbuilder but all I found was this:

| Open

Code: Select all

AM: Low: Can't find referenced card: PLW_ELSPETH_ASCENDED_444444441 for deck D14_4404_PLANESWALKERS in Data_Decks_4404_PLANESWALKERS

I had planewalkers added to some of my decks from v8, will that cause a problem ? I removed my decks and your mod and the game stopped crashing. also when I tried to download the file, my security stopped it for having malware which is a first for me.

edit: got it to work, replaced old with new cards.. they was exactly the name file name I thought when I updated my deck would be updated too.

thefiremind wrote:

mr friendly guy wrote:Garruk the Relentless doesn't transform

Don't worry, I took care of him and Vraska. Version 3 of my test is ready!

Great! I wasn't expecting that.. I understand you're being a modest person but is it safe to say you will somehow (sooner or later) do a Version 4? As I said before, it's safer if there's only one set for people to rely on, and you've basically done the best approximations. I'm just saying because now I don't know what I should do for V12

But firstly, let's try these Chandras you've done!

EDIT: Nice! you only forgot to add loyalties on Tezzeret. I tested Liliana ultimate on myself but was a bit confused when choosing a pile, I thought what I was picking would be saved but turns out it was the opposite . good work man! maybe say "Choose a card if you want to sacrifice this pile." instead of "Choose a card if you want to choose this pile.". two "choose" word in same sentence is a bit confusing.