Board index 
Programs with AI or Rules Enforcement Magic: The Gathering - Duels of the Planeswalkers New MTG Cards and Decks (2010, 2012, 2013, 2014, 2015, Magic Duels) 2014
Programs with AI or Rules Enforcement Magic: The Gathering - Duels of the Planeswalkers New MTG Cards and Decks (2010, 2012, 2013, 2014, 2015, Magic Duels) 2014
TFM&G2K's Planeswalkers Pool v8g (12/Sep/2014)
Moderator: CCGHQ Admins
Re: TFM&G2K's Planeswalkers Pool v8g (12/Sep/2014)
by fallenangle » 12 May 2015, 11:09
Update 05/12/2015: My fix for Chandra contained an error in the code, one I only discovered because I copied it into the code for Neo's PW upgrade. I'm including an update for both the regular PW Wad and Neo's PW Wad here. Enjoy, and if anyone finds any other problems or bugs, please let me know.
- fallenangle
- Posts: 319
- Joined: 20 Jul 2013, 02:31
- Has thanked: 73 times
- Been thanked: 41 times
Re: TFM&G2K's Planeswalkers Pool v8g (12/Sep/2014)
by fallenangle » 16 May 2015, 11:34
Update 05/16/2015: Added "Protection" to all Planeswalkers. This is the same thing they get in the CW, and was originally an innovation suggested by NeoAnderson when he was still active. It speeds up the game when Planeswalkers are on the board by reducing the number of calls made to the Manager, essentially automating the "cards not allowed to target planeswalkers" bit within each PW card itself. This update has been long overdue, but I just now got around to doing it. My apologies. Let me know if you encounter any bugs or problems, and enjoy the hard work of the many modders who made the PW pool what it is!
Last edited by fallenangle on 18 May 2015, 05:19, edited 1 time in total.
- fallenangle
- Posts: 319
- Joined: 20 Jul 2013, 02:31
- Has thanked: 73 times
- Been thanked: 41 times
Re: TFM&G2K's Planeswalkers Pool v8g (12/Sep/2014)
by Xander9009 » 16 May 2015, 20:15
Hey, so, I've reworked the protection a little. However, I noticed that they don't have protection while on the stack. This means that Annul can counter a planeswalker. I've tried various things, but none of them prevent Annul from countering the planeswalker I'm testing with (Chandra Nalaar). This affects all zones except the battlefield. Things that target enchantments in your graveyard, library, or hand will catch planeswalkers, too.
I might have found a better way to handle the protection. It uses a function like the original, but it doesn't use a loop like it did. The entire function is handled in a single function with no other function calls, and this prevents the lag but retains the ability to NOT have to change every single planeswalker when a new card that targets enchantments is introduced. I've tested it with 4 planeswalkers in a deck. There is a bit of lag any time more than about 6 planeswalkers on the battlefield at the same time. It doesn't happen with one or two on the battlefield, though, only with a bunch, so in normal play, it shouldn't have any lag at all. I had out 4 and my opponent had out 2 for a total of 6, and experienced very little lag. It was noticeable, but it was very slight. If you want, I'll post the code and the cards I already changed to test and you can try it out yourself and let me know if you think it's quick enough. I'd like a second opinion before changing any more. Basically, the goal is to not have every planeswalker card have to be changed just because there's a new card that targets and enchantments.
Just for the record, the function in the LOL file is this:
I might have found a better way to handle the protection. It uses a function like the original, but it doesn't use a loop like it did. The entire function is handled in a single function with no other function calls, and this prevents the lag but retains the ability to NOT have to change every single planeswalker when a new card that targets enchantments is introduced. I've tested it with 4 planeswalkers in a deck. There is a bit of lag any time more than about 6 planeswalkers on the battlefield at the same time. It doesn't happen with one or two on the battlefield, though, only with a bunch, so in normal play, it shouldn't have any lag at all. I had out 4 and my opponent had out 2 for a total of 6, and experienced very little lag. It was noticeable, but it was very slight. If you want, I'll post the code and the cards I already changed to test and you can try it out yourself and let me know if you think it's quick enough. I'd like a second opinion before changing any more. Basically, the goal is to not have every planeswalker card have to be changed just because there's a new card that targets and enchantments.
Just for the record, the function in the LOL file is this:
- | Open
- | Open
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
-
Xander9009 - Programmer
- Posts: 2905
- Joined: 29 Jun 2013, 07:44
- Location: Indiana, United States
- Has thanked: 121 times
- Been thanked: 445 times
Re: TFM&G2K's Planeswalkers Pool v8g (12/Sep/2014)
by zysron » 16 May 2015, 23:40
you cant make them loose enchantment can you? or do they have to have that definition to exist?
Re: TFM&G2K's Planeswalkers Pool v8g (12/Sep/2014)
by Xander9009 » 16 May 2015, 23:42
That's what I tried first. But if the card only has the planeswalker type, the game can't process it right.
Last edited by Xander9009 on 17 May 2015, 04:25, edited 1 time in total.
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
-
Xander9009 - Programmer
- Posts: 2905
- Joined: 29 Jun 2013, 07:44
- Location: Indiana, United States
- Has thanked: 121 times
- Been thanked: 445 times
Re: TFM&G2K's Planeswalkers Pool v8g (12/Sep/2014)
by fallenangle » 17 May 2015, 02:24
It looks good, but my PW_Manager is throwing up strange error logs at me now (and I didn't modify it recently), so I can't test this for the moment. I'll try to get it working, and then I'll let you know how it goes.
- fallenangle
- Posts: 319
- Joined: 20 Jul 2013, 02:31
- Has thanked: 73 times
- Been thanked: 41 times
Re: TFM&G2K's Planeswalkers Pool v8g (12/Sep/2014)
by fallenangle » 18 May 2015, 05:27
Update 05/18/2015: Thanks to Xander's hard work and studly debugging skills, I can present to you a working, updated PLW Wad that now handles protection through a filter in the PLW.LOL itself rather than through the manager. This should dramatically increase the speed and lessen the lag of PWs in the game. All I did was put the code in each of the existing PWs; it's Xander who deserves all the praise for the hard work of making the filter (and putting up with my repeated queries to fix things when all that was necessary was some Spring Cleaning of my Custom Data folder. Thanks, Xander!
Update 05/19/2015: Changed a few things and did more Spring Cleaning. It should work better now.
Update 05/19/2015: Changed a few things and did more Spring Cleaning. It should work better now.
Last edited by fallenangle on 25 May 2015, 11:32, edited 2 times in total.
- fallenangle
- Posts: 319
- Joined: 20 Jul 2013, 02:31
- Has thanked: 73 times
- Been thanked: 41 times
Re: TFM&G2K's Planeswalkers Pool v8g (12/Sep/2014)
by sunds » 18 May 2015, 13:26
Thanks for your work!fallenangle wrote:Update 05/18/2015: Thanks to Xander's hard work and studly debugging skills, I can present to you a working, updated PLW Wad that now handles protection through a filter in the PLW.LOL itself rather than through the manager. This should dramatically increase the speed and lessen the lag of PWs in the game. All I did was put the code in each of the existing PWs; it's Xander who deserves all the praise for the hard work of making the filter (and putting up with my repeated queries to fix things when all that was necessary was some Spring Cleaning of my Custom Data folder. Thanks, Xander!
But when I played a deck with ugin, the spirit dragon, I got a lot of script log errors.
[lua] [string "_PLANESWALKERS_MANAGER_991800002_TITLE (RESOLUTION_TIME_ACTION)~0x000002a0"]:5:
parameter mismatch or too few parameters [expected bzS32]
[lua] [string "TEJAHN_FRF_UGIN_THE_SPIRIT_DRAGON_9911749121015_TITLE (CONTINUOUS_ACTION)~0x00000262"]:2: attempt to call global 'PLW_Protection_Filter' (a nil value)
Re: TFM&G2K's Planeswalkers Pool v8g (12/Sep/2014)
by fallenangle » 19 May 2015, 01:07
I changed a few things, mostly shortening the filename on Ugin to match the cardname. I also deleted the Legacy Wad, the FRF Wad, and a few other Wads from my DOTP2014 folder that I thought might be causing problems. Try that if it still gives you errors, as I just tried a game with Ugin and it came back error free.
- fallenangle
- Posts: 319
- Joined: 20 Jul 2013, 02:31
- Has thanked: 73 times
- Been thanked: 41 times
Re: TFM&G2K's Planeswalkers Pool v8g (12/Sep/2014)
by Xander9009 » 19 May 2015, 02:00
Just for the record, I tested the wad you posted and it seemed to work fine for Ajani Goldmane. It originally had problems when running alongside the CW, but in the next repack that will be fixed (and it'll also have the protection changes before long if everyone likes how they're running).
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
-
Xander9009 - Programmer
- Posts: 2905
- Joined: 29 Jun 2013, 07:44
- Location: Indiana, United States
- Has thanked: 121 times
- Been thanked: 445 times
Re: TFM&G2K's Planeswalkers Pool v8g (12/Sep/2014)
by sunds » 19 May 2015, 02:37
Unfortunately the two errors are still there. The first error log happens when ugin is drawn in my hand. The second error log happens when I use ugin's ability(for example its first ability).fallenangle wrote:I changed a few things, mostly shortening the filename on Ugin to match the cardname. I also deleted the Legacy Wad, the FRF Wad, and a few other Wads from my DOTP2014 folder that I thought might be causing problems. Try that if it still gives you errors, as I just tried a game with Ugin and it came back error free.
I only have cw files in my game folder.
Re: TFM&G2K's Planeswalkers Pool v8g (12/Sep/2014)
by fallenangle » 19 May 2015, 07:23
Thanks for your reply, and for the detailed information.
I don't use the CW, and the PW Wad was never designed to be used in conjunction with the CW. If Xander's latest repack tonight doesn't fix the problem, let me know, and I'll see what I can do.
I don't use the CW, and the PW Wad was never designed to be used in conjunction with the CW. If Xander's latest repack tonight doesn't fix the problem, let me know, and I'll see what I can do.
- fallenangle
- Posts: 319
- Joined: 20 Jul 2013, 02:31
- Has thanked: 73 times
- Been thanked: 41 times
Re: TFM&G2K's Planeswalkers Pool v8g (12/Sep/2014)
by zysron » 19 May 2015, 07:36
i played with planeswalkers a few weeks ago there was a problem witch made me stop but it is fixed now and i am soo happy
this was the problem that got fixed
this was the problem that got fixed
- | Open
Re: TFM&G2K's Planeswalkers Pool v8g (12/Sep/2014)
by fallenangle » 20 May 2015, 22:38
I still get the weird RTA error log pointing to line 5 in the Manager, but only after I play through a full game with my PWs. When I just test them briefly, the error doesn't show up. If you have some time, could you do some more tests and look into it?Just for the record, I tested the wad you posted and it seemed to work fine for Ajani Goldmane. It originally had problems when running alongside the CW, but in the next repack that will be fixed (and it'll also have the protection changes before long if everyone likes how they're running).
- fallenangle
- Posts: 319
- Joined: 20 Jul 2013, 02:31
- Has thanked: 73 times
- Been thanked: 41 times
Who is online
Users browsing this forum: Baidu [Spider] and 33 guests