Collectible Card Game Headquarters

Parabolic wrote:I noticed Dack Fayden isn't accounted for. Any interest in adding him, or is he not possible to code?

His ultimate might be a pain to code (same problems as the heroic mechanic), but I don't think it's impossible. However I usually don't code cards before they can be found on Gatherer, because I want to include all translations and give the card its real Multiverse ID.

Bug report

Vraska the Unseen -- +1 ability is not working correctly; creatures dealing combat damage to her are not destroyed; and yes, I use objectdc.wad

Kithkin wrote:Bug report

Vraska the Unseen -- +1 ability is not working correctly; creatures dealing combat damage to her are not destroyed; and yes, I use objectdc.wad

Luckily I ran into the same problem before, so I understood what was going on fairly quickly: it's probably since one of the last updates that triggers cannot be fired from replacement_effect/query abilities, because Vraska was working the last time I checked. I changed the ability that fires the OBJECT_TAKES_DAMAGE trigger from replacement_effect="1" to forced_skip="1" and now she works again.

Hello, I wanted to bring up two issues that I've encountered. Before I start the part where it says that Planeswalkers are still APPROXIMATED doesn't escape me but I figured its always best to bring up the issues regardless of whether they can be fixed or not. Anyways, I noticed that when the annihilator ability triggers for the first time against an opponent AI the AI always scarifies 1 less permanent then required but will properly sacrifice permanents each turn after that. This leads me to believe that the AI is sacrificing its planeswalker token since it does not need it at that time. Now on to the 2nd issue I've noticed; I had a changeling on the field but I noticed that when an opponent creature attacked, it showed that it was deciding to attack the changeling as if the changeling was a planeswalker (there was no planeswalker on the field at that time).

NEMESiS wrote:I figured its always best to bring up the issues regardless of whether they can be fixed or not.

Of course it is, bring them on!

NEMESiS wrote:I noticed that when the annihilator ability triggers for the first time against an opponent AI the AI always scarifies 1 less permanent then required but will properly sacrifice permanents each turn after that. This leads me to believe that the AI is sacrificing its planeswalker token since it does not need it at that time.

There's nothing I can do about it: the annihilator ability should be re-coded while having invisible tokens in mind (in other words, all permanent types need to be specified in the filter, rather than using IS_PERMANENT).

NEMESiS wrote:Now on to the 2nd issue I've noticed; I had a changeling on the field but I noticed that when an opponent creature attacked, it showed that it was deciding to attack the changeling as if the changeling was a planeswalker (there was no planeswalker on the field at that time).

I really can't figure out how this could happen: Planeswalkers are filtered by their name, so it would happen with a changeling that has the same name as a Planeswalker, which is impossible (at least in DotP), unless you code one on purpose.
You could try to change this:

Code: Select all

       EffectController():ChooseItem( "PLW_CARD_QUERY_CHOOSE_PLANESWALKER_TO_ATTACK", EffectDC():Make_Targets(0), QUERY_FLAG_MAY )

into this:

Code: Select all

       if filter:CountStopAt(1) == 1 then
          EffectController():ChooseItem( "PLW_CARD_QUERY_CHOOSE_PLANESWALKER_TO_ATTACK", EffectDC():Make_Targets(0), QUERY_FLAG_MAY )
       end

inside the Planeswalkers manager, but I doubt it would change much: official cards never need to perform that check.

thefiremind wrote:

NEMESiS wrote:I noticed that when the annihilator ability triggers for the first time against an opponent AI the AI always scarifies 1 less permanent then required but will properly sacrifice permanents each turn after that. This leads me to believe that the AI is sacrificing its planeswalker token since it does not need it at that time.

There's nothing I can do about it: the annihilator ability should be re-coded while having invisible tokens in mind (in other words, all permanent types need to be specified in the filter, rather than using IS_PERMANENT).

It sounds like NEMESiS needs to use the Core Fixes and make sure that any cards that use Annihilator are coded with the functions I provide in there as I did make sure to require that a card is of at least one of the 5 types (Artifact, Creature, Enchantment, Land, Planeswalker [even though DotP doesn't really have support for planeswalkers]) of which invisible tokens are typeless.

RSN_Annihilator_Permanent_Choosing() | Open

Code: Select all

RSN_Annihilator_Permanent_Choosing = function( nAmount )
   local oPlayer = RSN_GetDefendingPlayer( EffectSourceLKI() )
   if (oPlayer ~= nil) then
      local oFilter = ClearFilter()
      local oSubFilter = oFilter:AddSubFilter_Or()
      oFilter:Add( FE_CONTROLLER, OP_IS, oPlayer )
      oSubFilter:Add( FE_TYPE, OP_IS, CARD_TYPE_ARTIFACT )
      oSubFilter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
      oSubFilter:Add( FE_TYPE, OP_IS, CARD_TYPE_ENCHANTMENT )
      oSubFilter:Add( FE_TYPE, OP_IS, CARD_TYPE_LAND )
      oSubFilter:Add( FE_TYPE, OP_IS, CARD_TYPE_PLANESWALKER )
      oPlayer:SetItemCount( nAmount )
      for i = 0, (nAmount - 1) do
         oPlayer:SetItemPrompt (i, "CARD_QUERY_ANNILHILATOR_CHOOSE_A_PERMANENT_TO_SACRIFICE" )
      end
      oPlayer:ChooseItems( EffectDC():Make_Targets(1) )
   end
end

ive noticed that since ive updated my planeswalker pool and added Kiora, Duck fayden, and Ajani Goldenmane that during my turn before i use any of their abilities the game decides to drop in frame rate so hard that it is affecting game play and im curious if its happening to anything else or if i just need to check my settings

MasterXploder7 wrote:ive noticed that since ive updated my planeswalker pool and added Kiora, Duck fayden, and Ajani Goldenmane that during my turn before i use any of their abilities the game decides to drop in frame rate so hard that it is affecting game play

I can guess it's because now all players have a copy of the Planeswalkers manager, and the problem is probably magnified with more than 2 players. I don't see any issue like that on my PC, but older PCs could be in trouble. There's not much I can do: some things, such as checking when a Planeswalker has no loyalty counters left, need to be done continuously, and this has an impact on performance.

Is there anything i could do to use the PW without having that lag? I run the game on a laptop so i would have to assume the processor isnt that high powered. but none the less i hope there is an easy work around

MasterXploder7 wrote:Is there anything i could do to use the PW without having that lag? I run the game on a laptop so i would have to assume the processor isnt that high powered. but none the less i hope there is an easy work around

I take the performance in consideration by myself (reducing the iterations for example) whenever I can, so my code is usually already optimized as much as I can... if I knew how to make it better I would have written it better in the first place. Another pair of eyes may see something I can't see, but the only other person who was involved in the project is gorem2k and I haven't seen him here for a while, I guess he got bored and he's probably waiting for DotP2015 (I perfectly understand him ).

Are there going to be any more updates for DotP 2014, or is all work going into DotP 2015 from now on?

orlouge82 wrote:Are there going to be any more updates for DotP 2014, or is all work going into DotP 2015 from now on?

I can't say for sure. I still need to see how much DotP2015 is moddable.

thefiremind wrote:I guess he got bored and he's probably waiting for DotP2015 (I perfectly understand him ).

Exactly

I'll probably return and do some testing when/if this ZED mystery is solved. I took a day off only to read messages here... it looks promising for 2015 and I'm glad you guys are still active here.

gorem2k wrote:it looks promising for 2015

It looks indeed promising for a number of things, but not for Planeswalkers...

thefiremind wrote:Bad news about Planeswalkers: if I give the Planeswalker type to a card, the game gets stuck on loading.

thefiremind wrote:

gorem2k wrote:it looks promising for 2015

It looks indeed promising for a number of things, but not for Planeswalkers...

thefiremind wrote:Bad news about Planeswalkers: if I give the Planeswalker type to a card, the game gets stuck on loading.

Oh man, bummer