Collectible Card Game Headquarters

I have been updating my decks since you guys released this. I must say that it has been so much fun having Planeswalkers around!

I was toying around with Doubling Season and Garruk... Doubling the "loyalty counters" on Garruk went well as he came onto the battlefield. But then, Doubling Season also doubled the "+ loyalty cost" on Garruk, which shouldn't be eg.

Garruk, Prime Hunter @ 3 Loyalty counters:
+1: Put a 3/3 green Beast creature token onto the battlefield.

Garruk now has 5 Loyalty counters instead of 4. Was quite happy getting 5 at first but after checking with the ruling, it should be 4... =(

If you've the time could you please look into it?

Meanwhile, please keep up the good work!

jacque wrote:Garruk, Prime Hunter @ 3 Loyalty counters:
+1: Put a 3/3 green Beast creature token onto the battlefield.

Garruk now has 5 Loyalty counters instead of 4. Was quite happy getting 5 at first but after checking with the ruling, it should be 4... =(

If you've the time could you please look into it?

I searched for evidence of this (not that I don't believe in you, I just like to find as many sources as possible when talking about subtle rulings) and yes, you are right, the difference is that costs shouldn't be considered as effects. As such, if the DotP engine cares about that rule, the problem should be avoided by enclosing the "+x" parts in a generic COST block. If that doesn't work, then the fix will become quite complex... I hope not.
EDIT: It doesn't work. Even with this:

Code: Select all

<COST type="RemoveCountersSelf" amount="-1" counter_type="Loyalty" />

(which by the way works exactly as you could expect, it would be a nice way to shorten the code for adding counters as cost if it wasn't for Doubling Season) the counters are still doubled.
I'll have to try and shut down Doubling Season for a brief moment while paying the cost.

EDIT 2: The workaround seems to work pretty fine, try it and let me know if there are any problems.

this script generated when I've updated to v3 and browsed a deck.

"[lua] [string "Content\Functions\D14_PLW.LOL"]:400: 'then' expected near '&'
[lua]
lua_dofile error parsing file Content\Functions\D14_PLW.LOL"

also Garruk went straight to graveyard when Doubling Season was in play! what's happening!!

added filter:Add(FE_CONTROLLER, OP_IS, EffectController()) to not shut down possible opponents Doubling Season while paying. I'm trying to find where you put the ending effect for shutdown.

Code: Select all

PLW_ShutDownDoublingSeason = function()
-- to be used in costs that add counters, so that Doubling Season doesn't double them
   local filter = ClearFilter()
   filter:Add(FE_CARD_NAME, OP_IS, "DOUBLING_SEASON")
   filter:Add(FE_CONTROLLER, OP_IS, EffectController())
   local filter_count = filter:EvaluateObjects()
   if filter_count ~= nil then
      for i=0,filter_count-1 do
         filter:GetNthEvaluatedObject(i):GetCurrentCharacteristics():LoseAllAbilities()
      end
   end
end


EDIT: replaced if filter_count > 0 with ~= nil and now it's working.

is v4 coming out soon cause planewalkers go straight to graveyard..

Errors | Open

Code: Select all

[lua] [string "Content\Functions\D14_PLW.LOL"]:400: 'then' expected near '&'
[lua]
lua_dofile error parsing file Content\Functions\D14_PLW.LOL


[lua] [string "JACE_MEMORY_ADEPT_991370728_TITLE (RESOLUTION_TIME_ACTION)~0x00000385"]:2: attempt to call global 'PLW_CreateUniqueToken' (a nil value)
[lua] [string "JACE_BELEREN_991205960_TITLE (RESOLUTION_TIME_ACTION)~0x00000395"]:2: attempt to call global 'PLW_CreateUniqueToken' (a nil value)
[lua] [string "SORIN_LORD_OF_INNISTRAD_991368535_TITLE (RESOLUTION_TIME_ACTION)~0x0000040c"]:2: attempt to call global 'PLW_CreateUniqueToken' (a nil value)
[lua] [string "LILIANA_VESS_991205961_TITLE (RESOLUTION_TIME_ACTION)~0x00000419"]:2: attempt to call global 'PLW_CreateUniqueToken' (a nil value)
[lua] [string "SORIN_LORD_OF_INNISTRAD_991368535_TITLE (RESOLUTION_TIME_ACTION)~0x0000040c"]:2: attempt to call global 'PLW_CreateUniqueToken' (a nil value)
[lua] [string "Content\Functions\D14_PLW.LOL"]:400: 'then' expected near '&'
[lua]
lua_dofile error parsing file Content\Functions\D14_PLW.LOL


[lua] [string "SORIN_LORD_OF_INNISTRAD_991368535_TITLE (RESOLUTION_TIME_ACTION)~0x0000080b"]:2: attempt to call global 'PLW_CreateUniqueToken' (a nil value)
[lua] [string "LILIANA_VESS_991205961_TITLE (RESOLUTION_TIME_ACTION)~0x00000818"]:2: attempt to call global 'PLW_CreateUniqueToken' (a nil value)
[lua] [string "SORIN_LORD_OF_INNISTRAD_991368535_TITLE (RESOLUTION_TIME_ACTION)~0x0000080b"]:2: attempt to call global 'PLW_CreateUniqueToken' (a nil value)
[lua] [string "Content\Functions\D14_PLW.LOL"]:400: 'then' expected near '&'
[lua]
lua_dofile error parsing file Content\Functions\D14_PLW.LOL


[lua] [string "JACE_BELEREN_991205960_TITLE (RESOLUTION_TIME_ACTION)~0x00000bcd"]:2: attempt to call global 'PLW_CreateUniqueToken' (a nil value)
[lua] [string "JACE_MEMORY_ADEPT_991370728_TITLE (RESOLUTION_TIME_ACTION)~0x00000bbd"]:2: attempt to call global 'PLW_CreateUniqueToken' (a nil value)


drleg3nd wrote:is v4 coming out soon cause planewalkers go straight to graveyard..

It's just a small fix so I called it v3b. The new version was already up the time you were writing.

gorem2k wrote:this script generated when I've updated to v3 and browsed a deck.

"[lua] [string "Content\Functions\D14_PLW.LOL"]:400: 'then' expected near '&'
[lua]
lua_dofile error parsing file Content\Functions\D14_PLW.LOL"

EDIT: replaced if filter_count > 0 with ~= nil and now it's working.

That's not the problem: XML files need special characters to be escaped:

Code: Select all

>   -->   >
<   -->   &lt;
&   -->   &amp;
etc.

but LOL files don't, so those characters need to be written as they are. When I move code from an XML file to a LOL file it's very likely that I forget to do the conversion.

gorem2k wrote:added filter:Add(FE_CONTROLLER, OP_IS, EffectController()) to not shut down possible opponents Doubling Season while paying.

I totally forgot about that... thanks for pointing it out.

gorem2k wrote:I'm trying to find where you put the ending effect for shutdown.

Nowhere: if you put a continuous effect inside a RESOLUTION_TIME_ACTION, it will last until state-based effects are checked, which is the shortest time we can have.

thefiremind wrote:EDIT 2: The workaround seems to work pretty fine, try it and let me know if there are any problems.

It is working the way it should now! Great thinking back there... Thanks a lot! Buh... I found another glitch... =(

Sorin, Lord of Innistrad
(-6): Destroy up to three target creatures and/or other planeswalkers. Return each card put into a graveyard this way to the battlefield under your control.

So I managed to activate his ability, but those creatures were destroyed and remained in their owner's graveyard. *bummers*

Thanks again!

Edit 1: It seems that I can activate Sorin's ability twice. eg. After I used his first ability, I still can use his 2nd or 3rd ability... Hmmm... Other planeswalkers only gave me once per-turn (so far).

Edit 2: Sorin's +1/+0 emblem somewhat is global, affected my opponent's creatures as well.

jacque wrote:Edit 1: It seems that I can activate Sorin's ability twice. eg. After I used his first ability, I still can use his 2nd or 3rd ability... Hmmm... Other planeswalkers only gave me once per-turn (so far).

Edit 2: Sorin's +1/+0 emblem somewhat is global, affected my opponent's creatures as well.

As for me, I couldn't activate twice after activating first ability. emblem only affected my creatures BUT his ultimate ability didn't work. cards stayed in graveyard didn't come back.

I should add an important note about what I picked for last ability, I've chose 1 planeswalker, 1 normal creature and 1 TOKEN. maybe token is the problem here, code reads if target ~= nil and target:IsToken() == false then

maybe this isn't the problem?

i think IsToken() should be checked seperatly and after target ~= nil

EDIT: no, I don't really know why it don't work

gorem2k wrote:I should add an important note about what I picked for last ability, I've chose 1 planeswalker, 1 normal creature and 1 TOKEN.

As for my part, if this helps at all, I chose 2 creature cards and 1 creature token.

jacque wrote:Edit 1: It seems that I can activate Sorin's ability twice. eg. After I used his first ability, I still can use his 2nd or 3rd ability... Hmmm... Other planeswalkers only gave me once per-turn (so far).

Edit 2: Sorin's +1/+0 emblem somewhat is global, affected my opponent's creatures as well.

These 2 problems never happened to me, make sure you don't have old versions of the Planeswalkers mod (maybe the test version?).

As for the ultimate not bringing back creatures, I fixed it. The delayed trigger needed to be on ZONECHANGE_END rather than on ZONECHANGE_BEGIN.

thefiremind wrote:These 2 problems never happened to me, make sure you don't have old versions of the Planeswalkers mod (maybe the test version?).

Hmmm weird tho, cause I've been using the latest versions from this thread only... I'll look at it again

Update:
Elspeth Tirel
(-5): Destroy other permanents except lands and tokens.

Her last ability doesn't seem to work... Loyalty counters got reduced, but nothing got destroyed. Or maybe it's just me Could you please look into it when you've the time? Thanks again!

jacque wrote:Update:
Elspeth Tirel
(-5): Destroy other permanents except lands and tokens.

Her last ability doesn't seem to work... Loyalty counters got reduced, but nothing got destroyed. Or maybe it's just me Could you please look into it when you've the time? Thanks again!

That was my fault. She's fixed now, and in the meanwhile, I added the new Elspeth to the pack.

thefiremind wrote:That was my fault. She's fixed now, and in the meanwhile, I added the new Elspeth to the pack.

You are... Way too fast xD Thanks again!

Update:
Sorin's behaving normally with 3c =)

Edit:
New Elspeth is SWEET!!!

Just in case someone wonders, I don't plan on adding those in the very near future...

Other new Planeswalkers from Theros | Open

Elspeth was easy and with easy-to-translate abilities (I mean it was easy to find other cards with very similar abilities to copy text from), I prefer to wait for the Theros's release on Gatherer before making those.

Ah man those new planeswalkers have me extremely excited for Theros

Great work!!!

The only issue I've got with your mod, it's when I attack a planeswalker with several creatures. In this case, only one of them seems to deal damage to the planeswalker.