Page 28 of 38

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 10/6/2014

PostPosted: 07 Oct 2014, 08:21
by Cachexia
Kithkin wrote:Did you check if SARKHAN_THE_DRAGONSPEAKER_991386650 is available in deck builder (PLW)?
You're right, did a few searches for that and nothing came up. Stupid question but is there another mod I need to install? The only thing I changed before my game started crashing was updating to volrathxp's latest version (from 9/29/14 to 10/6/14), so I'm at a loss for ideas here.

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 10/6/2014

PostPosted: 07 Oct 2014, 09:24
by Kithkin
What you need is mentioned in the very first post. Did you update all three of vxp's wads?

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 10/6/2014

PostPosted: 07 Oct 2014, 09:40
by volrathxp
Ah I am sorry, the version of the PLW mod needed is the one that fallenangle posted in a recent post update on PLW mods thread. It includes Sarkhan and Sorin. As soon as I have the time I will provide a link in the original post (read - when I'm not dealing with new daughter and can get on my laptop to do so)

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 10/6/2014

PostPosted: 07 Oct 2014, 10:06
by Kithkin
O.k., in the meantime, here is the link to fallenangel's version:
viewtopic.php?f=109&t=11615&start=255#p163250

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 10/6/2014

PostPosted: 07 Oct 2014, 11:57
by Cachexia
That file fixed it. Thank you both for your help!

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 10/6/2014

PostPosted: 07 Oct 2014, 15:20
by volrathxp
Updated the original post with the link to the updated PLW wad.

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 10/7/2014

PostPosted: 08 Oct 2014, 15:39
by Kithkin
Bug report

When Brimaz, King of Oreskos attacks, no creature token is put onto the battlefield.

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 10/8/2014

PostPosted: 08 Oct 2014, 16:07
by volrathxp
Updated the other wad to fix this.

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 10/8/2014

PostPosted: 18 Oct 2014, 13:46
by volrathxp
Just a note that I'm not dead (yet!), and I am planning another update to this soon, that will bring cards from Invasion block into the mix. So, fun fun fun!

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 10/8/2014

PostPosted: 18 Oct 2014, 14:10
by NeoAnderson
volrathxp wrote:Just a note that I'm not dead (yet!), and I am planning another update to this soon, that will bring cards from Invasion block into the mix. So, fun fun fun!
I cannot talk for everyone here, but i am glad you are still alive! :mrgreen: :lol:

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 10/8/2014

PostPosted: 18 Oct 2014, 18:25
by Kithkin
Not posting any Bug reports does not mean there are no bugs or issues. I still have not tested all of your latest decks. Right now I am explicitly testing Mardu Midrange, which is very successfull even against TFM's decks.

There seems to be an issue with Goblin Rabblemaster. Another thread describes crashes. I can not confirm that. But what I experience is, that the Goblin token produced by the Rabblemaster does not always attack.

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 10/8/2014

PostPosted: 18 Oct 2014, 18:50
by volrathxp
Kithkin wrote:Not posting any Bug reports does not mean there are no bugs or issues. I still have not tested all of your latest decks. Right now I am explicitly testing Mardu Midrange, which is very successfull even against TFM's decks.

There seems to be an issue with Goblin Rabblemaster. Another thread describes crashes. I can not confirm that. But what I experience is, that the Goblin token produced by the Rabblemaster does not always attack.
I'm not sure about that issue. I've not had any issues with crashes myself but I have occasionally seen the attack thing. It's weird, not really sure what causes it.

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 10/8/2014

PostPosted: 19 Oct 2014, 00:25
by Xander9009
volrathxp wrote:
Kithkin wrote:Not posting any Bug reports does not mean there are no bugs or issues. I still have not tested all of your latest decks. Right now I am explicitly testing Mardu Midrange, which is very successfull even against TFM's decks.

There seems to be an issue with Goblin Rabblemaster. Another thread describes crashes. I can not confirm that. But what I experience is, that the Goblin token produced by the Rabblemaster does not always attack.
I'm not sure about that issue. I've not had any issues with crashes myself but I have occasionally seen the attack thing. It's weird, not really sure what causes it.
I noticed your filter for rabblemaster making other goblins attack does not specify your own creatures. This will cause enemies' goblin to also be forced to attack and also allies' golbins should you be in a 2HG game. There's also a bit of code on Goblin Assault (TFM) which might be useful. It specifies that the goblins only be forced to attack if they haven't already that turn, relevant if you have an additional combat phase. I looked it up to be sure, and it's right: multiple combat phases: must only attack during the first. Finally, for the issue being discussed, I've tried adding reevaluates="1" to the filter as it appears in many cards that affect whether creatures can attack/block/damage. I don't know exactly what it does, but it seems like the right thing to do.
Rabblemaster - Force Goblins to attack | Open
Code: Select all
<FILTER filter_id="0" reevaluates="1">>
  local filter = ClearFilter()
  filter:Add(FE_CARD_INSTANCE, OP_NOT, EffectSource())
  filter:Add(FE_SUBTYPE, OP_IS, CREATURE_TYPE_GOBLIN)
  filter:Add(FE_TYPE, OP_IS, CARD_TYPE_CREATURE)
  filter:Add( FE_CONTROLLER, OP_IS, EffectController())
  filter:Add( FE_LUA_CONDITION, 1, EffectController(), EffectDC() )
</FILTER>
<FILTER_CONDITION id="1">
  if FilteredCard() ~= nil then
    local interrogation = MTG():ClearInterrogationQuery()
    interrogation:SetObject( FilteredCard() )
    return interrogation:Test(INTERROGATE_ATTACKS, INTERROGATE_THIS_TURN) == false
  end
  return false
</FILTER_CONDITION>
<CONTINUOUS_ACTION layer="8" filter_id="0">
  if FilteredCard() ~= nil then
    FilteredCard():GetCurrentCharacteristics():Bool_Set(CHARACTERISTIC_MUST_ATTACK, 1)
  end
</CONTINUOUS_ACTION>

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 10/8/2014

PostPosted: 19 Oct 2014, 01:01
by volrathxp
Xander9009 wrote:
volrathxp wrote:
Kithkin wrote:Not posting any Bug reports does not mean there are no bugs or issues. I still have not tested all of your latest decks. Right now I am explicitly testing Mardu Midrange, which is very successfull even against TFM's decks.

There seems to be an issue with Goblin Rabblemaster. Another thread describes crashes. I can not confirm that. But what I experience is, that the Goblin token produced by the Rabblemaster does not always attack.
I'm not sure about that issue. I've not had any issues with crashes myself but I have occasionally seen the attack thing. It's weird, not really sure what causes it.
I noticed your filter for rabblemaster making other goblins attack does not specify your own creatures. This will cause enemies' goblin to also be forced to attack and also allies' golbins should you be in a 2HG game. There's also a bit of code on Goblin Assault (TFM) which might be useful. It specifies that the goblins only be forced to attack if they haven't already that turn, relevant if you have an additional combat phase. I looked it up to be sure, and it's right: multiple combat phases: must only attack during the first. Finally, for the issue being discussed, I've tried adding reevaluates="1" to the filter as it appears in many cards that affect whether creatures can attack/block/damage. I don't know exactly what it does, but it seems like the right thing to do.
Rabblemaster - Force Goblins to attack | Open
Code: Select all
<FILTER filter_id="0" reevaluates="1">>
  local filter = ClearFilter()
  filter:Add(FE_CARD_INSTANCE, OP_NOT, EffectSource())
  filter:Add(FE_SUBTYPE, OP_IS, CREATURE_TYPE_GOBLIN)
  filter:Add(FE_TYPE, OP_IS, CARD_TYPE_CREATURE)
  filter:Add( FE_CONTROLLER, OP_IS, EffectController())
  filter:Add( FE_LUA_CONDITION, 1, EffectController(), EffectDC() )
</FILTER>
<FILTER_CONDITION id="1">
  if FilteredCard() ~= nil then
    local interrogation = MTG():ClearInterrogationQuery()
    interrogation:SetObject( FilteredCard() )
    return interrogation:Test(INTERROGATE_ATTACKS, INTERROGATE_THIS_TURN) == false
  end
  return false
</FILTER_CONDITION>
<CONTINUOUS_ACTION layer="8" filter_id="0">
  if FilteredCard() ~= nil then
    FilteredCard():GetCurrentCharacteristics():Bool_Set(CHARACTERISTIC_MUST_ATTACK, 1)
  end
</CONTINUOUS_ACTION>
Neat, I will add that to the Rabblemaster code, and post a fix when I update next. Thanks for taking a look at that.

Re: Volrathxp's Custom Dotp 2014 DLC (Last Update: 10/8/2014

PostPosted: 19 Oct 2014, 13:20
by Kithkin
Bug report

Mindswipe -- does NOT deal X damage to controller