Collectible Card Game Headquarters

Carpet of Flowers .I don't know where the code goes wrong.It is triggered as normal at main phase 1 but is triggered twice at main phase 2.Here is the code

Code: Select all

<?xml version='1.0' encoding='UTF-8'?>
<CARD_V2 ExportVersion="1">
   <FILENAME text="CARPET_OF_FLOWERS_CW_5858" />
   <CARDNAME text="CARPET_OF_FLOWERS" />
   <TITLE>
      <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Carpet of Flowers]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Carpet of Flowers]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Carpet of Flowers]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Carpet of Flowers]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Carpet of Flowers]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[Carpet of Flowers]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Carpet of Flowers]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Carpet of Flowers]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Carpet of Flowers]]></LOCALISED_TEXT>
   </TITLE>
   <MULTIVERSEID value="5858" />
   <ARTID value="CW5858" />
   <ARTIST name="Rebecca Guay" />
   <CASTING_COST cost="{G}" />
   <TYPE metaname="Enchantment" />
   <EXPANSION value="UZ" />
   <RARITY metaname="U" />
   <TRIGGERED_ABILITY forced_skip="1">
      <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[At the beginning of each of your main phases, if you haven’t added mana to your mana pool with this ability this turn, you may add up to X mana of any one color to your mana pool, where X is the number of Islands target opponent controls.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[At the beginning of each of your main phases, if you haven’t added mana to your mana pool with this ability this turn, you may add up to X mana of any one color to your mana pool, where X is the number of Islands target opponent controls.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[At the beginning of each of your main phases, if you haven’t added mana to your mana pool with this ability this turn, you may add up to X mana of any one color to your mana pool, where X is the number of Islands target opponent controls.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[At the beginning of each of your main phases, if you haven’t added mana to your mana pool with this ability this turn, you may add up to X mana of any one color to your mana pool, where X is the number of Islands target opponent controls.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[All’inizio della tua fase principale prima del combattimento, puoi aggiungere alla tua riserva di mana fino a X mana di un qualsiasi colore, dove X è il numero di Isole controllate dall’avversario bersaglio.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[At the beginning of each of your main phases, if you haven’t added mana to your mana pool with this ability this turn, you may add up to X mana of any one color to your mana pool, where X is the number of Islands target opponent controls.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[At the beginning of each of your main phases, if you haven’t added mana to your mana pool with this ability this turn, you may add up to X mana of any one color to your mana pool, where X is the number of Islands target opponent controls.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[At the beginning of each of your main phases, if you haven’t added mana to your mana pool with this ability this turn, you may add up to X mana of any one color to your mana pool, where X is the number of Islands target opponent controls.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[At the beginning of each of your main phases, if you haven’t added mana to your mana pool with this ability this turn, you may add up to X mana of any one color to your mana pool, where X is the number of Islands target opponent controls.]]></LOCALISED_TEXT>
      <TRIGGER value="BEGINNING_OF_PLAYERS_STEP" simple_qualifier="controller">
         return MTG():GetStep() == STEP_MAIN_1 or MTG():GetStep() == STEP_MAIN_2
      </TRIGGER>
      <MAY />
      <TARGET tag="CARD_QUERY_CHOOSE_OPPONENT" definition="0" compartment="0" count="1" />
      <TARGET_DEFINITION id="0">
         local filter = ClearFilter()
         filter:SetFilterType( FILTER_TYPE_PLAYERS )
         filter:Add( FE_TEAM, OP_NOT, EffectController():GetTeam() )
      </TARGET_DEFINITION>
      <PLAY_TIME_ACTION>
         RSN_MarkManaAbilityStart()
         local oPlayer = EffectController()
         local oCard = EffectSource()
         if (oPlayer ~= nil) then
            oPlayer:BeginNewMultipleChoice()
               oPlayer:AddMultipleChoiceAnswer( "RSN_MODE_PRODUCE_W" )
               oPlayer:AddMultipleChoiceAnswer( "RSN_MODE_PRODUCE_U" )
               oPlayer:AddMultipleChoiceAnswer( "RSN_MODE_PRODUCE_B" )
               oPlayer:AddMultipleChoiceAnswer( "RSN_MODE_PRODUCE_R" )
               oPlayer:AddMultipleChoiceAnswer( "RSN_MODE_PRODUCE_G" )
            oPlayer:AskMultipleChoiceQuestion( "MODE_CHOOSE_ONE", oCard )
         end
      </PLAY_TIME_ACTION>
      <RESOLUTION_TIME_ACTION>
         local chosen_player = EffectDC():Get_Targets(0):Get_PlayerPtr(0)
         local filter = ClearFilter()
         filter:Add( FE_SUBTYPE, OP_IS, LAND_TYPE_ISLAND )
         filter:Add( FE_CONTROLLER, OP_IS, chosen_player)
         local total = filter:Count()
         local nColour = EffectController():GetMultipleChoiceResult() + 1
         if (nColour == COLOUR_BLACK) then
            RSN_Produce( "{B}", total )
         elseif (nColour == COLOUR_BLUE) then
            RSN_Produce( "{U}", total )
         elseif (nColour == COLOUR_GREEN) then
            RSN_Produce( "{G}", total )
         elseif (nColour == COLOUR_RED) then
            RSN_Produce( "{R}", total )
         elseif (nColour == COLOUR_WHITE) then
            RSN_Produce( "{W}", total )
         end
      </RESOLUTION_TIME_ACTION>
      <RESOLUTION_TIME_ACTION>
         RSN_EliminateExtraManaTokens()
         S_DisplayManaPool(EffectController())
      </RESOLUTION_TIME_ACTION>
   </TRIGGERED_ABILITY>
   <STATIC_ABILITY>
      <CONTINUOUS_ACTION layer="0">
         RSN_ClearCanProduceMana()
         RSN_MarkCanProduceMana( "{W}{U}{B}{R}{G}" )
      </CONTINUOUS_ACTION>
   </STATIC_ABILITY>
   <TRIGGERED_ABILITY forced_skip="1" replacement_effect="1">
      <TRIGGER value="BEGINNING_OF_STEP" pre_trigger="1" />
      <RESOLUTION_TIME_ACTION>
         RSN_ClearProducedMana()
      </RESOLUTION_TIME_ACTION>
   </TRIGGERED_ABILITY>
   <TOKEN_REGISTRATION reservation="1" type="RSN_TOKEN_MANA_W" />
   <TOKEN_REGISTRATION reservation="1" type="RSN_TOKEN_MANA_U" />
   <TOKEN_REGISTRATION reservation="1" type="RSN_TOKEN_MANA_B" />
   <TOKEN_REGISTRATION reservation="1" type="RSN_TOKEN_MANA_R" />
   <TOKEN_REGISTRATION reservation="1" type="RSN_TOKEN_MANA_G" />
   <AUTHOR><![CDATA[zhupiter]]></AUTHOR>
   <EDITORS><![CDATA[zhupiter]]></EDITORS>
   <DATE><![CDATA[13-9-15]]></DATE>
</CARD_V2>

I'm not sure if Diregraf Captain is working as intended. If it dies at the same time as a bunch of other zombies, it's ability doesn't trigger. I would've thought the ability should trigger as it was on the battlefield when they died.

Also, is it possible to get Cradle of Vitality triggering in the correct order (i.e. ask to spend mana first, then if 'yes' select target)?

Cheers

EDIT: The CW version of Emeria, the Sky Ruin (non-MM) seems to be MM.

nivmizzet1 wrote:I'm not sure if Diregraf Captain is working as intended. If it dies at the same time as a bunch of other zombies, it's ability doesn't trigger. I would've thought the ability should trigger as it was on the battlefield when they died.

Also, is it possible to get Cradle of Vitality triggering in the correct order (i.e. ask to spend mana first, then if 'yes' select target)?

Cheers

EDIT: The CW version of Emeria, the Sky Ruin (non-MM) seems to be MM.

Cradle of Vitality - Very first ruling says you choose the target, then choose whether or not you pay. It is already correct. This is true of all abilities like this. If an ability or effect has targets, those targets are chosen at play time (when the ability/spell is announced/triggered) when being put onto the stack. If it asks for other things, those things happen (generally speaking, but it applies to optionally paying mana) when it resolves off of the stack.

I use Emeria, the Sky Ruin in my Transenscion deck all the time and have never experienced this. The code (I just checked) for the mana ability is this:

Code: Select all

<MANA_ABILITY>
   <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[{T}: Add {W} to your mana pool.]]></LOCALISED_TEXT>
   <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[{T} : Ajoutez {W} à votre réserve.]]></LOCALISED_TEXT>
   <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[{T}: Agrega {W} a tu reserva de maná.]]></LOCALISED_TEXT>
   <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[{T}: Erhöhe deinen Manavorrat um {W}.]]></LOCALISED_TEXT>
   <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[{T}: Aggiungi {W} alla tua riserva di mana.]]></LOCALISED_TEXT>
   <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[{T}：あなたのマナ・プールに{W}を加える。]]></LOCALISED_TEXT>
   <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[{T}: Add {W} to your mana pool.]]></LOCALISED_TEXT>
   <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[{T}: Add {W} to your mana pool.]]></LOCALISED_TEXT>
   <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[{T}: Add {W} to your mana pool.]]></LOCALISED_TEXT>
   <PRODUCES amount="{W}" />
</MANA_ABILITY>

That is the vanilla mana ability, so either you used the MM by accident or something is interfering (though I have no idea what could cause that kind of issue). You probably already know this, but just in case you don't, you can enable the "File Name" column in the deck builder in the current deck pane (I don't know if it's shown by default) to see specifically which card you added.

Could you test if Dross Harvester works for you? Check if it gives you 2 life when it dies (preferably also checking if it gives you 2 life per creature when it and other creatures simultaneously die). They use the same basic trigger, so they should theoretically either both work or both not work. I'll check them both on my end as well when I get a chance.

zhupiter wrote:Carpet of Flowers .I don't know where the code goes wrong.It is triggered as normal at main phase 1 but is triggered twice at main phase 2.Here is the code

Code: Select all

<?xml version='1.0' encoding='UTF-8'?>
<CARD_V2 ExportVersion="1">
   <FILENAME text="CARPET_OF_FLOWERS_CW_5858" />
   <CARDNAME text="CARPET_OF_FLOWERS" />
   <TITLE>
      <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Carpet of Flowers]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Carpet of Flowers]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Carpet of Flowers]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Carpet of Flowers]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Carpet of Flowers]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[Carpet of Flowers]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Carpet of Flowers]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Carpet of Flowers]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Carpet of Flowers]]></LOCALISED_TEXT>
   </TITLE>
   <MULTIVERSEID value="5858" />
   <ARTID value="CW5858" />
   <ARTIST name="Rebecca Guay" />
   <CASTING_COST cost="{G}" />
   <TYPE metaname="Enchantment" />
   <EXPANSION value="UZ" />
   <RARITY metaname="U" />
   <TRIGGERED_ABILITY forced_skip="1">
      <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[At the beginning of each of your main phases, if you haven’t added mana to your mana pool with this ability this turn, you may add up to X mana of any one color to your mana pool, where X is the number of Islands target opponent controls.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[At the beginning of each of your main phases, if you haven’t added mana to your mana pool with this ability this turn, you may add up to X mana of any one color to your mana pool, where X is the number of Islands target opponent controls.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[At the beginning of each of your main phases, if you haven’t added mana to your mana pool with this ability this turn, you may add up to X mana of any one color to your mana pool, where X is the number of Islands target opponent controls.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[At the beginning of each of your main phases, if you haven’t added mana to your mana pool with this ability this turn, you may add up to X mana of any one color to your mana pool, where X is the number of Islands target opponent controls.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[All’inizio della tua fase principale prima del combattimento, puoi aggiungere alla tua riserva di mana fino a X mana di un qualsiasi colore, dove X è il numero di Isole controllate dall’avversario bersaglio.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[At the beginning of each of your main phases, if you haven’t added mana to your mana pool with this ability this turn, you may add up to X mana of any one color to your mana pool, where X is the number of Islands target opponent controls.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[At the beginning of each of your main phases, if you haven’t added mana to your mana pool with this ability this turn, you may add up to X mana of any one color to your mana pool, where X is the number of Islands target opponent controls.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[At the beginning of each of your main phases, if you haven’t added mana to your mana pool with this ability this turn, you may add up to X mana of any one color to your mana pool, where X is the number of Islands target opponent controls.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[At the beginning of each of your main phases, if you haven’t added mana to your mana pool with this ability this turn, you may add up to X mana of any one color to your mana pool, where X is the number of Islands target opponent controls.]]></LOCALISED_TEXT>
      <TRIGGER value="BEGINNING_OF_PLAYERS_STEP" simple_qualifier="controller">
         return MTG():GetStep() == STEP_MAIN_1 or MTG():GetStep() == STEP_MAIN_2
      </TRIGGER>
      <MAY />
      <TARGET tag="CARD_QUERY_CHOOSE_OPPONENT" definition="0" compartment="0" count="1" />
      <TARGET_DEFINITION id="0">
         local filter = ClearFilter()
         filter:SetFilterType( FILTER_TYPE_PLAYERS )
         filter:Add( FE_TEAM, OP_NOT, EffectController():GetTeam() )
      </TARGET_DEFINITION>
      <PLAY_TIME_ACTION>
         RSN_MarkManaAbilityStart()
         local oPlayer = EffectController()
         local oCard = EffectSource()
         if (oPlayer ~= nil) then
            oPlayer:BeginNewMultipleChoice()
               oPlayer:AddMultipleChoiceAnswer( "RSN_MODE_PRODUCE_W" )
               oPlayer:AddMultipleChoiceAnswer( "RSN_MODE_PRODUCE_U" )
               oPlayer:AddMultipleChoiceAnswer( "RSN_MODE_PRODUCE_B" )
               oPlayer:AddMultipleChoiceAnswer( "RSN_MODE_PRODUCE_R" )
               oPlayer:AddMultipleChoiceAnswer( "RSN_MODE_PRODUCE_G" )
            oPlayer:AskMultipleChoiceQuestion( "MODE_CHOOSE_ONE", oCard )
         end
      </PLAY_TIME_ACTION>
      <RESOLUTION_TIME_ACTION>
         local chosen_player = EffectDC():Get_Targets(0):Get_PlayerPtr(0)
         local filter = ClearFilter()
         filter:Add( FE_SUBTYPE, OP_IS, LAND_TYPE_ISLAND )
         filter:Add( FE_CONTROLLER, OP_IS, chosen_player)
         local total = filter:Count()
         local nColour = EffectController():GetMultipleChoiceResult() + 1
         if (nColour == COLOUR_BLACK) then
            RSN_Produce( "{B}", total )
         elseif (nColour == COLOUR_BLUE) then
            RSN_Produce( "{U}", total )
         elseif (nColour == COLOUR_GREEN) then
            RSN_Produce( "{G}", total )
         elseif (nColour == COLOUR_RED) then
            RSN_Produce( "{R}", total )
         elseif (nColour == COLOUR_WHITE) then
            RSN_Produce( "{W}", total )
         end
      </RESOLUTION_TIME_ACTION>
      <RESOLUTION_TIME_ACTION>
         RSN_EliminateExtraManaTokens()
         S_DisplayManaPool(EffectController())
      </RESOLUTION_TIME_ACTION>
   </TRIGGERED_ABILITY>
   <STATIC_ABILITY>
      <CONTINUOUS_ACTION layer="0">
         RSN_ClearCanProduceMana()
         RSN_MarkCanProduceMana( "{W}{U}{B}{R}{G}" )
      </CONTINUOUS_ACTION>
   </STATIC_ABILITY>
   <TRIGGERED_ABILITY forced_skip="1" replacement_effect="1">
      <TRIGGER value="BEGINNING_OF_STEP" pre_trigger="1" />
      <RESOLUTION_TIME_ACTION>
         RSN_ClearProducedMana()
      </RESOLUTION_TIME_ACTION>
   </TRIGGERED_ABILITY>
   <TOKEN_REGISTRATION reservation="1" type="RSN_TOKEN_MANA_W" />
   <TOKEN_REGISTRATION reservation="1" type="RSN_TOKEN_MANA_U" />
   <TOKEN_REGISTRATION reservation="1" type="RSN_TOKEN_MANA_B" />
   <TOKEN_REGISTRATION reservation="1" type="RSN_TOKEN_MANA_R" />
   <TOKEN_REGISTRATION reservation="1" type="RSN_TOKEN_MANA_G" />
   <AUTHOR><![CDATA[zhupiter]]></AUTHOR>
   <EDITORS><![CDATA[zhupiter]]></EDITORS>
   <DATE><![CDATA[13-9-15]]></DATE>
</CARD_V2>

I'm not sure why that would happen. It appears to use the same trigger Tejahn used for Frontier Siege and that card works (I've used it recently multiple times).

Code: Select all

<TRIGGER value="BEGINNING_OF_PLAYERS_STEP" simple_qualifier="controller">
   return MTG():GetStep() == STEP_MAIN_1 or MTG():GetStep() == STEP_MAIN_2
</TRIGGER>

Xander9009 wrote:Cradle of Vitality - Very first ruling says you choose the target, then choose whether or not you pay. It is already correct. This is true of all abilities like this. If an ability or effect has targets, those targets are chosen at play time (when the ability/spell is announced/triggered) when being put onto the stack. If it asks for other things, those things happen (generally speaking, but it applies to optionally paying mana) when it resolves off of the stack.

doh! maybe I should read the rules. In my defence, the wording is pretty misleading (blaming wizards); there's even a full-stop between choosing to pay and then doing the effect.

Xander9009 wrote:I use Emeria, the Sky Ruin in my Transenscion deck all the time and have never experienced this. The code (I just checked) for the mana ability is this:

Code: Select all

<MANA_ABILITY>
   <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[{T}: Add {W} to your mana pool.]]></LOCALISED_TEXT>
   <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[{T} : Ajoutez {W} à votre réserve.]]></LOCALISED_TEXT>
   <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[{T}: Agrega {W} a tu reserva de maná.]]></LOCALISED_TEXT>
   <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[{T}: Erhöhe deinen Manavorrat um {W}.]]></LOCALISED_TEXT>
   <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[{T}: Aggiungi {W} alla tua riserva di mana.]]></LOCALISED_TEXT>
   <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[{T}：あなたのマナ・プールに{W}を加える。]]></LOCALISED_TEXT>
   <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[{T}: Add {W} to your mana pool.]]></LOCALISED_TEXT>
   <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[{T}: Add {W} to your mana pool.]]></LOCALISED_TEXT>
   <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[{T}: Add {W} to your mana pool.]]></LOCALISED_TEXT>
   <PRODUCES amount="{W}" />
</MANA_ABILITY>

That is the vanilla mana ability, so either you used the MM by accident or something is interfering (though I have no idea what could cause that kind of issue). You probably already know this, but just in case you don't, you can enable the "File Name" column in the deck builder in the current deck pane (I don't know if it's shown by default) to see specifically which card you added.

I use it in a couple of decks as well, and never had this issue before. Before I posted this I did check the card in the deck editor to make sure (I was actually going to change the card over) but it said it was the non-MM version. It *is* possible however, that I have a different (older) version of the deck in the game folder and just never exported the one I have saved in the deck editor. Sorry for wasting your time.

EDIT: and there it is...

Code: Select all

  <CARD name="EMERIA_THE_SKY_RUIN_MM_CW_389503" deckOrderId="8" />
  <CARD name="EMERIA_THE_SKY_RUIN_MM_CW_389503" deckOrderId="9" />

This time I have a real problem, hurruh!

The CW version of Knight of the White Orchid is putting the plains into your hand, not onto the battlefield!

the text confirming it should be put onto the battlefield

Code: Select all

    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[When Knight of the White Orchid enters the battlefield, if an opponent controls more lands than you, you may search your library for a Plains card, put it onto the battlefield, then shuffle your library.]]></LOCALISED_TEXT>

here is the culprit

Code: Select all

      <RESOLUTION_TIME_ACTION>
         if EffectDC():Get_Int(1) &lt; EffectDC():Get_Int(0) then
            local filter = ClearFilter()
            filter:SetZone(ZONE_LIBRARY, EffectController())
            filter:Add(FE_SUBTYPE, OP_IS, LAND_TYPE_PLAINS)
            EffectController():ChooseItem("CARD_QUERY_CHOOSE_LAND_TO_PUT_INTO_HAND", EffectDC():Make_Targets(2), QUERY_FLAG_UP_TO )
         end
    </RESOLUTION_TIME_ACTION>
      <RESOLUTION_TIME_ACTION>
         local Target = EffectDC():Get_Targets(2) and EffectDC():Get_Targets(2):Get_CardPtr(0)
         if Target ~= nil then
            Target:GuidedReveal(Target:GetZone(), ZONE_HAND)
         end
    </RESOLUTION_TIME_ACTION>
      <RESOLUTION_TIME_ACTION>
         local Target = EffectDC():Get_Targets(2) and EffectDC():Get_Targets(2):Get_CardPtr(0)
         if Target ~= nil then
            Target:PutInHand()
         end
    </RESOLUTION_TIME_ACTION>

I'll try to fix this; it shouldn't be too hard. If I fail I'll report back here.


EDIT: okay, I had a try but it's not working. I don't know why. Here's my attempt at re-jigging the code.

Code: Select all

  <TRIGGERED_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[When Knight of the White Orchid enters the battlefield, if an opponent controls more lands than you, you may search your library for a Plains card, put it onto the battlefield, then shuffle your library.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Quand le Chevalier de l’Orchidée blanche arrive en jeu, si un adversaire contrôle plus de terrains que vous, vous pouvez chercher dans votre bibliothèque une carte de plaine, la mettre en jeu et mélanger ensuite votre bibliothèque.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Cuando el Caballero de la Orquídea Blanca entre en juego, si un oponente controla más tierras que tú, puedes buscar en tu biblioteca una carta de llanura, ponerla en juego y luego barajar tu biblioteca.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Wenn der Ritter der weißen Orchidee ins Spiel kommt und falls ein Gegner mehr Länder kontrolliert als du, kannst du deine Bibliothek nach einer Ebenen-Karte durchsuchen, sie ins Spiel bringen und dann deine Bibliothek mischen.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Quando il Cavaliere dell’Orchidea Bianca entra in gioco, se un avversario controlla più terre di te, puoi passare in rassegna il tuo grimorio per una carta Pianura, metterla in gioco, poi rimescolare il tuo grimorio.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[白蘭の騎士が場に出たとき、いずれかの対戦相手があなたよりも多くの土地をコントロールしている場合、あなたは自分のライブラリーから平地カードを１枚探してもよい。そうしたならそれを場に出し、その後あなたのライブラリーを切り直す。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[When Knight of the White Orchid enters the battlefield, if an opponent controls more lands than you, you may search your library for a Plains card, put it onto the battlefield, then shuffle your library.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Когда Рыцарь Белой Орхидеи входит в игру, если под контролем оппонента больше земель, чем под вашим контролем, вы можете найти в вашей библиотеке карту Равнины, положить ее в игру, затем перетасовать вашу библиотеку.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Quando Cavaleiro da Orquídea Branca entrar em jogo, se um oponente controlar mais terrenos que você, você poderá procurar em seu grimório por um card de Planície, colocá-lo em jogo e depois embaralhar seu grimório.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-CN"><![CDATA[当白兰骑士进场时，若任一对手操控的地比你多，则你可以从你牌库中搜寻一张平原牌，将其放置进场，然后将你的牌库洗牌。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-HK"><![CDATA[When Knight of the White Orchid enters the battlefield, if an opponent controls more lands than you, you may search your library for a Plains card, put it onto the battlefield, then shuffle your library.]]></LOCALISED_TEXT>
    <TRIGGER value="ZONECHANGE_END" simple_qualifier="self" to_zone="ZONE_BATTLEFIELD" />
      <RESOLUTION_TIME_ACTION>
         local filter = ClearFilter()
         filter:Add(FE_CONTROLLER, OP_IS, EffectController())
         filter:Add(FE_TYPE, OP_IS, CARD_TYPE_LAND)
         EffectDC():Set_Int(1, filter:Count())
    </RESOLUTION_TIME_ACTION>
      <RESOLUTION_TIME_ACTION repeating="1">
         local n = MTG():GetActionRepCount()               
         local NumPlayers = MTG():GetNumberOfPlayers()
         local MostLands = 0
         if n &lt; NumPlayers then
            local Player = MTG():GetNthPlayer(n)
            if Player:GetTeam() ~= EffectController():GetTeam() then
               local filter = ClearFilter()
               filter:Add(FE_TYPE, OP_IS, CARD_TYPE_LAND)
               filter:Add(FE_CONTROLLER, OP_IS, Player)
               local LandCount = filter:Count()
               if LandCount &gt; MostLands then
                  MostLands = LandCount
                  EffectDC():Set_Int(0, MostLands)
               end
            end
            return true
         end
         return false
    </RESOLUTION_TIME_ACTION>

      <RESOLUTION_TIME_ACTION>
         if EffectDC():Get_Int(1) &lt; EffectDC():Get_Int(0) then
            local filter = ClearFilter()
            filter:SetZone(ZONE_LIBRARY, EffectController())
            filter:Add(FE_SUBTYPE, OP_IS, LAND_TYPE_PLAINS)
         EffectController():ChooseItem( "CARD_QUERY_CHOOSE_LAND_TO_PUT_ONTO_THE_BATTLEFIELD", EffectDC():Make_Targets(2), QUERY_FLAG_UP_TO )
         end
         </RESOLUTION_TIME_ACTION>
      <RESOLUTION_TIME_ACTION>
         local Target = EffectDC():Get_Targets(2) and EffectDC():Get_Targets(2):Get_CardPtr(0)
         if  target ~= nil then
            target:PutOntoBattlefield( EffectController() )
         end
      </RESOLUTION_TIME_ACTION>
      <RESOLUTION_TIME_ACTION>
         if EffectDC():Get_Int(1) &lt; EffectDC():Get_Int(0) then
            EffectController():ShuffleLibrary()
         end
    </RESOLUTION_TIME_ACTION>

      <MAY />
  </TRIGGERED_ABILITY>

EDIT: what's wrong with the version in the base game?

I wasn't even aware that card was in the base game. Either way, your problem was the capitalization of Target and target. Lua is case sensitive.

Code: Select all

<RESOLUTION_TIME_ACTION>
   local Target = EffectDC():Get_Targets(2) and EffectDC():Get_Targets(2):Get_CardPtr(0)
   if  target ~= nil then
      target:PutOntoBattlefield( EffectController() )
   end
</RESOLUTION_TIME_ACTION>

Fixed.

Xander9009 wrote:I wasn't even aware that card was in the base game. Either way, your problem was the capitalization of Target and target. Lua is case sensitive.

Code: Select all

<RESOLUTION_TIME_ACTION>
   local Target = EffectDC():Get_Targets(2) and EffectDC():Get_Targets(2):Get_CardPtr(0)
   if  target ~= nil then
      target:PutOntoBattlefield( EffectController() )
   end
</RESOLUTION_TIME_ACTION>

Fixed.

So does that mean you've fixed the card and put it in the WAD, and the code you posted above is the incorrect code for me to see the inconsistency in capitalisation?

That's exactly what it means. I just posted that code (a direct copy/paste from your post) so you knew exactly where I was referring to with the capitalization talk. The card in the CW should be fixed.

Xander9009 wrote:I'm not sure why that would happen. It appears to use the same trigger Tejahn used for Frontier Siege and that card works (I've used it recently multiple times).

Code: Select all

<TRIGGER value="BEGINNING_OF_PLAYERS_STEP" simple_qualifier="controller">
   return MTG():GetStep() == STEP_MAIN_1 or MTG():GetStep() == STEP_MAIN_2
</TRIGGER>

I find that if I have creatures on the battlefield,it works as normal.Frontier Siege has the same problem for me.Perhaps it's the problem on my side.
By the way,must I delete the old file when I modify cards?It costs too much time searching them

You should search them out and delete them (if you have it synced to your computer, this is very easy). However, I made an alternative awhile back.

https://drive.google.com/open?id=0B-cZn ... m8xd1NzaEU

Upload them to that folder and they'll automatically be moved to the correct folder (this works for art or cards), overwriting older cards when necessary. (Art will only overwrite. It will never be moved unless it already exists in some art wad, because without it already existing in an art wad, then it doesn't know which folder to put it in.)

Hey Xander, did you just not do artwork for the Origins cards? Or are the artworks not referenced properly in the cards? All of the Origins cards come up as black artwork. I for sure downloaded the Origins artwork pack multiple times hoping it would be fixed. I've just been taking the cards and finding artwork for them on my own, but that's sort of a hassle I don't want to go through anymore. Also, all the custom Planeswalkers card display oddly in game, I think they're supposed to stretch out, but on my end, the image just stays constrained in the usual artwork box.

http://pasteboard.co/KcoNChe.png

Also, I've done a few Battle for Zendikar cards, but you've probably already got the ones I did handled. Here's the few I did that I'd happily submit to you if you want them.

Ulamog, the Ceaseless Hunger
Retreat to Kazandu
Barrage Tyrant
Retreat to Emeria
Skitterskin
Rolling Thunder
Omnath, Locus of Rage
Lantern Scout
Incubator Drone
Drowner of Hope
Brood Butcher
Breaker of Armies
Defiant Bloodlord
Felidar Cub
Gideon's Reproach
Oran-Rief Hydra
Dominator Drone
Forerunner of Slaughter
Kozilek's Channeler
Hedron Archive
Mist Intruder
Hero of Goma Fada
Veteran Warleader
Eldrazi Devestator

For the artwork, I suspect you downloaded the art wad with ORIGINS in the name. See this post: viewtopic.php?f=109&t=15783&p=183718&hilit=origins+art#p183718

I haven't renamed the wad, and probably won't end up doing that, but I might. The art wad you need is the 2015-2018 core art wad.

EDIT: I forgot to address the cards - I haven't coded any BFZ cards, so everyone would appreciate any you add to the CW. However, they can't be added to the CW until we know the MultiverseID (otherwise, all of the MultiverseIDs will be messed up until we can correct them when they're finally known, but then there will be decks using those messed up cards' filenames so changing the names would be difficult and frustrating). If you're eager to get them added, I'd leave the MultiverseID out of the filename altogether for now.

And a note to anyone who uses any BFZ cards before they're available on Gatherer: these cards' filenames WILL change. Your decks WILL become broken later on down the road and will need fixed. Fair warning.

I think my Diregraf Captain query was overlooked (it was actually the main query in my post with the two non-issues that were addressed; I'm not annoyed, it's just ironic).

I'm not sure if Diregraf Captain is working as intended. If it dies at the same time as a bunch of other zombies, it's ability doesn't trigger. I would've thought the ability should trigger as it was on the battlefield when they died.

I'm pretty sure there are plenty of other things with abilities like that that do trigger (e.g. Blood Artist).

Xander9009 wrote:For the artwork, I suspect you downloaded the art wad with ORIGINS in the name. See this post: viewtopic.php?f=109&t=15783&p=183718&hilit=origins+art#p183718

I haven't renamed the wad, and probably won't end up doing that, but I might. The art wad you need is the 2015-2018 core art wad.

EDIT: I forgot to address the cards - I haven't coded any BFZ cards, so everyone would appreciate any you add to the CW. However, they can't be added to the CW until we know the MultiverseID (otherwise, all of the MultiverseIDs will be messed up until we can correct them when they're finally known, but then there will be decks using those messed up cards' filenames so changing the names would be difficult and frustrating). If you're eager to get them added, I'd leave the MultiverseID out of the filename altogether for now.

And a note to anyone who uses any BFZ cards before they're available on Gatherer: these cards' filenames WILL change. Your decks WILL become broken later on down the road and will need fixed. Fair warning.

I can send the cards whenever, it's your call. These will probably be the only cards I do for the Battle of Zendikar set, unless nobody else has been working on them in which case, I'll try to get as much done as I can.

Manifest seems not to work again. Mastery of the Unseen , Whisperwood Elemental can't manifest your top card of your library.