Collectible Card Game Headquarters

tmxk2012917 wrote:A bug of Spark Elemental:

it was sacrificed at the next beginning step instead of the end step

Fixed. I also removed the erroneous check to make sure it's the creature's controller's turn.

tmxk2012917 wrote:A bug of Transmute Artifact:

When I cast it, I was not asked to sacrifice an artifact so that I could not search my library for an artiact

Should be fixed. I altered it a fair amount before finally noticing the reason (it said "RESOLUTION_ACTION" instead of "RESOLUTION_TIME_ACTION"), so it needs tested.

Thanks for the input Xander. I've made all those corrections and will test the cards again on Thursday when I am back coding. Don't worry about that test card's logic. I was only using it to test the reveal function; I won't be using it after we get that working.

Nevermind about that last post. I didn't notice the word "land".

it's probaly a limitation of the game, but Brimaz, King of Oreskos doesn't let you order damage, which means you can't deal damage to the token before Brimaz. Unless there's some rule I'm not aware of that should prevent that.

While I haven't seen it in action, I suspect you're right about it being a limitation of the game engine.

I like combo decks using Worldgorger Dragon and Animate Dead (or Dance of the Dead). However, there are bugs in Animate Dead and Dance of the Dead. When Animate Dead returns from the exiled zone to the battlefield by Worldgorger Dragon combo, it tries to attach to battlefield permanents rather than to a creature card in a graveyard (however there are only opponent's permanents in the battlefield.),so that I could not return Worldgorger Dragon to the battlefield again.

I could not pay mana for awaken even though I had enough mana fulfilling the requirement

Finished coding for today; all cards referenced are from the missing cards list.

Coded, tested, and uploaded:
Delaying Shield
Elvish Soultiller
Endemic Plague
Erithizon
Erosion
Errant Minion
Essence Bottle
Essence Leak
Essence Vortex
Eye of Doom
Ezuri's Predation
Faith's Shield
Farrelite Priest
Fathom Trawl
Favor of the Mighty
Feast of Worms
Festival
Fight or Flight
Forgotten Lore
Fyndhorn Druid
Giant Albatross -- coded by thefiremind; tested by me
Goblin Spymaster
Spitting Slug

Bugs fixed:
Disruption Aura -- typo

Open Items:

-- CW_CARD_QUERY_SPLINTERVERSE has been updated and uploaded.

-- Something odd is going on with ELEMENTAL_C_7_1_R_HT. I have coded Elemental Appeal and it "appears" to create the token, but the token can't be seen on screen. Debug shows that the token was created in the designated chest and cards that trigger when a creature enters trigger on the token, but you can't see it at all.

-- Fire Covenant http://pastebin.com/MUeyjLJa I can't access the life from the utility ability in the spell ability.

-- Giant Oyster http://pastebin.com/aUTwde90 it's still not applying the -1/-1 counters. It's giving this error, but I don't see what is wrong with the duration: "[lua] [string "GIANT_OYSTER_CW_108816_TITLE (DURATION)~0x000007c0"]:2: attempt to index a nil value"

-- Telekinesis http://pastebin.com/iSTdM6H3 The tapped creature needs to stay tapped for TWO of it's controller's turns. It's only staying tapped for one.

-- Falling Timber http://pastebin.com/MN02uh9Z It doesn't apply the effect to the second creature. It's giving an error on the line 83 saying there is a nil value. I think it is EffectSource():WasKicked(). For some reason, it is not registering as being kicked. I've tried the old Kicker code (without the trigger); I've tried combining the targets using count="2"; etc. but no luck.

-- Any luck fixing the CW_General_RevealDC function?

Next:

Back tomorrow to continue coding missing cards.

Splinterverse wrote:-- Something odd is going on with ELEMENTAL_C_7_1_R_HT. I have coded Elemental Appeal and it "appears" to create the token, but the token can't be seen on screen.

The only idea I have is that the token's author may have forgot to give it the Creature type: if it has no types, it's invisible just like the managers.

Splinterverse wrote:-- Fire Covenant http://pastebin.com/MUeyjLJa

Everything seems fine to me, and EffectController should be accessible from costs, even in PREREQUISITE blocks (which are very restricted in what they can access).
Can you try to use a normal life cost with the amount set to "*" (instead of the generic one) and then read it from the spell ability through GetEffectX()? Like this:

Code: Select all

<COST type="Life" amount="*" />

I don't know if it works, but it's worth trying.

Splinterverse wrote:-- Giant Oyster http://pastebin.com/aUTwde90

You can start by not making the game complain about the duration, like this:

Code: Select all

<DURATION>
return EffectSource() == nil or EffectSource():IsTapped() == false
</DURATION>

There's also another thing you should do: in the second delayed trigger you are using simple_qualifier="self", but that's the same as using EffectSource, which isn't guaranteed to work in delayed triggers as you already know. Save EffectSource in the delayDC and use that in both trigger conditions of the second delayed trigger.

Splinterverse wrote:-- Telekinesis http://pastebin.com/iSTdM6H3

You coded it exactly as I would have, so it seems fine to me. Could it be that in DotP2014 the beginning of the untap step was fired before the untap happens? Try to make the delayed trigger fire on STEP_DRAW instead of STEP_UNTAP and see what happens.

Splinterverse wrote:-- Falling Timber http://pastebin.com/MN02uh9Z

I know the problem here. EffectSource is available as long as the spell is on the stack, but as soon as it hits the graveyard, EffectSource is wiped and the condition inside your second continuous action fails to evaluate. Try calling EffectSourceLKI():WasKicked() instead.

You won't need to do this for Falling Timber if EffectSourceLKI works, but here's something I took the time to search for: since there's no Set_Bool for generic data chests, if we ever need to save a boolean as an integer, the shortest way to do it is the following:

Code: Select all

EffectDC():Set_Int(0, the_boolean_var and 1 or 0)

"true and 1 or 0" will return 1, while "false and 1 or 0" will return 0, so it works as a conversion from boolean to number.

Splinterverse wrote:-- Any luck fixing the CW_General_RevealDC function?

I'm looking at the code you posted here and I can't see anything wrong (you return true for no reason, but Xander9009 already pointed that out and it shouldn't harm the function anyway). What's the problem exactly? I can only think of one possibility: maybe the game refuses to show the choice because you unselected all the pointers so there's nothing to choose? Try to comment out (--) the part where you unselect, and see what happens.

thefiremind wrote:

Splinterverse wrote:-- Any luck fixing the CW_General_RevealDC function?

I'm looking at the code you posted here and I can't see anything wrong (you return true for no reason, but Xander9009 already pointed that out and it shouldn't harm the function anyway). What's the problem exactly? I can only think of one possibility: maybe the game refuses to show the choice because you unselected all the pointers so there's nothing to choose? Try to comment out (--) the part where you unselect, and see what happens.

I changed the function to the following (to include properly optional parameters, rename variables to include type prefixes, and provide an error message if it has invalid parameters). But I messed up on line 19 by putting "oPlayer ~= oPlayer" instead of "oNthPlayer ~= oPlayer". It's been corrected and should work in the next update.

Code: Select all

--Reveals cards in a DC to each player, but omits the {oPlayer} if provided. {iReviewDCRegister} is used for a temporary DC.
--Input: Chest{, Player, Int}
--Output: None
CW_General_RevealDC = function(oRevealDC, oPlayer, iReviewDCRegister)
   if oPlayer == nil then
      oPlayer = EffectController()
   end
   if iReviewDCRegister == nil then
      iReviewDCRegister = 900
   end
   if oPlayer ~= nil and oRevealDC ~= nil and type(iReviewDCRegister) == "number" then
      local oReviewDC = EffectDC():Make_Chest(iReviewDCRegister)
      local iCount = oRevealDC:Count()
      for i=0, iCount-1 do
         oRevealDC:QueryUnselect_CardPtr(i)
      end
      for i=0,MTG():GetNumberOfPlayers()-1 do
         local oNthPlayer = MTG():GetNthPlayer(i)
         if oNthPlayer ~= nil and oPlayer ~= oPlayer then
            oNthPlayer:ChooseItemFromDC("SPL_CARD_QUERY_CHOOSE_A_CARD_TO_EXIT_THIS_VIEW", oRevealDC, oReviewDC, QUERY_FLAG_MAY)
         end
      end
   else
      CW_General_Error("CW_General_RevealDC: Invalid parameters.")
   end
end

thefiremind wrote:

Splinterverse wrote:-- Something odd is going on with ELEMENTAL_C_7_1_R_HT. I have coded Elemental Appeal and it "appears" to create the token, but the token can't be seen on screen.

The only idea I have is that the token's author may have forgot to give it the Creature type: if it has no types, it's invisible just like the managers.

I'm not sure where to look for that, but I think Xander will probably respond on this one later.

thefiremind wrote:

Splinterverse wrote:-- Fire Covenant http://pastebin.com/MUeyjLJa

Everything seems fine to me, and EffectController should be accessible from costs, even in PREREQUISITE blocks (which are very restricted in what they can access).
Can you try to use a normal life cost with the amount set to "*" (instead of the generic one) and then read it from the spell ability through GetEffectX()? Like this:

Code: Select all

<COST type="Life" amount="*" />

I don't know if it works, but it's worth trying.

Made this change. Will test today.

thefiremind wrote:

Splinterverse wrote:-- Giant Oyster http://pastebin.com/aUTwde90

You can start by not making the game complain about the duration, like this:

Code: Select all

<DURATION>
return EffectSource() == nil or EffectSource():IsTapped() == false
</DURATION>

There's also another thing you should do: in the second delayed trigger you are using simple_qualifier="self", but that's the same as using EffectSource, which isn't guaranteed to work in delayed triggers as you already know. Save EffectSource in the delayDC and use that in both trigger conditions of the second delayed trigger.

Made these changes. Will test them today.

thefiremind wrote:

Splinterverse wrote:-- Telekinesis http://pastebin.com/iSTdM6H3

You coded it exactly as I would have, so it seems fine to me. Could it be that in DotP2014 the beginning of the untap step was fired before the untap happens? Try to make the delayed trigger fire on STEP_DRAW instead of STEP_UNTAP and see what happens.

Done. Will test.

thefiremind wrote:

Splinterverse wrote:-- Falling Timber http://pastebin.com/MN02uh9Z

I know the problem here. EffectSource is available as long as the spell is on the stack, but as soon as it hits the graveyard, EffectSource is wiped and the condition inside your second continuous action fails to evaluate. Try calling EffectSourceLKI():WasKicked() instead.

You won't need to do this for Falling Timber if EffectSourceLKI works, but here's something I took the time to search for: since there's no Set_Bool for generic data chests, if we ever need to save a boolean as an integer, the shortest way to do it is the following:

Code: Select all

EffectDC():Set_Int(0, the_boolean_var and 1 or 0)

"true and 1 or 0" will return 1, while "false and 1 or 0" will return 0, so it works as a conversion from boolean to number.

I think I did try the LKI version, but I will try it again. Not sure what you mean in the code example. Would the code actually contain the boolean variable followed by "and 1 or 0" or are you saying convert what's in the the_boolean_var to 1 or 0?

Thanks for the all input. Much appreciated!

Splinterverse wrote:I think I did try the LKI version, but I will try it again. Not sure what you mean in the code example. Would the code actually contain the boolean variable followed by "and 1 or 0" or are you saying convert what's in the the_boolean_var to 1 or 0?

If EffectSourceLKI doesn't work either, then I'll adapt the example to this card: you can add a RESOLUTION_TIME_ACTION where you save the boolean returned by WasKicked() in an EffectDC register. Since there's no Set_Bool for generic data chests, you'll save it as a number, by doing this:

Code: Select all

<RESOLUTION_TIME_ACTION>
EffectDC():Set_Int( 0, EffectSource():WasKicked() and 1 or 0 )
</RESOLUTION_TIME_ACTION>

After this, you can check

Code: Select all

EffectDC():Get_Int(0) == 1

in order to know if the card was kicked.

Finished coding for today; all cards referenced are from the missing cards list.

Coded, tested, and uploaded:
Chaoslace
Dawnbreak Reclaimer
Deadly Tempest
Death by Dragons
Death or Glory
Deathlace
Decomposition
Descendant of Masumaro
Desperate Research
Disorder
Dispersal Shield
Do or Die
Dragon Mask
Dread Summons
Dreams of the Dead
Dromar, the Banisher
Dwarven Armorer
Dwarven Armory
Dwarven Catapult
Dwarven Driller
Dwarven Scorcher
Dwarven Shrine
Elkin Lair
Elvish Healer
Endless Whispers
Energy Vortex
Falling Timber
Fire Covenant
Flash -- coded mostly by Xander9009
Shrouded Lore
Telekinesis

Bugs fixed:
Agadeem Occultist -- added logic to only allow for opponent creatures to be chosen (instead of any player who is not the controller)
Ashen Powder -- was using unnecessary allies logic from Agadeem Occultist; added logic to only allow for opponent creatures to be chosen (instead of any player who is not the controller)
Fight or Flight -- minor tweak to yesterday's upload
Forcemage Advocate -- added logic to only allow for opponent creatures to be chosen (instead of any player who is not the controller); tested
Lava Blister -- was not dealing damage to player (was losing life instead); tested
Lifelace -- typo

Open Items:

-- CW_CARD_QUERY_SPLINTERVERSE has been updated and uploaded.

-- The browser auto-upload gave me a few errors, so a couple files were uploaded repeatedly. They are all the same so feel free to ignore whichever copy you like.

-- Frankenstein's Monster http://pastebin.com/pFzwwMVM I have tried GetEffectX, GetPaidX and GetManaX . . . and all show 0 value with debug turned on. The rest of the card works as advertised, so I just need help to fix that issue and it will be good to go.

-- Divine Intervention http://pastebin.com/HF1E1zD1 The card says the game ends in a draw, but there is no draw function, and the implementation shown here results in a screen where one player is declared winner. Perhaps it's only approximate-able with game engine limitations?

-- Earthbind http://pastebin.com/DD4K9Pip The granted ability is not taking away flight from the enchanted creature. I've tried LKI and all sorts of ways to get the parent, but it has not worked. I know I could put the ability in the main card's code, but that really wouldn't be rules compliant, especially since another spell could cause the aura to be attached to a different target later.

-- Master of Cruelties http://pastebin.com/3n6yfKtj This current implementation is not preventing other creatures from joining the attack with Master of Cruelties. Perhaps I have implemented this attack test trigger incorrectly as I've never used it before.

-- Xander, something odd is going on with ELEMENTAL_C_7_1_R_HT. I have coded Elemental Appeal and it "appears" to create the token, but the token can't be seen on screen. Debug shows that the token was created in the designated chest and cards that trigger when a creature enters trigger on the token, but you can't see it at all. TheFireMind suggested that it might be missing its creature type?

Next:

Back tomorrow to implement any suggested fixes to the above and coding more missing cards.