Page 159 of 253

Re: Community Wad

PostPosted: 29 Nov 2016, 23:38
by migookman

Re: Community Wad

PostPosted: 30 Nov 2016, 05:23
by tmxk2012917
CW updated tonight, but only cards uploaded by migookman today are included.

Cards uploaded by Splinterverse on 26th and 27th are missing. I checked the auto upload File and found that those cards are still in the auto upload file. It seems that they were not successfully uploaded.

Besides, Kessig Prowler could not be transformed even though I paid mana for transformation.

Re: Community Wad

PostPosted: 30 Nov 2016, 17:22
by nivmizzet1
Halcyon Glaze doesn't interact properly with Mirrorweave. After Halcyon Glaze became a 4/4 creature I cast Mirrorweave on an Aquastrand Spider, but the Halcyon Glaze didn't go to the graveyard, instead it remained on the battlefield as a 4/4 creature (it didn't have any counters on it).

EDIT: but it wasn't the CW Halcyon Glaze. I'm not sure if there's a difference.

Re: Community Wad

PostPosted: 30 Nov 2016, 18:19
by Splinterverse
nivmizzet1 wrote:Halcyon Glaze doesn't interact properly with Mirrorweave. After Halcyon Glaze became a 4/4 creature I cast Mirrorweave on an Aquastrand Spider, but the Halcyon Glaze didn't go to the graveyard, instead it remained on the battlefield as a 4/4 creature (it didn't have any counters on it).

EDIT: but that wasn't the CW Halcyon Glaze. I'm not sure if there's a difference.
I'm not super familiar with these cards and I haven't looked at the rulings, but I wouldn't expect Halcyon Glaze to go to the graveyard in that scenario since it becomes a creature until the end of turn. I would expect it to become a copy of Aquastrand Spider.

I haven't looked at the code for those cards or read the rulings, so I could be wrong about how they should behave. My comment is based purely on reading the card popups here on the forum.

Re: Community Wad

PostPosted: 30 Nov 2016, 21:05
by Xander9009
Regarding the cards remaining in the Auto-Upload folder, that was Google Drive's fault. Restarted it and they synced properly.

For Halcyon Glaze+Mirrorweave+Aquastrand Spider, this is actually really tricky, but the interaction you experienced is correct. The layer system in MTG is a bit less the clear, but the important notes here are (you'll already know most of these since you've coded cards, but others reading might not):
1: There are different types of continuous actions. Each type takes place on a specific layer.
2: Each layer, from 1 up to 8 (sort of), runs in turn.
3: Within each layer, effects take place in the order they're created.
Copying effects take place on layer 1 and power/toughness setting effects take place on layer 7B. So, despite the Halcyon Glaze's ability being put in place first, it actually takes effect after the Mirrorweave's ability. The Halcyon Glaze sets its PT values on 7B. Mirrorweave then comes into effect copying 0/0 PT values on layer 1. Layer 1 runs, making its PT 0/0, layers 2 through 7A run (doing nothing relevant here), and then layer 7B runs, setting its PT to 4/4. So, despite being put into effect later, the Mirrorweave does not take precedence.

http://magic.wizards.com/en/articles/ar ... 2009-11-05
This is an official guide regarding the layer system, and very helpfully, it even has a section related specifically to Mirrorweave being cast after a creature is enchanted by Lignify. Lignify sets the PT the same way Halcyon Glaze sets its own PT. And then, despite the Mirroweave being cast later (usually meaning it would take precedence), the enchanted creature remains a 0/4 the same way Halcyon Glaze remains a 4/4.

Although, to be fair, just from reading the cards, I would definitely (and did, before erasing it when I considered the layer system) have said it should have died, so don't feel bad about not seeing what was going on.

Re: Community Wad

PostPosted: 30 Nov 2016, 21:17
by Splinterverse
Finished coding for today; all cards referenced are from the missing cards list.

Coded, tested, and uploaded:
Benediction of Moons
Cocoon
Crown-Hunter Hireling
Cry of Contrition
Eladamri
Ertai
Gaea's Liege
Gerrard
Orcish Librarian
Pack Hunt
Phosphorescent Feast
Puppet Master
Remove Enchantments
Seize the Soul
Sword of the Ages
Vigorous Charge

HQ art uploaded (all were missing):
Crovax
Eladamri
Ertai
Gerrard

Open Items:

-- CW_CARD_QUERY_SPLINTERVERSE has been updated and uploaded.

-- Terrifying Presence http://pastebin.com/iLNh5fhr Any idea why this isn't working? Totally fizzles.

-- Does "CanBlockAdditionalCreature()" work? It doesn't seem to be doing anything in the following code:
Code: Select all
<STATIC_ABILITY>
      <CONTINUOUS_ACTION layer="6">
         if EffectSource() ~= nil then
            local characteristics = EffectSource():GetCurrentCharacteristics()
            characteristics:CanBlockAdditionalCreature()
         end
      </CONTINUOUS_ACTION>
   </STATIC_ABILITY>

Re: Community Wad

PostPosted: 30 Nov 2016, 22:12
by thefiremind
The continuous action is missing its filter_id.

Splinterverse wrote:-- Does "CanBlockAdditionalCreature()" work?
I think I have never tried it. Try to use layer 8 for it; if it doesn't work either, then it's bugged for good.

Re: Community Wad

PostPosted: 30 Nov 2016, 22:15
by Xander9009
It's used on a few cards successfully. Try searching for it in the deck builder. Search cards with "hundred" in the name and "monsrrosity" in the text. (can't remember its exact name). Of course, that's only if you aren't familiar with searching the card text with advanced filters.

Re: Community Wad

PostPosted: 01 Dec 2016, 00:42
by migookman
There are quite a few using that characteristic. What I noticed during testing was that you can't block by sliding a character to another creature that you have to block but you have to click your creature and then click the creature you want to block. I had confusion about that before.

Re: Community Wad

PostPosted: 01 Dec 2016, 09:27
by thefiremind
Something I just recalled about Terrifying Presence: should it also affect creatures that came onto the battlefield after it was cast? I would say yes, but I'm not 100% sure. If the answer is yes, then the FILTER needs reevaluates="1".

This is relevant only if an additional combat phase is issued and the attacker puts a creature with haste onto the battlefield (quite a narrow scenario), but it should be taken into account anyway.

Re: Community Wad

PostPosted: 01 Dec 2016, 10:43
by Splinterverse
Thanks for the tips all. I will try these out tomorrow when I'm back online. Thanks!!!

Re: Community Wad

PostPosted: 01 Dec 2016, 14:10
by nivmizzet1
Xander9009 wrote:
| Open
Regarding the cards remaining in the Auto-Upload folder, that was Google Drive's fault. Restarted it and they synced properly.

For Halcyon Glaze+Mirrorweave+Aquastrand Spider, this is actually really tricky, but the interaction you experienced is correct. The layer system in MTG is a bit less the clear, but the important notes here are (you'll already know most of these since you've coded cards, but others reading might not):
1: There are different types of continuous actions. Each type takes place on a specific layer.
2: Each layer, from 1 up to 8 (sort of), runs in turn.
3: Within each layer, effects take place in the order they're created.
Copying effects take place on layer 1 and power/toughness setting effects take place on layer 7B. So, despite the Halcyon Glaze's ability being put in place first, it actually takes effect after the Mirrorweave's ability. The Halcyon Glaze sets its PT values on 7B. Mirrorweave then comes into effect copying 0/0 PT values on layer 1. Layer 1 runs, making its PT 0/0, layers 2 through 7A run (doing nothing relevant here), and then layer 7B runs, setting its PT to 4/4. So, despite being put into effect later, the Mirrorweave does not take precedence.

http://magic.wizards.com/en/articles/ar ... 2009-11-05
This is an official guide regarding the layer system, and very helpfully, it even has a section related specifically to Mirrorweave being cast after a creature is enchanted by Lignify. Lignify sets the PT the same way Halcyon Glaze sets its own PT. And then, despite the Mirroweave being cast later (usually meaning it would take precedence), the enchanted creature remains a 0/4 the same way Halcyon Glaze remains a 4/4.

Although, to be fair, just from reading the cards, I would definitely (and did, before erasing it when I considered the layer system) have said it should have died, so don't feel bad about not seeing what was going on.
Thanks for that great explanation Xander!

Re: Community Wad

PostPosted: 01 Dec 2016, 15:42
by Xander9009
thefiremind wrote:Something I just recalled about Terrifying Presence: should it also affect creatures that came onto the battlefield after it was cast? I would say yes, but I'm not 100% sure. If the answer is yes, then the FILTER needs reevaluates="1".

This is relevant only if an additional combat phase is issued and the attacker puts a creature with haste onto the battlefield (quite a narrow scenario), but it should be taken into account anyway.
I'm not sure if there are cards similar to Brimaz, King of Oreskos, but those (at the very least including Brimaz itself) would also cause issues.

Re: Community Wad

PostPosted: 01 Dec 2016, 16:11
by nivmizzet1
[lua] [string "ARCBOND_CW_391793_TITLE (RESOLUTION_TIME_ACTION)~0x000017aa"]:3: attempt to compare nil with number

Re: Community Wad

PostPosted: 01 Dec 2016, 17:34
by Xander9009
nivmizzet1 wrote:[lua] [string "ARCBOND_CW_391793_TITLE (RESOLUTION_TIME_ACTION)~0x000017aa"]:3: attempt to compare nil with number
This error should now be prevented from showing up. Hopefully it wasn't misbehaving in other ways.