Page 166 of 253

Re: Community Wad

PostPosted: 19 Dec 2016, 13:13
by erjerjerj
Bug report:
Nirkana Revenant mana doubling doesn't work.
In case Gauntlet of Power does work (didn't test it), maybe the same mechanism can be copied from it.
Can Extraplanar Lens be coded too?

Another request, can Choice of Damnations be coded, or is it impossible?

Thanks,
Eran

Re: Community Wad

PostPosted: 19 Dec 2016, 13:39
by Splinterverse2
erjerjerj wrote:Bug report:
Nirkana Revenant mana doubling doesn't work.
In case Gauntlet of Power does work (didn't test it), maybe the same mechanism can be copied from it.
Can Extraplanar Lens be coded too?

Another request, can Choice of Damnations be coded, or is it impossible?

Thanks,
Eran
I believe the "tapped for mana" effects only work with cards that are able to be manually tapped for mana. These cards are represented in the .Wad with MM in their name. The automatic tapping that occurs with most basic lands etc. won't trigger it.

Choice of Damnations is possible. If it's not already coded, I will add it to my to-do list meaning it will likely be available before the end of the year.

Re: Community Wad

PostPosted: 19 Dec 2016, 15:04
by migookman

Re: Community Wad

PostPosted: 19 Dec 2016, 18:00
by erjerjerj
Splinterverse2 wrote:
erjerjerj wrote:Bug report:
Nirkana Revenant mana doubling doesn't work.
In case Gauntlet of Power does work (didn't test it), maybe the same mechanism can be copied from it.
Can Extraplanar Lens be coded too?

Another request, can Choice of Damnations be coded, or is it impossible?

Thanks,
Eran
I believe the "tapped for mana" effects only work with cards that are able to be manually tapped for mana. These cards are represented in the .Wad with MM in their name. The automatic tapping that occurs with most basic lands etc. won't trigger it. :(

Choice of Damnations is possible. If it's not already coded, I will add it to my to-do list meaning it will likely be available before the end of the year.
Thanks for the Choice of Damnations

Re: Community Wad

PostPosted: 20 Dec 2016, 14:11
by tmxk2012917
Bug report:

Hedron Archive: I could use it to draw 2 cards even though I did not have enough manas to pay for it.

Guardian of the Great Conduit: When Nissa, Nature's Artisan entered the battleground, it got +2/+0 while Nissa got vigilance.


Art Uploaded:

Bow of the Hunter

Re: Community Wad

PostPosted: 21 Dec 2016, 00:42
by Xander9009
tmxk2012917 wrote:Bug report:

Hedron Archive: I could use it to draw 2 cards even though I did not have enough manas to pay for it.

Guardian of the Great Conduit: When Nissa, Nature's Artisan entered the battleground, it got +2/+0 while Nissa got vigilance.


Art Uploaded:

Bow of the Hunter
Fixed but untested.

Re: Community Wad

PostPosted: 21 Dec 2016, 10:38
by Splinterverse
Coded, tested, and uploaded:
Ballot Broker -- updated to use volrathxp's voting functions
Brago's Representative -- same as above

Bugs fixed:
Krovikan Horror -- removed an unnecessary comment from when I coded it
Snap -- was giving an error due to a tag in wrong location on a chooseitems block
Wormfang Drake -- was not sacrificing if there was no creature to exile

HQ art uploaded:
Enraged Revolutionary -- HQ upgrade
Rousing of Souls -- HQ upgrade
Selvala's Enforcer -- HQ upgrade
Split Decision -- HQ upgrade

Re: Community Wad

PostPosted: 21 Dec 2016, 10:55
by Splinterverse
Anyone know a good example of repeating/parity being used to iterate through a library? Or, does anyone have a good breakdown of how repeating/parity works . . . like a template? I get confused when I look at those blocks on what goes where and what things are pretty much constants.

Edit: I'd like to have a deeper understanding of the technique for all cards, but the example I cited is from Dichotomancy.

Re: Community Wad

PostPosted: 21 Dec 2016, 11:56
by RiiakShiNal
Splinterverse wrote:Anyone know a good example of repeating/parity being used to iterate through a library? Or, does anyone have a good breakdown of how repeating/parity works . . . like a template? I get confused when I look at those blocks on what goes where and what things are pretty much constants.

Edit: I'd like to have a deeper understanding of the technique for all cards, but the example I cited is from Dichotomancy.
Repeating actions are sort of like loops in that the block is executed again and again until you return false. It also has a loop counter that you can get by calling MTG():GetActionRepCount(). Parity is just an artificial construct that is used to separate the action into a pre-/post-phase (since certain commands will end an action and have to be checked afterwards, like asking the user a question, searching for a card, etc...). Parity is essentially doubling (or tripling) the number of iterations in the repeating action loop.

For example you need to ask all players to select a card. Since we can't ask all players at once we need to ask them one at a time and since each selection ends the action and we don't necessarily know before hand how many players are in the match we use a repeating action to ask the first player to select a card (iteration 0, parity 0), we store the first player's selection (iteration 1, parity 1), we ask the second player (iteration 2 parity 0), store the second player's choice (iteration 3 parity 1), up to the number of players in the match (n). Then on iteration 2*n (parity 0) we don't have a valid player pointer and we end the repeating action.

For Dichotomancy you would probably first evaluate a filter to capture what needs to be searched for store off that number then do 2 * that number of iterations through a repeating action to have the player search for each card and store those results in a separate chest, then as a final action loop through that chest and put all the valid card pointers into play.

Re: Community Wad

PostPosted: 21 Dec 2016, 22:39
by migookman

Re: Community Wad

PostPosted: 22 Dec 2016, 04:41
by Xander9009
I just started having my sync tool sync the packed version for the last few days and realized it had a small bug that I'd never notice with the unpacked sync option. If the wad is currently missing from the GD folder (because it was recently updated and is currently redownloading, perhaps), the tool thinks the folder is invalid since the wad is missing. I've just updated it to include a count for how many times it has tried to sync while the core or art were missing. Whenever it successfully finds the core or art, it resets the respective error count ini setting (so it persists through restarts). If the error count gets above 5 (change it by adding 'MaxErrorCount=5' to your ini with the number of times to ignore missing wads), then and only then will it ask you for your wad's GD location.

Re: Community Wad

PostPosted: 23 Dec 2016, 15:23
by Splinterverse
Bug Report: Sulfuric Vapors does not work.

Re: Community Wad

PostPosted: 23 Dec 2016, 15:34
by tmxk2012917
Bug Report:

Kessig Prowler/Sinuous Predator: I paid manas to transform Kessig Prowler, but it was not transformed

Re: Community Wad

PostPosted: 23 Dec 2016, 16:09
by Splinterverse
Coded, tested, and uploaded:
Benevolent Unicorn
Choice of Damnations
Daxos the Returned (including the Spirit enchantment creature token)
Ezuri, Claw of Progress
Kalemne, Disciple of Iroas
Meren of Clan Nel Toth
Mizzix of the Izmagnus
Plated Pegasus
Xantcha -- updated to include new info block and new subtype; unnecessary protections removed

Bugs fixed:
Shivan Wumpus -- removed unnecessary life total check

HQ art uploaded:
Bite of the Black Rose -- HQ upgrade
Custodi Soulbinders -- HQ upgrade
Extract from Darkness -- HQ upgrade
Ignition Team -- HQ upgrade
Paragon of New Dawns -- HQ upgrade
Vow of Duty -- HQ upgrade

Open Items:

-- CW_CARD_QUERY_SPLINTERVERSE has been updated and uploaded.

-- The Vanguard subtype is working successfully. I have uploaded an update to CW_SUBTYPES.lol and CW_SUBTYPES.xml to the auto upload folder. In the loose files SPECS folder, I uploaded ENCHANTMENT_TYPES.txt. With these updates, the subtype will display properly. I will work on updating all of the Vanguard cards to use this subtype (and remove the unnecessary protections).

-- To facilitate experience counters, the following files have been updated: CW_CONSTANTS.lol, CW_COST.lol, CW_COUNTERS.lol, and CW_TOKENS.lol. Experience counters are similar to energy counters so I repurposed much of the code from energy. The major difference is that experience counters are never spent, only accumulated and referenced. Without the updates to the files listed, the experience counter cards will not work. All of this has been tested including testing energy cards to make sure nothing regarding energy was disturbed by the new code.

Re: Community Wad

PostPosted: 23 Dec 2016, 16:11
by Splinterverse
erjerjerj wrote:
Splinterverse2 wrote:
erjerjerj wrote:Bug report:
Nirkana Revenant mana doubling doesn't work.
In case Gauntlet of Power does work (didn't test it), maybe the same mechanism can be copied from it.
Can Extraplanar Lens be coded too?

Another request, can Choice of Damnations be coded, or is it impossible?

Thanks,
Eran
I believe the "tapped for mana" effects only work with cards that are able to be manually tapped for mana. These cards are represented in the .Wad with MM in their name. The automatic tapping that occurs with most basic lands etc. won't trigger it. :(

Choice of Damnations is possible. If it's not already coded, I will add it to my to-do list meaning it will likely be available before the end of the year.
Thanks for the Choice of Damnations
Choice of Damnations has been coded, tested and uploaded. It should appear in the next .wad update. Keep in mind that when playing against AI opponents, the AI will most likely pick "1" when selecting a number on this card. I have not limited or specified the AI's selection, this is just what I have witnessed during many testing rounds.