Page 192 of 253

Re: Community Wad

PostPosted: 17 Jun 2017, 21:21
by Xander9009
fallenangle wrote:
Xander9009 wrote:Which IDs? I recently (as in just a couple of days ago) went through and removed all decks that referenced custom cards and fixed all of them that referenced actual cards but from other mods to the CW's copies. There shouldn't be any more decks that crash the game. If you can tell me either just the ID or the actual decks (if you know), then I'll take another look at them.
It has something to do with the way I set up the deckbuilder. I don't usually use decks that other people make, so the problem is with a deck I was working on. If the ID numbers in my custom decks are below XXX10, where the Xs represent the custom 3 digit code I use, then the game will crash. It's not a problem with anything in the CW, so don't worry. Sorry for alarming you!
Oh, I see. In that case, I can't do much about it haha.

On another note, I've coded Hour of Devastation's Wildfire Eternal and Hour of Revelation, and they both seem to be working as they should. I'll send them to you later today.
Nice! Splinterverse is also already getting started on Hour of Devastation. I hadn't seen Wildfire Eternal. That's a really cool card.

I also fixed Cartouche of Zeal. At least, I added a nil check. Hopefully, it was otherwise working correctly.

Re: Community Wad

PostPosted: 17 Jun 2017, 21:57
by fallenangle
[lua] [string "GLORYBRINGER_CW_426836_TITLE (RESOLUTION_TIME_ACTION)~0x00000325"]:7: attempt to index a nil value

I got this from Glorybringer just now.

I've done Bontu's Last Reckoning, and am in the process of testing it. Other than that, I don't plan to touch the planeswalkers or the eternalizeable creatures, so I'll leave those to Splinterverse, unless another really interesting one comes up, in which case I'll be sure to ask first. Thanks to both of you for all of your hard work!

Re: Community Wad

PostPosted: 18 Jun 2017, 14:07
by nivmizzet1
Whirlpool Rider is letting me choose which cards to shuffle

EDIT: also, it's not counting as card draw

EDIT: did someone just fix this, or did they fix it just before I made the request? Big coincidence if the later, but if so I'm sorry for the "double post".

EDIT: You were super quick Xander!! Confused the hell out of me -- I thought I was having more problems with the WAD updating, lol

Re: Community Wad

PostPosted: 18 Jun 2017, 14:49
by Splinterverse
Yeah. I've got all the cards coded/tested that have been spoiled so far for Hour of Devastation, but I am happy to have help, Fallenangle. If you see some spoilers that you want to do, just send me a PM or post it here and I'll leave those ones alone.

Re: Community Wad

PostPosted: 18 Jun 2017, 15:41
by Xander9009
Whirlpool Rider should be fixed.

Re: Community Wad

PostPosted: 18 Jun 2017, 16:56
by nivmizzet1
Xander9009 wrote:Whirlpool Rider should be fixed.
It seems to be good.

Re: Community Wad

PostPosted: 19 Jun 2017, 03:17
by nivmizzet1
I've been getting this log when I exit the game.

[lua] [string "Content\Functions\CW_FILTER.LOL"]:391: attempt to call method 'GetNthEvaluatedObject' (a nil value)

Re: Community Wad

PostPosted: 19 Jun 2017, 03:18
by Xander9009
I fixed this earlier today. Should be fixed in the next repack.

Re: Community Wad

PostPosted: 19 Jun 2017, 19:31
by fallenangle
Just so Splinterverse knows, I've done Oketra's Last Mercy, which was spoiled either late yesterday or early today. If you haven't done that one yet, you don't need to worry about it.

Re: Community Wad

PostPosted: 19 Jun 2017, 19:43
by Splinterverse2
fallenangle wrote:Just so Splinterverse knows, I've done Oketra's Last Mercy, which was spoiled either late yesterday or early today. If you haven't done that one yet, you don't need to worry about it.
Cool. Haven't done that one yet. Feel free to pm me code if you want. I will do a full generation of the final files and can put yours in along the way if you want.

Re: Community Wad

PostPosted: 20 Jun 2017, 10:09
by Splinterverse
@FallenAngle -- With Oketra's Last Mercy, now that we have EDH available in the CW, I'm wondering if you should also include a check for _MANAGER_COMMANDER, because if it is present, the starting life total would be 40. (This means that we should also probably update any card that references starting life total).

@Xander9009 -- speaking of EDH, did you ever get a chance to figure out why the AI never plays the commanders from Exile? I'm guessing that it is because the AI is pretty much trained to ignore Exile. We might have to make the "command zone" a different location and strip all abilities/types from the commander except for "cast this from the command zone" or whatever.

Re: Community Wad

PostPosted: 20 Jun 2017, 12:18
by Xander9009
Starting life total should be retrieved with CW_General_GetStartingLifeTotal(). I just updated it to include the possibility of EDH, whether it's 2 player (in which case it should be 30) or multiplayer (in which case it's 40).

The AI casts other cards from exile, though, I think. I'd need to check, but I'm pretty sure it handles it relatively alright it most cases. The only other zone that might even come close to working would be the graveyard, but even that could cause a lot of issues. While there are only a tiny handful of things that affect exiled cards, there are hundreds that affect the graveyard.

Re: Community Wad

PostPosted: 20 Jun 2017, 13:00
by Splinterverse2
Xander9009 wrote:Starting life total should be retrieved with CW_General_GetStartingLifeTotal(). I just updated it to include the possibility of EDH, whether it's 2 player (in which case it should be 30) or multiplayer (in which case it's 40).

The AI casts other cards from exile, though, I think. I'd need to check, but I'm pretty sure it handles it relatively alright it most cases. The only other zone that might even come close to working would be the graveyard, but even that could cause a lot of issues. While there are only a tiny handful of things that affect exiled cards, there are hundreds that affect the graveyard.
I played a bunch of WASH free for all games with four players and the AI never cast their commanders.

Re: Community Wad

PostPosted: 20 Jun 2017, 13:02
by Xander9009
I don't know what WASH is referring to.

Re: Community Wad

PostPosted: 20 Jun 2017, 14:59
by fallenangle
I'm going to try my hand at Neheb, the Eternal, just so Splinterverse knows.