Re: Community Wad
Posted: 03 Oct 2017, 01:01
Thanks for checking them over. I'd noticed line 428, but I was only glancing through each line looking for something likely, not looking for the 'most likely', even if the 'most likely' was still unlikely.
For line 119, I wasn't actually sure if it would consider the commented line at all. Depending on how the game interprets the code, I found it possible (albeit unlikely) that it might consider line 120 to be the first line within that RTA, making it line 2. Either way, the only object indexed between the two is MTG(), so it shouldn't cause the issue.
I went ahead and put in a check for the card type object on line 428 since it does seem most likely, and I also put a nil check for EffectDC() on line 414 just to play it safe.
And yeah, I'd counted the number of instances just by highlighting RESOLUTION_TIME_ACTION and hitting 'count' in Notepad++ (and mentally divided by 2) leaving a naive 18 since I forgot some were commented out.
For line 119, I wasn't actually sure if it would consider the commented line at all. Depending on how the game interprets the code, I found it possible (albeit unlikely) that it might consider line 120 to be the first line within that RTA, making it line 2. Either way, the only object indexed between the two is MTG(), so it shouldn't cause the issue.
I went ahead and put in a check for the card type object on line 428 since it does seem most likely, and I also put a nil check for EffectDC() on line 414 just to play it safe.
And yeah, I'd counted the number of instances just by highlighting RESOLUTION_TIME_ACTION and hitting 'count' in Notepad++ (and mentally divided by 2) leaving a naive 18 since I forgot some were commented out.