Page 231 of 253

Re: Community Wad

PostPosted: 10 Jul 2019, 02:07
by Parabolic
Splinterverse wrote:All Vanguard cards have been updated, including:
-- removing unnecessary protections
-- adding the more info block
-- adding the Vanguard subtype

With these updates, the work on the Vanguard cards is complete. Thanks go to Xander for his help on making the subtype appear in-game. Enjoy!
I was trying to find information about the MTGO Vanguard series (https://scryfall.com/search?as=grid&ord ... s%3Amtgoid) being coded but this post was all I found. Is there no interest?

How bad were the Vanguard cards to do? I could give a stab at some of them if they require copy-paste. I'm looking at Dauntless Escort and Etched Oracle, for example. I feel like those could largely be cobbled together based off of existing cards.

Some of these though, when WotC started getting slap-happy with adding the word "random" after the success of Mormir Basic, seem like they would be annoying to code.

Re: Community Wad

PostPosted: 10 Jul 2019, 09:56
by Splinterverse
Parabolic wrote:I was trying to find information about the MTGO Vanguard series (https://scryfall.com/search?as=grid&ord ... s%3Amtgoid) being coded but this post was all I found. Is there no interest?

How bad were the Vanguard cards to do? I could give a stab at some of them if they require copy-paste. I'm looking at Dauntless Escort and Etched Oracle, for example. I feel like those could largely be cobbled together based off of existing cards.

Some of these though, when WotC started getting slap-happy with adding the word "random" after the success of Mormir Basic, seem like they would be annoying to code.
This is actually something on my long-term list of things to do. They would have to be named either "Avatar - Dauntless Escort" or "Dauntless Escort Avatar" since we'll need to protect them by name and the MTGO ones have cards with the same names. I think the suffix "Avatar" is better, but I'll take a look at how The Gatherer lists it (once it is back online, it's currently down). Are there Avatars that you are particularly interested in seeing added? The two you referenced would be easy.

Re: Community Wad

PostPosted: 10 Jul 2019, 12:41
by Parabolic
Splinterverse wrote:This is actually something on my long-term list of things to do. They would have to be named either "Avatar - Dauntless Escort" or "Dauntless Escort Avatar" since we'll need to protect them by name and the MTGO ones have cards with the same names. I think the suffix "Avatar" is better, but I'll take a look at how The Gatherer lists it (once it is back online, it's currently down).
Scryfall has it as "Avatar - [name]". Here's an alphabetical list: https://scryfall.com/sets/pmoa
I got worried for a second because Sliver Queen also had a Vanguard card in the irl sets, but it had a different name.

Splinterverse wrote:Are there Avatars that you are particularly interested in seeing added? The two you referenced would be easy.
Not particularly. I guess just for completion's sake. I grew up playing Magic on MTGO. It also goes with my goal of creating "Boss Decks" for the AI; decks that have a very high powerlevel, but are straightforward to play. You could slip the Hermit Druid avatar in to basically any list and have it be much stronger.

I'm guessing Mormir Vig, Stonehewer Giant, Sliver Queen, and probably a few more are impossible, though.

Re: Community Wad

PostPosted: 10 Jul 2019, 14:52
by Splinterverse
Parabolic wrote:Scryfall has it as "Avatar - [name]"
It's interesting because the images have it that way, but then the text to the right has [name] Avatar. I keep checking the Gatherer and it's still down. Hopefully sometime today it will be up. I need it to be up to create the initial templates anyway.
Parabolic wrote:I'm guessing Mormir Vig, Stonehewer Giant, Sliver Queen, and probably a few more are impossible, though.
I'm not convinced that those would be impossible. I actually have a couple ideas on it, but I need to check with some of the other modders. If my idea actually has any merit, any card that involves random cards "outside the game" would probably only be playable locally because you wouldn't be able to reduce the size of your .wad files for multi-player play since you'd need access to a massive amount of cards. The tools that reduce the card count for multiplayer wouldn't recognize that you would need the cards not directly included in the deck for the random piece. Thus, it would eliminate those cards.

I would like to get all of the MTGO Vanguards in the CW. I can't commit to coding all of them right now, but I'll try to get a few going so that there's some progress being made on it.

Re: Community Wad

PostPosted: 10 Jul 2019, 18:48
by Parabolic
Minor bug report:

Glacial Revelation puts the top card of your library into your graveyard. The first time it milled a Snow-Covered Swamp and the second time an Abominable Treefolk.

Re: Community Wad

PostPosted: 10 Jul 2019, 19:02
by Splinterverse
Parabolic wrote:Minor bug report:

Glacial Revelation puts the top card of your library into your graveyard. The first time it milled a Snow-Covered Swamp and the second time an Abominable Treefolk.
Ok. I think this has to do with me using ChooseItemsFromDC as opposed to ChooseItemFromDC. I've changed the code and will upload shortly. I haven't tested it, but it should be in the CW tonight when it repacks.

Re: Community Wad

PostPosted: 10 Jul 2019, 19:41
by Parabolic
Splinterverse wrote:
Parabolic wrote:Minor bug report:

Glacial Revelation puts the top card of your library into your graveyard. The first time it milled a Snow-Covered Swamp and the second time an Abominable Treefolk.
Ok. I think this has to do with me using ChooseItemsFromDC as opposed to ChooseItemFromDC. I've changed the code and will upload shortly. I haven't tested it, but it should be in the CW tonight when it repacks.
Just had a game where Marit Lage's Slumber wasn't triggering the scry ability off my snow lands, so I was wondering if it has to do with the snow quality.

Re: Community Wad

PostPosted: 10 Jul 2019, 19:54
by Splinterverse
Parabolic wrote:Just had a game where Marit Lage's Slumber wasn't triggering the scry ability off my snow lands, so I was wondering if it has to do with the snow quality.
I just checked the code for Marit Lage's Slumber and the snow-covered basic lands. The basic lands all have the supertype of snow. Marit's Lage is appropriately checking for snow and permanent status (which a snow-covered land would qualify for). But, that said, we are using the CW_General_IsPermanent() function, which may be having issues based on some other things I've seen recently. Can you check your SCRIPT_LOG.txt file in your game folder? It might have something relevant to help us.

I've been seeing this periodically, but I'm the only one who has reported it, so we can't rule out that I don't have some extra file or something causing a problem: [lua] [string "Content\Functions\CW_GENERAL.LOL"]:273: attempt to call global 'CARD_TYPE_LAND' (a table value)

If it is impacting you (and appears in your SCRIPT_LOG.txt) file, than it could be that the CW_General_IsPermanent function is having issues with the type land for some reason.

BTW, anyone know how to tag a user in this forum? I'd like to tag Xander9009 here, but I can't figure out how. "At symbol" doesn't seem to do it.

Re: Community Wad

PostPosted: 11 Jul 2019, 03:11
by Parabolic
Splinterverse wrote:Can you check your SCRIPT_LOG.txt file in your game folder? It might have something relevant to help us.
Sure can, and it might look familiar.

I have:
[lua] [string "Content\Functions\CW_GENERAL.LOL"]:273: attempt to call global 'CARD_TYPE_LAND' (a table value)
as the first few lines and also some as the last few lines.

Re: Community Wad

PostPosted: 12 Jul 2019, 12:47
by Splinterverse
Parabolic wrote:
Splinterverse wrote:Can you check your SCRIPT_LOG.txt file in your game folder? It might have something relevant to help us.
Sure can, and it might look familiar.

I have:
[lua] [string "Content\Functions\CW_GENERAL.LOL"]:273: attempt to call global 'CARD_TYPE_LAND' (a table value)
as the first few lines and also some as the last few lines.
Thanks. I'll email that to Xander. Hopefully he can look at the issues soon. I think this also relates to the Emblem issue, where emblems are being wiped by cards like Displacement Wave.

Re: Community Wad

PostPosted: 14 Jul 2019, 23:41
by addict insane
Rhythm of the Wild is correctly giving creatures the +1/+1 from Riot, but it couldn't give haste to my Ilharg.

Having a MM Drover of the Mighty would be nice.

Also,

14-07-2019 08:39:19 p.m.: Low: Card (ROTTING_REGISAUR_CW (1)) in wad DATA_DLC_COMMUNITY_CORE has a FILENAME tag that does not match which will cause problems in-game: ROTTING_REGISAUR_CW

Re: Community Wad

PostPosted: 15 Jul 2019, 00:18
by Splinterverse
addict insane wrote:Rhythm of the Wild is correctly giving creatures the +1/+1 from Riot, but it couldn't give haste to my Ilharg.
I've fixed this and uploaded it. It should be in the next CW repack. It has not been tested.

addict insane wrote:Having a MM Drover of the Mighty would be nice.
I made one for you and uploaded it. It should be in the next CW repack. It hasn't been tested.

addict insane wrote:14-07-2019 08:39:19 p.m.: Low: Card (ROTTING_REGISAUR_CW (1)) in wad DATA_DLC_COMMUNITY_CORE has a FILENAME tag that does not match which will cause problems in-game: ROTTING_REGISAUR_CW
I would love to fix this error, but even though I have modder access to the loose files, when I search for the ones giving this error, nothing shows up. I think Xander is going to have to fix this issue.

Thanks for reporting the bugs. We appreciate it. Please continue to do so. :)

Re: Community Wad

PostPosted: 15 Jul 2019, 02:37
by SenaM66
Dreadhorde General Lili's ult doesn't seem to be working. It asks me to pick between my own permanents and then does nothing.

Re: Community Wad

PostPosted: 15 Jul 2019, 07:58
by addict insane
Splinterverse wrote:
addict insane wrote:Rhythm of the Wild is correctly giving creatures the +1/+1 from Riot, but it couldn't give haste to my Ilharg.
I've fixed this and uploaded it. It should be in the next CW repack. It has not been tested.

addict insane wrote:Having a MM Drover of the Mighty would be nice.
I made one for you and uploaded it. It should be in the next CW repack. It hasn't been tested.

addict insane wrote:14-07-2019 08:39:19 p.m.: Low: Card (ROTTING_REGISAUR_CW (1)) in wad DATA_DLC_COMMUNITY_CORE has a FILENAME tag that does not match which will cause problems in-game: ROTTING_REGISAUR_CW
I would love to fix this error, but even though I have modder access to the loose files, when I search for the ones giving this error, nothing shows up. I think Xander is going to have to fix this issue.

Thanks for reporting the bugs. We appreciate it. Please continue to do so. :)
Damn, Splinter, that literally took you like half an hour! Thanks a lot!

Also, I'm not seeing the God-Eternal version of Efnet, is that impossible? To my understanding, copying effects is impossible, but copying spells is not.

Re: Community Wad

PostPosted: 15 Jul 2019, 10:58
by Splinterverse
SenaM66 wrote:Dreadhorde General Lili's ult doesn't seem to be working. It asks me to pick between my own permanents and then does nothing.
I will work on this on Wednesday when I am off work. It will take some time to fix, but I believe we can fix it. I'll post again when I've corrected it.
addict insane wrote:Damn, Splinter, that literally took you like half an hour! Thanks a lot!
No problem. Sometimes the fixes are quick.
addict insane wrote:Also, I'm not seeing the God-Eternal version of Efnet, is that impossible? To my understanding, copying effects is impossible, but copying spells is not.
The problem with this card isn't the copying of the spell, it's altering the cost of the copy. I haven't figured out how to do it. There may be another modder with and idea of how to do it. I hope so because it's a cool card.