It is currently 08 Jul 2021, 04:23
   
Text Size

Community Wad

Moderators: Xander9009, CCGHQ Admins

Re: Community Wad

Postby Xander9009 » 04 May 2015, 17:08

Kithkin wrote:Bug report

Thopter Squadron (CW_6164): first ability (remove) costs 2 instead of 1
Fixed.
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 444 times

Re: Community Wad

Postby Kithkin » 04 May 2015, 17:51

Xander9009 wrote:Try it again next update. I added a SetItemCount since that solved the same problem with the manifest creature.
No, Trostani not fixed.
User avatar
Kithkin
 
Posts: 456
Joined: 21 Feb 2014, 07:12
Location: Cologne, GERMANY
Has thanked: 11 times
Been thanked: 56 times

Re: Community Wad

Postby Misplay » 05 May 2015, 10:43

Hi!

Bug report
1. "Oath of druids":
- The card doesn't trigger if you don't have any creature in your Library.
- When the opponent triggers the oath, you(= controller of the oath of druids) have the choice to activate it or not.

2. "Dromoka's command":
- When you use the mode "+1/+1" (3rd ability) with the mode "Fight" (4th ability), the +1/+1 counter is put on the fighting creature AFTER the resolution of the fight.
Misplay
 
Posts: 92
Joined: 29 Aug 2013, 08:26
Has thanked: 50 times
Been thanked: 10 times

Re: Community Wad

Postby Xander9009 » 05 May 2015, 12:24

Misplay wrote:Hi!

Bug report
1. "Oath of Druids":
- The card doesn't trigger if you don't have any creature in your Library.
- When the opponent triggers the oath, you(= controller of the oath of druids) have the choice to activate it or not.

2. "Dromoka's Command":
- When you use the mode "+1/+1" (3rd ability) with the mode "Fight" (4th ability), the +1/+1 counter is put on the fighting creature AFTER the resolution of the fight.
Oath of Druids may or may not be fixed. I added a loop after the code normally stops due to finding a creature. If it finds no creatures, it should run this second loop which will move all cards in the library to the graveyard.

Also replaced the simple <MAY /> tag with a multiple choice question asked to the current player.

For Dromoka's Command, I'm not sure how to fix that. Sorry.

Also, proper capitalization will highlight the cards automatically.
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 444 times

Re: Community Wad

Postby Kithkin » 05 May 2015, 14:57

Kithkin wrote:
Xander9009 wrote:Try it again next update. I added a SetItemCount since that solved the same problem with the manifest creature.
No, Trostani not fixed.
Fixed
User avatar
Kithkin
 
Posts: 456
Joined: 21 Feb 2014, 07:12
Location: Cologne, GERMANY
Has thanked: 11 times
Been thanked: 56 times

Re: Community Wad

Postby Xander9009 » 05 May 2015, 15:01

Well, I'm glad. But I didn't update it again lol. Oh well. Fixed is fixed.
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 444 times

Re: Community Wad

Postby ShoGUN » 05 May 2015, 15:13

Remember that Populate is not targeted and nothing happens if there are no valid token creatures to choose. Tested it and seems to be working fine, yes.
User avatar
ShoGUN
 
Posts: 28
Joined: 17 Feb 2015, 09:30
Has thanked: 6 times
Been thanked: 5 times

Re: Community Wad

Postby ShoGUN » 05 May 2015, 15:42

Misplay wrote:Hi!

"Dromoka's command":
- When you use the mode "+1/+1" (3rd ability) with the mode "Fight" (4th ability), the +1/+1 counter is put on the fighting creature AFTER the resolution of the fight.
The spell is supposed to resolve in printing order, but in the case of DOTP 2014 I guess it "stacks" the actions in that order and resolves them in reverse order.

I tested that and this kind of cases can be fixed quickly by reversing the order of the action mode list, but then of course the prompted list doesn't quite look like the original one on the card itself.

IMO the functionality far precedes the order of the "mode list".

Changed the order and fixed also putting the +1/+1 counter on any target creature instead of controller's one.

And correction:

It's not the order in the UI list but the order the "resolution actions" are in the code so even better. Still, the problem of dealing damage with the new added power remains...
User avatar
ShoGUN
 
Posts: 28
Joined: 17 Feb 2015, 09:30
Has thanked: 6 times
Been thanked: 5 times

Re: Community Wad

Postby RiiakShiNal » 05 May 2015, 23:47

ShoGUN wrote:Still, the problem of dealing damage with the new added power remains...
I'll point you to MTG():ReevaluateContinuousEffects(), this should be quite useful in this case.
RiiakShiNal
Programmer
 
Posts: 2160
Joined: 16 May 2011, 21:37
Has thanked: 74 times
Been thanked: 483 times

Re: Community Wad

Postby zysron » 06 May 2015, 21:15

Collective Voyage is broken

ai can pay more mana than they have and you can only pay up to 13
zysron
 
Posts: 101
Joined: 13 Mar 2015, 09:02
Has thanked: 0 time
Been thanked: 2 times

Re: Community Wad

Postby Xander9009 » 06 May 2015, 21:20

zysron wrote:Collective Voyage is broken

ai can pay more mana than they have or gets as many as you do cannot tell wich yet
Collective Voyage works such that first players choose how much mana they will pay. Say you pay 3 and your opponent pays 2. Then, everyone can search their library for up to 5 lands. You don't get 3 and them 2; but rather, the mana is combined. This is denoted by the fact that the it says each player pays mana, THEN each player searches for lands up to the TOTAL. So, it sounds like it's working correctly.
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 444 times

Re: Community Wad

Postby zysron » 07 May 2015, 05:41

well then i have totally been using this card wrong irl...

but wait ... i paid 13 and the ai paid 1 but i still only got 13 land cards...
zysron
 
Posts: 101
Joined: 13 Mar 2015, 09:02
Has thanked: 0 time
Been thanked: 2 times

Re: Community Wad

Postby Aborash » 07 May 2015, 07:41

Hi there


I'm not sure if I made something wrong (I doubt, I follow every single step), but seems like I got tons of errors with a fresh new clean community Install.

More Info here:

viewtopic.php?f=109&t=17162
Aborash
 
Posts: 57
Joined: 27 Mar 2011, 09:45
Has thanked: 16 times
Been thanked: 0 time

Re: Community Wad

Postby Xander9009 » 07 May 2015, 17:36

I've updated the repacking utility in an attempt to correct the auto-backup feature. It appears to be working much more reliably.

The problem seems to have been that it wasn't waiting long enough between adding the changed card list and then adding the actual wad. It worked fine when the files were a bit smaller, but as they grow larger, that waiting period needed to grow. Instead of just increasing it, I've completely reworked it so that waiting period is no longer even needed. I even managed to cut it down from about 20 lines to 2. Would have been one, but Google Drive seems to want to delete the compressed file if I try to edit it via command line. Anyway, it's now working properly and should work more reliably in the future without needing fixed. However, there was one oddity I found which may end up breaking. (It needed a random, out of place extra quotation mark, despite that causing there to be an odd number of them... But it wouldn't work any other way, so hopefully it'll be okay.)

My next goal is to try and get the changed cards utility fixed. Unfortunately, I still don't have a very good way to do it. The way it's working right now is simply comparing the list of cards to a text list to see if they're new, and then comparing their modified date to the current date. I wanted to use the actual tags, but with thousands of files, that's really slow. However, before long, I should have this whole thing moved over to a server I'm helping my dad with, so the speed might not matter anymore (since it won't be interfering with my using my laptop). In addition, I might be able to use the tags and speed it up dramatically if I'm a bit more strict about the tags. If the date tag is ALWAYS second to last, then I can read just that line without reading the rest of the file. That should increase the speed considerably. I'll test this out and a couple of other ideas and see what happens. I'll be busy, though, so I might not be able to work on it much.
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 444 times

Re: Community Wad

Postby Aborash » 07 May 2015, 20:16

Xander9009 wrote:I've updated the repacking utility in an attempt to correct the auto-backup feature. It appears to be working much more reliably.

The problem seems to have been that it wasn't waiting long enough between adding the changed card list and then adding the actual wad. It worked fine when the files were a bit smaller, but as they grow larger, that waiting period needed to grow. Instead of just increasing it, I've completely reworked it so that waiting period is no longer even needed. I even managed to cut it down from about 20 lines to 2. Would have been one, but Google Drive seems to want to delete the compressed file if I try to edit it via command line. Anyway, it's now working properly and should work more reliably in the future without needing fixed. However, there was one oddity I found which may end up breaking. (It needed a random, out of place extra quotation mark, despite that causing there to be an odd number of them... But it wouldn't work any other way, so hopefully it'll be okay.)

My next goal is to try and get the changed cards utility fixed. Unfortunately, I still don't have a very good way to do it. The way it's working right now is simply comparing the list of cards to a text list to see if they're new, and then comparing their modified date to the current date. I wanted to use the actual tags, but with thousands of files, that's really slow. However, before long, I should have this whole thing moved over to a server I'm helping my dad with, so the speed might not matter anymore (since it won't be interfering with my using my laptop). In addition, I might be able to use the tags and speed it up dramatically if I'm a bit more strict about the tags. If the date tag is ALWAYS second to last, then I can read just that line without reading the rest of the file. That should increase the speed considerably. I'll test this out and a couple of other ideas and see what happens. I'll be busy, though, so I might not be able to work on it much.
Great, as I said in the other post, I'll check it asap.

Many thanks!
Aborash
 
Posts: 57
Joined: 27 Mar 2011, 09:45
Has thanked: 16 times
Been thanked: 0 time

PreviousNext

Return to 2014

Who is online

Users browsing this forum: No registered users and 5 guests


Who is online

In total there are 5 users online :: 0 registered, 0 hidden and 5 guests (based on users active over the past 10 minutes)
Most users ever online was 1922 on 07 Jun 2021, 06:01

Users browsing this forum: No registered users and 5 guests

Login Form