It is currently 08 Jul 2021, 05:00
   
Text Size

Community Wad

Moderators: Xander9009, CCGHQ Admins

Re: Community Wad

Postby Yodatheugly » 09 Jun 2015, 11:06

Ah, that would be a pity. The deck I'm fiddling around with at the moment, is nothing but Exploit. So the only reason Mirror Mockery is in there right now, is to let tokens exploit themselves, haha.
Ah well, nothing to do about it, if that's the case.
Yodatheugly
 
Posts: 18
Joined: 27 May 2015, 01:31
Location: Antwerpen, Belgium
Has thanked: 4 times
Been thanked: 0 time

Re: Community Wad

Postby RiiakShiNal » 09 Jun 2015, 11:07

Yodatheugly wrote:Could it be that you've changed Mirror Mockery to exile itself, instead of just destroying the tokens it creates? Or maybe it's because I sacrificed the token myself with the exploit ability, and it was still searching for a card to exile. Not really sure. I don't really see anything in the card's code that might do that.
EDIT:
Code: Select all
<RESOLUTION_TIME_ACTION>
         local token_chest = EffectDC()
         if token_chest ~= nil then
            local token_count = token_chest:Count()
            for i=0,token_count-1 do
               local token = token_chest:Get_NthCardPtr(i)
               if token ~= nil then
                  token:Exile()
               end
            end
         end
</RESOLUTION_TIME_ACTION>
Since the code is pretty clear in handling with tokens, I would think it has something to do with destroying the token, before it can be exiled. But haven't tested it thoroughly.
The code looks to have a bug in it. Count() probably looks through the chest until it finds a nil value, but if a token leaves play before its time then its pointer will become nil and throw off the count if it wasn't at the end. For example there are 3 tokens in the chest and the first one leaves play prematurely the first value becomes nil, the Count() returns 0 and the other 2 tokens don't get exiled. The actual count should be stored when the token(s) are created then read the stored actual count and exile if the card pointer isn't nil.

Granted for Mirror Mockery there should never be more than one token (because a creature can't be declared attacking more than once per combat) so this calculation shouldn't matter.

Looking at the code it is pulling the EffectDC() chest and calling it the token_chest, but if this is in another ability (which it should be since it should be triggered) then the only possible way for this to work is if the EffectDC() chest was provided to the effect by a CreateDelayedTrigger() call with the pointer to the token created stored in index 0. If the pointer is stored elsewhere, or if this is not a delayed trigger then it won't work given just the code snippet.
RiiakShiNal
Programmer
 
Posts: 2160
Joined: 16 May 2011, 21:37
Has thanked: 74 times
Been thanked: 483 times

Re: Community Wad

Postby cenarius » 09 Jun 2015, 14:46

Hi there.

I want to report a bug on "Tortured Existence" card. It doesn't torture anything and it should, and it's hard to have a deck called "Tortured Existence" without that card.

I hope it gets patched.

Thanks for your awesome brilliant work.
cenarius
 
Posts: 87
Joined: 09 Jun 2015, 14:40
Has thanked: 0 time
Been thanked: 0 time

Re: Community Wad

Postby Xander9009 » 09 Jun 2015, 15:16

@Riiak: Yes, that's how it was coded. The token chest was passed in so that the tokens were all in EffectDC(). The code from that delayed trigger was borrowed from elsewhere and the variable name just wasn't changed.

It's been changed to store the token count rather than trying to count it when it's time to exile. It now also doesn't directly jump into the for loop; it instead checks if the count is actually greater than 0 (which now is less important, but still). Hopefully it is fixed.

Also fixed all megamorph cards to show the face down ability that morph cards show. They were showing (when face down) "Megamorph (view hidden info.)" which showed they were megamorph creatures. They now say Morph, instead. Technically, there's still a problem with a morph card being manifested. They should work, but they'll have the morph ability. While that's actually correct, it gives the opponents more information than they should have. I'm not too worried about it though. It would probably be fixable. Specifically, by making a manager and having the manager grant the face down ability. Putting a card face down would include telling the manager whether it's morphed or manifested. And then the manager would grant one ability with the option to use either cost if both manifest and morph costs are defined. That's a lot more work than I feel is worth it until someone actually has this problem.

Morph and megamorph have another issue, but I'm currently working on it.

cenarius wrote:Hi there.

I want to report a bug on "Tortured Existence" card. It doesn't torture anything and it should, and it's hard to have a deck called "Tortured Existence" without that card.

I hope it gets patched.

Thanks for your awesome brilliant work.
I just tested Tortured Existence and it worked exactly the way it was supposed to. What went wrong when you tried to use it? More specifically than "it doesn't torture anything". Do you mean it didn't force you to discard? Or that you could use it with nothing in hand? Or something else?

@fallenangle: When it updates, let me know if it's fixed and if Voidmage Prodigy throws an error when you exit the game after morphing it. I had to make it grant ability 18 to all morph cards, but Voidmage Prodigy and other normal morph cards don't have ability 18 (and Voidmage Prodigy is the only normal morph card that uses the new morph functions so far). I didn't get any errors, but for some reason, I pretty much never get any errors upon exiting. I only get the errors from the Deck Builder.
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 444 times

Re: Community Wad

Postby cenarius » 09 Jun 2015, 16:45

Xander9009 wrote:I just tested Tortured Existence and it worked exactly the way it was supposed to. What went wrong when you tried to use it? More specifically than "it doesn't torture anything". Do you mean it didn't force you to discard? Or that you could use it with nothing in hand? Or something else?
Ah sorry, my bad. When i said "it doesn't torture anything" was well, it doesn't do anything actually. I tought it was bugged because it worked sometimes and in others it didn't, but the problem was that it didn't detected the mana from nonbasic lands and i had to produce mana manually.

Everything works just fine.

Again, sorry. What can i say, i'm new.

Thank you for your quick reply.
cenarius
 
Posts: 87
Joined: 09 Jun 2015, 14:40
Has thanked: 0 time
Been thanked: 0 time

Re: Community Wad

Postby Xander9009 » 09 Jun 2015, 17:09

cenarius wrote:
Xander9009 wrote:I just tested Tortured Existence and it worked exactly the way it was supposed to. What went wrong when you tried to use it? More specifically than "it doesn't torture anything". Do you mean it didn't force you to discard? Or that you could use it with nothing in hand? Or something else?
Ah sorry, my bad. When i said "it doesn't torture anything" was well, it doesn't do anything actually. I tought it was bugged because it worked sometimes and in others it didn't, but the problem was that it didn't detected the mana from nonbasic lands and i had to produce mana manually.

Everything works just fine.

Again, sorry. What can i say, i'm new.

Thank you for your quick reply.
No problem. I just wasn't sure how to fix it, since it appeared to be working. And yeah, anything with MM in the filename (you can see it in the deck builder when choosing cards) will require you to manually produce the mana before the game will recognize its existence. Many cards have autotap cards available as well, but not all (not actually sure if it's a majority or not...).

I've forced an early repack so the megamorph cards can be tested earlier.
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 444 times

Re: Community Wad

Postby Kithkin » 09 Jun 2015, 17:45

Spells with Dash still cost nothing (mana does not tap), if you choose to pay the normal mana costs.

Skywise Teachings -- no Djinn Monk token, if 1U is paid
User avatar
Kithkin
 
Posts: 456
Joined: 21 Feb 2014, 07:12
Location: Cologne, GERMANY
Has thanked: 11 times
Been thanked: 56 times

Re: Community Wad

Postby Yodatheugly » 09 Jun 2015, 19:38

Risen Executioner and Mirror Mockery both have indeed been fixed. One new detail on the Risen Executioner, casting cost won't increase when more creatures are in the graveyard.

EDIT: Seems like the tokens don't get exiled at all again.
Code: Select all
 [lua] [string "MIRROR_MOCKERY_CW_394625_TITLE (RESOLUTION_TIME_ACTION)~0x00000690"]:5:
 parameter mismatch or too few parameters [expected bzS32]
Yodatheugly
 
Posts: 18
Joined: 27 May 2015, 01:31
Location: Antwerpen, Belgium
Has thanked: 4 times
Been thanked: 0 time

Re: Community Wad

Postby fallenangle » 09 Jun 2015, 22:54

Avatar of the Resolute doesn't seem to get +1/+1 counters. I had a megamorphed Den Protector on the battlefield when I cast one, and it didn't get any counters.

As for Mirror Mockery, the error should be a call for 'tokencount' rather than 'token_count' on line 89.

Edit: Avatar of the Resolute: Line 80 (line 3 of the triggered ability RTA), FE_INSTANCE should be FE_CARD_INSTANCE.
fallenangle
 
Posts: 319
Joined: 20 Jul 2013, 02:31
Has thanked: 73 times
Been thanked: 38 times

Re: Community Wad

Postby Xander9009 » 10 Jun 2015, 01:38

Skywise Teachings should be fixed.

I noticed the problem in Mirror Mockery and had already fixed it, but thanks for the Avatar of the Resolute sighting. Now fixed. (I've done a search with the Deck Builder to find any other instances of this particular mistake because I've seen several instances of it, all my fault, but there don't seem to be any more.)

Risen Executioner: the game couldn't seem to handle a normal cast from the graveyard with an additional cost. No matter how I handled it, it always did something wrong (many times freezing while waiting for the rest of the two-part payment, simply not recognizing that the payment was made in other cases, not recognizing that the payment can be paid in other cases, etc). Due to this trouble, the ability is now an activated ability rather than teh proper utility ability. It may potentially cause trouble with cards that trigger on activated ability activation. However, I've used Riiak's ManaAbilityStart function, which is supposed to be watched for. Unfortunately, I don't know how that'll work with it coming before a cost. I really hope it works alright, now.

Dash is fixed as well.

Thanks to fallenangle, Gideon Jura, Narset Transcendent, and Sarkhan Unbroken have been added, as well the overload cards from Neo that I missed originally.
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 444 times

Re: Community Wad

Postby cenarius » 10 Jun 2015, 08:24

Hi there.

This is more like a request than a bug report. I wouldn't ask for this in here but there is a pretty useful card missing which is "Cursed totem". Now, when i saw a pic of this card i noticed it was from sixth edition, which is not part of the community wad but then i also noticed it was reprinted from the original card published on Mirage expansion, which is a part of the community wad, so i felt like asking about it because for a black control deck, 2 or 3 of these against a rebeld deck is a must have.

What do you guys think?

I hope you can make it.

Again, thanks for your work.

Edited: Also, another card missing, "Massacre",4 of these on a control deck is a must, at least on the sideboard.

Edited2: Another forgotten cards, "Rathi assassin", "Rathi intimidator" and "Heartstone". I'm sorry for requesting too many at once, i'm building a classic mercenary deck now and these cards are key :p
cenarius
 
Posts: 87
Joined: 09 Jun 2015, 14:40
Has thanked: 0 time
Been thanked: 0 time

Re: Community Wad

Postby RiiakShiNal » 10 Jun 2015, 11:16

Heartstone can't be made because we have no way of altering ability costs.
RiiakShiNal
Programmer
 
Posts: 2160
Joined: 16 May 2011, 21:37
Has thanked: 74 times
Been thanked: 483 times

Re: Community Wad

Postby cenarius » 10 Jun 2015, 11:29

RiiakShiNal wrote:Heartstone can't be made because we have no way of altering ability costs.
That's fine, Cursed totem and Heartstone aren't essential, just a good backup, that's all, but at least i hope the rathi creatures and Massacre are added later on.

Thanks for the reply.

Edited: I've found the card "Phyrexian Revoker" with the deck builder, maybe there is a way to use its ability to apply on every creature.
cenarius
 
Posts: 87
Joined: 09 Jun 2015, 14:40
Has thanked: 0 time
Been thanked: 0 time

Re: Community Wad

Postby cenarius » 10 Jun 2015, 14:17

Another missing card is "Rhystic Tutor".
cenarius
 
Posts: 87
Joined: 09 Jun 2015, 14:40
Has thanked: 0 time
Been thanked: 0 time

Re: Community Wad

Postby Xander9009 » 10 Jun 2015, 14:39

cenarius wrote:Hi there.

This is more like a request than a bug report. I wouldn't ask for this in here but there is a pretty useful card missing which is "Cursed Totem". Now, when i saw a pic of this card i noticed it was from sixth edition, which is not part of the community wad but then i also noticed it was reprinted from the original card published on Mirage expansion, which is a part of the community wad, so i felt like asking about it because for a black control deck, 2 or 3 of these against a rebel deck is a must have.

What do you guys think?

I hope you can make it.

Again, thanks for your work.

Edited: Also, another card missing, "Massacre",4 of these on a control deck is a must, at least on the sideboard.

Edited2: Another forgotten cards, "Rathi Assassin", "Rathi Intimidator" and "Heartstone". I'm sorry for requesting too many at once, i'm building a classic mercenary deck now and these cards are key :p
This thread isn't for bug reports. It's just the best place for them, so there are a lot here. It's for anything related to the CW, and that includes requests. Also, the CW isn't made of specific sets. It's made of whatever cards the makers happened to need or want. There are a few sets thanks to NeoAnderson and Tejahn deciding to make whole sets (and eventually, I made most of Dragons of Tarkir). However, most cards are just whatever was needed at the time.

Anyway, I've made Cursed Totem, Rathi Assassin, Rathi Intimidator, and Massacre. They've all been added to the CW, and they'll be available when it updates next (which should be in about 3 hours; but I have no way to really know).

EDIT: I've now attempted Rhystic Tutor. You'll have to let me know if it has problems.
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 444 times

PreviousNext

Return to 2014

Who is online

Users browsing this forum: No registered users and 3 guests


Who is online

In total there are 3 users online :: 0 registered, 0 hidden and 3 guests (based on users active over the past 10 minutes)
Most users ever online was 1922 on 07 Jun 2021, 06:01

Users browsing this forum: No registered users and 3 guests

Login Form