cenarius wrote:Well, making cards was far easier than i tought... if i did it right.
Before starting to share other cards i want to make sure i did it right so here you have a link to my files:
https://drive.google.com/file/d/0B-oDza ... sp=sharingThe card i made is "
Phyrexian Driver", for my mercenary deck. It works for me but i want to make sure it's fine as it is or else i must change something, specially with the id, which i didn't understood entirely (english isn't my native language).
So i hope someone guides me into the right direction here.
Xander9009 wrote:Keep in mind you should properly capitalize the cards so the forum can highlight them.
And how do i do that? i visited the main page and i couldn't find a "Basic info" thread.
Well, that's it for now. I'll be working on my other cards as well, but i don't mind sharing my set when it's done.
Let me know
It's close, but it does have some problems.
The IDs are off, like you thought they might be. You put 512 on the beginning. This is a good practice for any mod EXCEPT the CW. For the cw, the filename and filename tag should be "PHYREXIAN_DRIVER_CW_22379". The MultiverseID tag is just "22379". The ArtID tag is "CW22379".
You included the art, but unless the art is better than what I already have, you don't need to. You can skip getting the art, because the CW already has all of the art, even for cards not in the CW. It doesn't hurt that it's in there, it's just a little more work than you need to do.
Next up, the way the tags are put together. A "tag" is any thing inside angle brackets like < >. So, <TRIGGERED_ABILITY> is a "triggered ability" tag. The main block is alright, though. A "block" is everything between a tag and its closing tag, which is when a tag starts with "</".
- Code: Select all
<TRIGGERED_ABILITY> ---This is inside the "triggered ability" block--- </TRIGGERED_ABILITY>
Now, there are some tag that cannot go inside blocks. They are mutually exclusive.
PLAY_TIME_ACTION
RESOLUTION_TIME_ACTION
CONTINUOUS_ACTION
TARGET
TRIGGER
Those cannot go inside each other. So, you have
- Code: Select all
<TRIGGERED_ABILITY>
<LOCALISED_TEXT LanguageCode="en-US"><![CDATA[When Phyrexian Driver enters the battlefield, other Mercenary creatures get +1/+1 until end of turn.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[When Phyrexian Driver enters the battlefield, other Mercenary creatures get +1/+1 until end of turn.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Cuando el Caudillo pirexiano entre en juego, todos los otros mercenarios obtienen +1/+1 hasta el final del turno]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[When Phyrexian Driver enters the battlefield, other Mercenary creatures get +1/+1 until end of turn.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Quando il Condottiero di Phyrexia entra nel campo di battaglia, tutte le altre creature Mercenario prendono +1/+1 fino alla fine del turno.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[When Phyrexian Driver enters the battlefield, other Mercenary creatures get +1/+1 until end of turn.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[When Phyrexian Driver enters the battlefield, other Mercenary creatures get +1/+1 until end of turn.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[When Phyrexian Driver enters the battlefield, other Mercenary creatures get +1/+1 until end of turn.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[When Phyrexian Driver enters the battlefield, other Mercenary creatures get +1/+1 until end of turn.]]></LOCALISED_TEXT>
<TRIGGER value="ZONECHANGE_END" simple_qualifier="self" to_zone="ZONE_BATTLEFIELD">
<FILTER filter_id="0">
local filter = ClearFilter()
filter:Add( FE_CARD_INSTANCE, OP_NOT, EffectSource() )
filter:Add( FE_SUBTYPE, OP_IS, CREATURE_TYPE_MERCENARY )
filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
filter:Add( FE_CONTROLLER, OP_IS, EffectController() )
</FILTER>
<RESOLUTION_TIME_ACTION>
<CONTINUOUS_ACTION layer="7C" filter_id="0">
if FilteredCard() ~= nil then
local characteristics = FilteredCard():GetCurrentCharacteristics()
characteristics:Power_Add( 1 )
characteristics:Toughness_Add( 1 )
end
</CONTINUOUS_ACTION>
</RESOLUTION_TIME_ACTION>
<DURATION simple_duration="UntilEOT" />
</TRIGGER>
<AI_AVAILABILITY window_step="declare_blockers" type="window" window_in_combat="1" />
<HELP title="MORE_INFO_BADGE_TITLE_11" body="MORE_INFO_BADGE_BODY_11" zone="ZONE_ANY" />
<SFX text="COMBAT_BLUNT_LARGE_ATTACK" power_boundary_min="4" power_boundary_max="-1" />
<SFX text="COMBAT_BLUNT_SMALL_ATTACK" power_boundary_min="1" power_boundary_max="3" />
</TRIGGERED_ABILITY>
You have most of the tags/blocks inside of a TRIGGER block, which can't be done. You also have a CONTINUOUS_ACTION block inside of a RESOLUTION_TIME_ACTION block. Both of these need fixed.
For the first, just remove the </TRIGGER> line and close the <TRIGGER...> tag immediately. You do that by changing ">" at the end to "/>" instead. So, you should be
- Code: Select all
<TRIGGER value="ZONECHANGE_END" simple_qualifier="self" to_zone="ZONE_BATTLEFIELD" />
For the second, just remove the RESOLUTION_TIME_ACTION tags. You're doing something that will last, so you do need the CONTINUOUS_ACTION block. However, because you aren't doing anything that happens only once (drawing a card, losing
X life, destroying a creature, ...), you don't need a RESOLUTION_TIME_ACTION block.That is for things that happen when the spell or ability resolves, and they happen exactly once and then are done.
Next up, the "<HELP...>" and <SFX...>" tags should only appear once, and they should be outside any abilities and inside the <CARD_V2>...</CARD_V2> block. However, that particular HELP tag (you can tell which it is by the section "MORE_INFO_BADGE_TITLE_11") is for the Shadow ability like
Thalakos Sentry has. (The only easy way to know this is to search the deck builder for "MORE_INFO_BADGE_TITLE_11" in the advanced filter.) Just remove the line altogether.
Your AUTHOR, EDITOR, and DATE tags should go
immediately before the </CARD_V2> tag.
The DATE tag should be DAY-MONTH-YEAR. You have MONTH-DAY-YEAR. (Also, while much less important, they should all be two digits, even when less than ten. But that's not problematic, really. It just looks a lot better and makes it work nicely with the tools I made for the CW.)
Last up, your filter is almost right, but has one specification that is wrong. It should
not only affect your creatures. The ability only says other mercenary creatures. So, remove the line "filter:Add( FE_CONTROLLER, OP_IS, EffectController() )".
With all of those changes, it looks like this.
- Phyrexian Driver | Open
- Code: Select all
<?xml version='1.0' encoding='UTF-8'?>
<CARD_V2 ExportVersion="1">
<FILENAME text="PHYREXIAN_DRIVER_CW_22379" />
<CARDNAME text="PHYREXIAN_DRIVER" />
<TITLE>
<LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Phyrexian Driver]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Phyrexian Driver]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Caudillo pirexiano]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Phyrexian Driver]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Phyrexian Driver]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[Phyrexian Driver]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Phyrexian Driver]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Phyrexian Driver]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Phyrexian Driver]]></LOCALISED_TEXT>
</TITLE>
<MULTIVERSEID value="22379" />
<ARTID value="CW22379" />
<ARTIST name="Chippy" />
<CASTING_COST cost="{2}{B}" />
<TYPE metaname="Creature" />
<SUB_TYPE metaname="Mercenary" />
<EXPANSION value="NE" />
<RARITY metaname="C" />
<POWER value="1" />
<TOUGHNESS value="1" />
<FLAVOURTEXT>
<LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Although the abuse was initially effective, the troops soon became numb to it.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Although the abuse was initially effective, the troops soon became numb to it.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Aunque el abuso fue inicialmente eficaz, las tropas pronto se volvieron insensibles a él.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Although the abuse was initially effective, the troops soon became numb to it.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Although the abuse was initially effective, the troops soon became numb to it.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[Although the abuse was initially effective, the troops soon became numb to it.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Although the abuse was initially effective, the troops soon became numb to it.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Although the abuse was initially effective, the troops soon became numb to it.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Although the abuse was initially effective, the troops soon became numb to it.]]></LOCALISED_TEXT>
</FLAVOURTEXT>
<TRIGGERED_ABILITY>
<LOCALISED_TEXT LanguageCode="en-US"><![CDATA[When Phyrexian Driver enters the battlefield, other Mercenary creatures get +1/+1 until end of turn.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[When Phyrexian Driver enters the battlefield, other Mercenary creatures get +1/+1 until end of turn.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Cuando el Caudillo pirexiano entre en juego, todos los otros mercenarios obtienen +1/+1 hasta el final del turno]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[When Phyrexian Driver enters the battlefield, other Mercenary creatures get +1/+1 until end of turn.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Quando il Condottiero di Phyrexia entra nel campo di battaglia, tutte le altre creature Mercenario prendono +1/+1 fino alla fine del turno.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[When Phyrexian Driver enters the battlefield, other Mercenary creatures get +1/+1 until end of turn.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[When Phyrexian Driver enters the battlefield, other Mercenary creatures get +1/+1 until end of turn.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[When Phyrexian Driver enters the battlefield, other Mercenary creatures get +1/+1 until end of turn.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[When Phyrexian Driver enters the battlefield, other Mercenary creatures get +1/+1 until end of turn.]]></LOCALISED_TEXT>
<TRIGGER value="ZONECHANGE_END" simple_qualifier="self" to_zone="ZONE_BATTLEFIELD" />
<FILTER filter_id="0">
local filter = ClearFilter()
filter:Add( FE_CARD_INSTANCE, OP_NOT, EffectSource() )
filter:Add( FE_SUBTYPE, OP_IS, CREATURE_TYPE_MERCENARY )
filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
</FILTER>
<CONTINUOUS_ACTION layer="7C" filter_id="0">
if FilteredCard() ~= nil then
local characteristics = FilteredCard():GetCurrentCharacteristics()
characteristics:Power_Add(1)
characteristics:Toughness_Add(1)
end
</CONTINUOUS_ACTION>
<DURATION simple_duration="UntilEOT" />
</TRIGGERED_ABILITY>
<SFX text="COMBAT_BLUNT_LARGE_ATTACK" power_boundary_min="4" power_boundary_max="-1" />
<SFX text="COMBAT_BLUNT_SMALL_ATTACK" power_boundary_min="1" power_boundary_max="3" />
<AI_BASE_SCORE score="150" zone="ZONE_BATTLEFIELD" />
<AUTHOR><![CDATA[cenarius]]></AUTHOR>
<EDITORS><![CDATA[cenarius]]></EDITORS>
<DATE><![CDATA[11-06-15]]></DATE>
</CARD_V2>
All of these are simple mistakes that you'll learn to catch and correct pretty quickly if you keep making cards. I've added your corrected
Phyrexian Driver to the CW.
Posted: 10 Jun 2015, 15:02
Although, I should point out that the VAST majority of all the available cards were made by or made possible by modders who aren't active anymore, not by me.