Collectible Card Game Headquarters

sweetLu wrote:A complete rule compliant Static Orb will be a little complicated. For starters you cannot have the filter for selecting which two permanents to untap set to all permanents. For instance, you cannot untap a creature affected by Frost Breath 's ability. So you would need to filter out any permanent that otherwise would not untap.


Secondly, it would take some work to make it rule compliant with other orb-like cards. For instance if Winter Orb and Static Orb are in play you have to apply both of their restrictions. So possible combinations include up to either 1 land and 1 non-land or 2 non-land permanents. Or more simply if you have 2x Static Orb in play you could only untap 2 permanents. With the quick look of what you have you would be able to untap 4 permanents. The best way to handle multiple orb effects, IMO, would be to use a token manager and have the individual orbs set some values in a game chest depending on the applicable restrictions.



Thirdly, you shouldn't let me talk because I made Winter Orb and didn't account for either of these things besides accounting for multiple copies of Winter Orb . I have a semi-compliant version floating around somewhere if you would like an example.


Edit: to actually answer your question you should be able to add something like this to the return part of the triggered ability:

"and EffectSource():IsTapped() == false"

You could probably get the exact syntax off Trinisphere

cenarius wrote:

Xander9009 wrote:...

Of course i'm going to try it! i'm about to pull my hair off in here man.

But it doesn't work. That, and it seems to have a lot of errors, which i'm trying to fix, just syntaxis errors though. After those fixed, i tested the card and the "stasis" icon appears on the cards, which means the effect is "on" but then when it's my turn it doesn't asks me for untaping permanents, just allows me to target but does nothing, game gets stuck in there, not freeze, just like waiting for me to do somethign but i'm not able to do anything but selecting.

And after that, it throws me this error:

Code: Select all

(RESOLUTION_TIME_ACTION)~0x0000037a"]:7: attempt to call method 'GetStartingPlayer' (a nil value)


I looked into it but it seems that or you got mistaken with the method or forgot to declare it.

And also, about your pervious message, who is this "manager"? i want to speak with him about some seriour business please :p

Translation: I have no idea.

Untested Static Orb code | Open

Code: Select all

   <STATIC_ABILITY linked_ability_group="1">
      <FILTER filter_id="0">
         local NumPlayers = MTG():GetNumberOfStartingPlayers()
         local PlayerID = -1
         for i=0,NumPlayers-1 do
            if MTG():GetNthStartingPlayer(i) ~= nil and MTG():GetNthStartingPlayer(i):MyTurn() then
               PlayerID = i
            end
         end
         if PlayerID &gt;= 0 then
         local filter = ClearFilter()
         filter:Add(FE_TEAM, OP_IS, MTG():GetNthStartingPlayer(PlayerID):GetTeam())
         local subfilter = filter:AddSubFilter_Or()
         subfilter:Add(FE_TYPE, OP_IS, CARD_TYPE_ARTIFACT)
         subfilter:Add(FE_TYPE, OP_IS, CARD_TYPE_CREATURE)
         subfilter:Add(FE_TYPE, OP_IS, CARD_TYPE_ENCHANTMENT)
         subfilter:Add(FE_TYPE, OP_IS, CARD_TYPE_LAND)
         subfilter:Add(FE_TYPE, OP_IS, CARD_TYPE_PLANESWALKER)
      </FILTER>
      <CONTINUOUS_ACTION layer="8" filter_id="0">
         local Card = FilteredCard()
         if Card ~= nil and EffectSource() ~= nil and EffectSource():IsTapped == false then
            local Found = false
            local IgnoreChest = LinkedDC()
            for i=0,3 do
               local IgnoredPlayerChest = IgnoreChest:Get_Chest(i)
               if IgnoredPlayerChest ~= nil then
                  local IgnoredCardZero = IgnoredPlayerChest:Get_CardPtr(0)
                  local IgnoredCardOne = IgnoredPlayerChest:Get_CardPtr(1)
                  if ( (IgnoredCardZero ~= nil and IgnoredCardZero == Card) or (IgnoredCardOne ~= nil and IgnoredCardOne == Card) )
                     Found = true
                  end
               end
            end
            if Found == false then
               Card:GetCurrentCharacteristics():Bool_Set( CHARACTERISTIC_DOESNT_UNTAP, 1 )
            end
         end
      </CONTINUOUS_ACTION>
   </STATIC_ABILITY>
   <TRIGGERED_ABILITY linked_ability_group="1" replacement_effect="1" priority="-10">
      <TRIGGER value="BEGINNING_OF_PLAYERS_STEP" >
         return TriggerPlayer() ~= nil and MTG():GetStep() == STEP_UNTAP and EffectSource() ~= nil and EffectSource():IsTapped == false
      </TRIGGER>
      <RESOLUTION_TIME_ACTION>
         local player = TriggerPlayer()
         local filter = ClearFilter()
         filter:Add(FE_CONTROLLER, OP_IS, player)
         local subfilter = filter:AddSubFilter_Or()
         subfilter:Add(FE_TYPE, OP_IS, CARD_TYPE_ARTIFACT)
         subfilter:Add(FE_TYPE, OP_IS, CARD_TYPE_CREATURE)
         subfilter:Add(FE_TYPE, OP_IS, CARD_TYPE_ENCHANTMENT)
         subfilter:Add(FE_TYPE, OP_IS, CARD_TYPE_LAND)
         subfilter:Add(FE_TYPE, OP_IS, CARD_TYPE_PLANESWALKER)
         local Count = filter:Count()
         if Count &gt; 0 then
            player:SetItemCount(2)
            player:SetItemPrompt( 0, "CARD_QUERY_CHOOSE_PERMANENT_TO_UNTAP" )
            player:SetItemPrompt( 1, "CARD_QUERY_CHOOSE_PERMANENT_TO_UNTAP" )
            player:ChooseItems( EffectDC():Make_Targets(0), QUERY_FLAG_UP_TO )
         end
      </RESOLUTION_TIME_ACTION>
      <RESOLUTION_TIME_ACTION>
         local TargetChest = EffectDC():Get_Targets(0)
         if TriggerPlayer() ~= nil and TargetChest ~= nil then
            local NumPlayers = MTG():GetNumberOfStartingPlayers()
            local PlayerID = -1
            for i=0,NumPlayers-1 do
               if MTG():GetNthStartingPlayer(i) ~= nil and MTG():GetNthStartingPlayer(i) == TriggerPlayer() then
                  PlayerID = i
               end
            end
            if PlayerID &gt;= 0 then
               local IgnoreChest = LinkedDC():Make_Chest(PlayerID)
               local TargetZero = TargetChest:Get_CardPtr(0)
               if TargetZero ~= nil then
                  IgnoreChest:Set_CardPtr(0, TargetZero)
               end
               local TargetOne = TargetChest:Get_CardPtr(1)
               if TargetOne ~= nil then
                  IgnoreChest:Set_CardPtr(1, TargetOne)
               end
            end
         end
      </RESOLUTION_TIME_ACTION>
   </TRIGGERED_ABILITY>

• Ainok Survivalist
• Atarka Efreet
• Guardian Shield-Bearer
• Hidden Dragonslayer
• Kolaghan Stormsinger
• Monastery Loremaster
• Silumgar Assassin
• Silumgar Spell-Eater
• Stratus Dancer

Kithkin wrote:The Community Wad Art folder on GD contains a RETURN_TO_RAVNIVA txt file dated 17.06.2015, but no wad file with that date.

Kithkin wrote:Dominate -- only gains control of creatures with CMC = 0

Code: Select all

 <SPELL_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Return target creature to its owner’s hand. Then return another target creature to its owner’s hand unless its controller pays {1}.]]></LOCALISED_TEXT>
   
<TARGET tag="CARD_QUERY_CHOOSE_CREATURE_TO_PUT_INTO_HAND" definition="0" compartment="0" count="2" />
      <TARGET_DEFINITION id="0">
         local filter = ClearFilter()
         filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
      </TARGET_DEFINITION>
      <RESOLUTION_TIME_ACTION>
      count= 0
         for i = 0,(2-1) do
            local target = EffectDC():Get_Targets(0):Get_CardPtr(i)
               if   count== 0 then
                  if target ~= nil  then
                     target:PutInHand()
                  end
               else
                  if target ~= nil then
                     local controller = target:GetPlayer()
                     if controller ~= nil and controller:CanPayManaCost("{1}") then
                        controller:BeginNewMultipleChoice()
                        controller:AddMultipleChoiceAnswer( "CARD_QUERY_OPTION_PAY_1" )
                        controller:AddMultipleChoiceAnswer( "CARD_QUERY_OPTION_IS_PUT_INTO_HAND" )
                        controller:AskMultipleChoiceQuestion( "CARD_QUERY_MC_WITHDRAW", target )
                           if controller:GetMultipleChoiceResult() == 0 then
                              controller:PayManaCost("{1}")
                           else
                              target:PutInHand()
                           end
                        
                     else
                        target:PutInHand()
                     end
                  end
               end   
               count=count+1
         end
      </RESOLUTION_TIME_ACTION>
</SPELL_ABILITY>


Code: Select all

<TARGET tag="CARD_QUERY_CHOOSE_CREATURE_TO_PUT_INTO_HAND" definition="0" compartment="0" count="2" />
<TARGET_DEFINITION id="0">
  local filter = ClearFilter()
  filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
</TARGET_DEFINITION>
<RESOLUTION_TIME_ACTION>
  local TargetOne = EffectDC():Get_Targets(0):Get_CardPtr(0)
  local TargetTwo = EffectDC():Get_Targets(0):Get_CardPtr(1)
  if TargetOne ~= nil then
    TargetOne:PutInHand()
  end
  if TargetTwo ~= nil then
    local player = TargetTwo:GetPlayer()
    EffectDC():Set_PlayerPtr(1, player)
    player:BeginNewMultipleChoice()
    player:AddMultipleChoiceAnswer( "CARD_QUERY_OPTION_PAY_1" )
    player:AddMultipleChoiceAnswer( "CARD_QUERY_OPTION_IS_PUT_INTO_HAND" )
    player:AskMultipleChoiceQuestion( "CARD_QUERY_MC_WITHDRAW", TargetTwo)
  end
</RESOLUTION_TIME_ACTION>
<RESOLUTION_TIME_ACTION>
  local TargetTwo = EffectDC():Get_Targets(0):Get_CardPtr(1)
  local player = EffectDC():Get_PlayerPtr(1)
  if player ~= nil and TargetTwo ~= nil then
    if player:GetMultipleChoiceResult() == 0 and player:CanPayManaCost("{1}") then
      player:PayManaCost("{1}")
    else
      TargetTwo:PutInHand()
    end
  end
</RESOLUTION_TIME_ACTION>

Xander9009 wrote:Three things I see immediately: you didn't declare count, you just started using it. To declare it so the program knows what it is, you need to put "local" before it the first time you use it; and you can't access a player's choice until the next resolution time action. Move the section that checks the choice and puts the thing in its owner's hand to a new resolution time action. To make this a bit simpler, I'd change it so you have

Code: Select all

<TARGET tag="CARD_QUERY_CHOOSE_CREATURE_TO_PUT_INTO_HAND" definition="0" compartment="0" count="2" />
<TARGET_DEFINITION id="0">
  local filter = ClearFilter()
  filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
</TARGET_DEFINITION>
<RESOLUTION_TIME_ACTION>
  local TargetOne = EffectDC():Get_Targets(0):Get_CardPtr(0)
  local TargetTwo = EffectDC():Get_Targets(0):Get_CardPtr(1)
  if TargetOne ~= nil then
    TargetOne:PutInHand()
  end
  if TargetTwo ~= nil then
    local player = TargetTwo:GetPlayer()
    EffectDC():Set_PlayerPtr(1, player)
    player:BeginNewMultipleChoice()
    player:AddMultipleChoiceAnswer( "CARD_QUERY_OPTION_PAY_1" )
    player:AddMultipleChoiceAnswer( "CARD_QUERY_OPTION_IS_PUT_INTO_HAND" )
    player:AskMultipleChoiceQuestion( "CARD_QUERY_MC_WITHDRAW", TargetTwo)
  end
</RESOLUTION_TIME_ACTION>
<RESOLUTION_TIME_ACTION>
  local TargetTwo = EffectDC():Get_Targets(0):Get_CardPtr(1)
  local player = EffectDC():Get_PlayerPtr(1)
  if player ~= nil and TargetTwo ~= nil then
    if player:GetMultipleChoiceResult() == 0 and player:CanPayManaCost("{1}") then
      player:PayManaCost("{1}")
    else
      TargetTwo:PutInHand()
    end
  end
</RESOLUTION_TIME_ACTION>

The fact that they were in the same RTA is probably why it's not working.

Kithkin wrote:Dominate -- only gains control of creatures with CMC = 0

RiiakShiNal wrote:

Kithkin wrote:Dominate -- only gains control of creatures with CMC = 0

The effect is probably using GetEffectX() instead of EffectSource():GetManaX().

| Open

Code: Select all

   <CASTING_COST cost="{X}{1}{U}{U}" />
   ...
   <SPELL_ABILITY>
      <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Gain control of target creature with converted mana cost X or less.]]></LOCALISED_TEXT>
      ...
      <TARGET tag="CARD_QUERY_CHOOSE_CREATURE_TO_GAIN_CONTROL" definition="0" compartment="0" count="1" />
      <TARGET_DEFINITION id="0">
         local filter = ClearFilter()
         filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
         filter:Add( FE_CMC, OP_LESS_THAN_OR_EQUAL_TO, EffectSource():GetPaidX() )
      </TARGET_DEFINITION>
      <CONTINUOUS_ACTION layer="2">
         local card = EffectDC():Get_Targets(0):Get_CardPtr(0)
         if card ~= nil then
            card:SetController(EffectController())
         end
      </CONTINUOUS_ACTION>
      <DURATION>
         return (EffectDC():Get_Targets(0):Get_CardPtr(0) == nil)
      </DURATION>
   </SPELL_ABILITY>

Xander9009 wrote:I don't see GetManaX() as a function. I see GetEffectX() and GetPaidX(). It's using GetPaidX().

| Open

Code: Select all

   <CASTING_COST cost="{X}{1}{U}{U}" />
   ...
   <SPELL_ABILITY>
      <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Gain control of target creature with converted mana cost X or less.]]></LOCALISED_TEXT>
      ...
      <TARGET tag="CARD_QUERY_CHOOSE_CREATURE_TO_GAIN_CONTROL" definition="0" compartment="0" count="1" />
      <TARGET_DEFINITION id="0">
         local filter = ClearFilter()
         filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
         filter:Add( FE_CMC, OP_LESS_THAN_OR_EQUAL_TO, EffectSource():GetPaidX() )
      </TARGET_DEFINITION>
      <CONTINUOUS_ACTION layer="2">
         local card = EffectDC():Get_Targets(0):Get_CardPtr(0)
         if card ~= nil then
            card:SetController(EffectController())
         end
      </CONTINUOUS_ACTION>
      <DURATION>
         return (EffectDC():Get_Targets(0):Get_CardPtr(0) == nil)
      </DURATION>
   </SPELL_ABILITY>

RiiakShiNal wrote:Here after CounterSpell and before GetBestOrWorstCounterType.

Xander9009 wrote:I fixed that error (because I noticed it) but apparently only corrected my local copy and not the copy in my post. Should be MTG():GetNthStartingPlayer().

Code: Select all

<STATIC_ABILITY linked_ability_group="1">
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[As long as Static Orb is untapped, players can’t untap more than two permanents during their untap steps.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Si l’Orbe statique est dégagée, les joueurs ne peuvent pas dégager plus de deux permanents pendant leur étape de dégagement.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Mientras la Esfera estática esté enderezada, los jugadores no pueden enderezar más de dos permanentes durante su fase de enderezar.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Wenn die Statische Sphäre nicht getappt ist, können Spieler nicht mehr als zwei bleibende Karten während ihres Enttappsegments enttappen.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Se il Globo della Staticità è STAPpato, i giocatori non possono STAPpare più di due permanenti durante il proprio STAP.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[As long as Static Orb is untapped, players can’t untap more than two permanents during their untap steps.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[As long as Static Orb is untapped, players can’t untap more than two permanents during their untap steps.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[As long as Static Orb is untapped, players can’t untap more than two permanents during their untap steps.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[As long as Static Orb is untapped, players can’t untap more than two permanents during their untap steps.]]></LOCALISED_TEXT>
        <FILTER filter_id="0">
             local NumPlayers = MTG():GetNumberOfStartingPlayers()
             local PlayerID = -1
             for i=0,NumPlayers-1 do
                if MTG():GetNthStartingPlayer(i) ~= nil and MTG():GetNthStartingPlayer(i):MyTurn() then
                   PlayerID = i
                end
             end
             if PlayerID &gt;= 0 then
            local filter = ClearFilter()
            filter:Add(FE_TEAM, OP_IS, MTG():GetNthStartingPlayer(PlayerID):GetTeam())
            local subfilter = filter:AddSubFilter_Or()
             subfilter:Add(FE_TYPE, OP_IS, CARD_TYPE_ARTIFACT)
             subfilter:Add(FE_TYPE, OP_IS, CARD_TYPE_CREATURE)
             subfilter:Add(FE_TYPE, OP_IS, CARD_TYPE_ENCHANTMENT)
             subfilter:Add(FE_TYPE, OP_IS, CARD_TYPE_LAND)
             subfilter:Add(FE_TYPE, OP_IS, CARD_TYPE_PLANESWALKER)
          end
          </FILTER>
          <CONTINUOUS_ACTION layer="8" filter_id="0">
             local Card = FilteredCard()
             if Card ~= nil and EffectSource() ~= nil and EffectSource():IsTapped() == false then
                local Found = false
                local IgnoreChest = LinkedDC()
                for i=0,3 do
                   local IgnoredPlayerChest = IgnoreChest:Get_Chest(i)
                   if IgnoredPlayerChest ~= nil then
                      local IgnoredCardZero = IgnoredPlayerChest:Get_CardPtr(0)
                      local IgnoredCardOne = IgnoredPlayerChest:Get_CardPtr(1)
                      if ( (IgnoredCardZero ~= nil and IgnoredCardZero == Card) or (IgnoredCardOne ~= nil and IgnoredCardOne == Card) ) then
                         Found = true
                      end
                   end
                end
                if Found == false then
                   Card:GetCurrentCharacteristics():Bool_Set( CHARACTERISTIC_DOESNT_UNTAP, 1 )
                end
             end
          </CONTINUOUS_ACTION>
</STATIC_ABILITY>
<TRIGGERED_ABILITY linked_ability_group="1" replacement_effect="1" priority="-10">
          <TRIGGER value="BEGINNING_OF_PLAYERS_STEP" >
             return TriggerPlayer() ~= nil and MTG():GetStep() == STEP_UNTAP and EffectSource() ~= nil and EffectSource():IsTapped() == false
          </TRIGGER>
          <RESOLUTION_TIME_ACTION>
             local player = TriggerPlayer()
             local filter = ClearFilter()
             filter:Add(FE_CONTROLLER, OP_IS, player)
             local subfilter = filter:AddSubFilter_Or()
             subfilter:Add(FE_TYPE, OP_IS, CARD_TYPE_ARTIFACT)
             subfilter:Add(FE_TYPE, OP_IS, CARD_TYPE_CREATURE)
             subfilter:Add(FE_TYPE, OP_IS, CARD_TYPE_ENCHANTMENT)
             subfilter:Add(FE_TYPE, OP_IS, CARD_TYPE_LAND)
             subfilter:Add(FE_TYPE, OP_IS, CARD_TYPE_PLANESWALKER)
             local Count = filter:Count()
             if Count &gt; 0 then
                player:SetItemCount(2)
                player:SetItemPrompt( 0, "CARD_QUERY_CHOOSE_PERMANENT_TO_UNTAP" )
                player:SetItemPrompt( 1, "CARD_QUERY_CHOOSE_PERMANENT_TO_UNTAP" )
                player:ChooseItems( EffectDC():Make_Targets(0), QUERY_FLAG_UP_TO )
             end
          </RESOLUTION_TIME_ACTION>
          <RESOLUTION_TIME_ACTION>
             local TargetChest = EffectDC():Get_Targets(0)
             if TriggerPlayer() ~= nil and TargetChest ~= nil then
                local NumPlayers = MTG():GetNumberOfStartingPlayers()
                local PlayerID = -1
                for i=0,NumPlayers-1 do
                   if MTG():GetNthStartingPlayer(i) ~= nil and MTG():GetNthStartingPlayer(i) == TriggerPlayer() then
                      PlayerID = i
                   end
                end
                if PlayerID &gt;= 0 then
                   local IgnoreChest = LinkedDC():Make_Chest(PlayerID)
                   local TargetZero = TargetChest:Get_CardPtr(0)
                   if TargetZero ~= nil then
                      IgnoreChest:Set_CardPtr(0, TargetZero)
                   end
                   local TargetOne = TargetChest:Get_CardPtr(1)
                   if TargetOne ~= nil then
                      IgnoreChest:Set_CardPtr(1, TargetOne)
                   end
                end
             end
          </RESOLUTION_TIME_ACTION>
</TRIGGERED_ABILITY>


RiiakShiNal wrote:

Xander9009 wrote:I don't see GetManaX() as a function. I see GetEffectX() and GetPaidX(). It's using GetPaidX().
...

Here after CounterSpell and before GetBestOrWorstCounterType.