valorous stance

[nivmizzet1]

can someone help me code the spell ability for Valorous Stance?

Code: Select all

  <SPELL_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Choose one — Target creature gains indestructible until end of turn; or destroy target creature with toughness 4 or greater.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Choisissez l’un — La créature ciblée acquiert l’indestructible jusqu’à la fin du tour; or détruisez une créature ciblée d’endurance supérieure ou égale à 4]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Elige uno: La criatura objetivo gana la habilidad de indestructible hasta el final del turno; or estruye la criatura objetivo con resistencia de 4 o más.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Bestimme eines — Eine Kreatur deiner Wahl erhält Unzerstörbarkeit bis zum Ende des Zuges; or zerstöre eine Kreatur deiner Wahl mit Widerstandskraft 4 oder mehr.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Scegli uno - Una creatura bersaglio ha indistruttibile fino alla fine del turno; or distruggi una creatura bersaglio con costituzione pari o superiore a 4.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[以下から１つを選ぶ。クリーチャー１体を対象とする。ターン終了時までそれは破壊不能を得る。 タフネスが４以上のクリーチャー１体を対象とし、それを破壊する。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[하나를 선택한다 — 생물을 목표로 정한다. 그 생물은 턴종료까지 무적을 얻는다. 방어력이 4 이상인 생물을 목표로 정한다. 그 생물을 파괴한다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Выберите одно — Целевое существо получает Неразрушимость до конца хода. Уничтожьте целевое существо с выносливостью 4 или больше.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Escolha um — A criatura alvo ganha indestrutível até o final do turno; or destrua a criatura alvo com resistência igual ou superior a 4.]]></LOCALISED_TEXT>
      <MODE_SELECT tag="MODE_CHOOSE_ONE">
         <MODE tag="MODE_VALOROUS_INDESTRUCTIBLE" index="1" />
         <MODE tag="MODE_VALOROUS_DESTROY_CREATURE" index="2" />
      </MODE_SELECT>

      <TARGET tag="CARD_QUERY_CHOOSE_CREATURE_IS_INDESTRUCTIBLE" definition="0" compartment="1" mode="1" count="1" />
    <TARGET_DEFINITION id="0">
    local filter = ClearFilter()
    filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
    </TARGET_DEFINITION>
    <CONTINUOUS_ACTION layer="6" filter_id="0" mode="1">
    local target = EffectDC():Get_Targets():Get_CardPtr(0)
    if target ~= nil then
       local characteristics = target:GetCurrentCharacteristics()
       characteristics:Bool_Set( CHARACTERISTIC_INDESTRUCTIBLE, 1 )
    end
    </CONTINUOUS_ACTION>
      <DURATION simple_duration="UntilEOT" />
      
   <TARGET tag="CARD_QUERY_CHOOSE_CREATURE_TO_DESTROY" definition="1" compartment="0" mode="2" count="1" />
      <TARGET_DEFINITION id="1">
         local filter = ClearFilter()
         filter:Add(FE_TYPE, OP_IS, CARD_TYPE_CREATURE)
         filter:Add(FE_POWER, OP_GREATER_THAN_OR_EQUAL_TO, 4)
      </TARGET_DEFINITION>
      <RESOLUTION_TIME_ACTION mode="2">
         local target = EffectDC():Get_Targets():Get_CardPtr(0)
         if target ~= nil then
            target:Destroy()
         end
      </RESOLUTION_TIME_ACTION>
      
      <AI_SIMPLIFIED_TARGETING compartment="0" hint="HINT_ENEMY_ONLY" />
      <AI_SIMPLIFIED_TARGETING compartment="1" hint="HINT_ALLIED_ONLY" />
      </SPELL_ABILITY>

With this code I get prompted for the mode selection, and I'm pretty sure this step works as it then goes to the appropriate target selection, but the resolution time action always fails (i.e. either giving a creature indestructible or destroying a creature with toughness 4 or more does not happen).

[Tejahn]

nivmizzet1, I already made Valorous Stance in the Fate Reforged set but I'm away from my laptop at the moment. I won't be returning home until tomorrow but I suspect someone will have provided you the code before then. If not, I'll post the XML for you tomorrow.

[RiiakShiNal]

Your Get_Targets() calls are missing the compartment numbers.

So for example for the indestructible call it should be:

Code: Select all

local target = EffectDC():Get_Targets(1):Get_CardPtr(0)

[nivmizzet1]

Your Get_Targets() calls are missing the compartment numbers.

So for example for the indestructible call it should be:

Code: Select all

local target = EffectDC():Get_Targets(1):Get_CardPtr(0)

I know next to nothing about coding, but looking at other code I thought compartment numbers may go in there; I actually had them there in an old version. But isn't that only relevant for the AI? Either way, I changed it and the actions still aren't working.

[nivmizzet1]

nivmizzet1, I already made Valorous Stance in the Fate Reforged set but I'm away from my laptop at the moment. I won't be returning home until tomorrow but I suspect someone will have provided you the code before then. If not, I'll post the XML for you tomorrow.

I did a search and saw that you'd coded it, but not released it. Unfortunately, that doesn't help me

That would be awesome if you post it when you're home, provided nobody provides the code first

[Tejahn]

I'll be sure to post it. But hopefully someone will provide the entire code before I make it back.

[RiiakShiNal]

I know next to nothing about coding, but looking at other code I thought compartment numbers may go in there; I actually had them there in an old version. But isn't that only relevant for the AI? Either way, I changed it and the actions still aren't working.

After you added the compartment numbers was it generating a script log? (It would definitely generate a script log without them.)

[nivmizzet1]

I know next to nothing about coding, but looking at other code I thought compartment numbers may go in there; I actually had them there in an old version. But isn't that only relevant for the AI? Either way, I changed it and the actions still aren't working.

After you added the compartment numbers was it generating a script log? (It would definitely generate a script log without them.)

No script log (EDIT: also no script log without the compartment numbers). EDIT2: It's weird though, I don't even get a script log when I use a deck that I know crashes the game

[Tejahn]

nivmizzet1, I'm not sure if you already have the code but below is the one I use. If you did go ahead and create this card post the post so I can comparitively study it's structure as well.

Valorous Stance

Code: Select all

<?xml version="1.0"?>
<CARD_V2 ExportVersion="1">
  <FILENAME text="TEJAHN_FRF_VALOROUS_STANCE_100391950" />
  <CARDNAME text="VALOROUS_STANCE" />
  <TITLE>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Valorous Stance]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Posture valeureuse]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Postura valerosa]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Tapfere Haltung]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Posizione Valorosa]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[勇敢な姿勢]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[대담한 태세]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Доблестная Стойка]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Postura Valente]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-CN"><![CDATA[英勇以对]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-HK"><![CDATA[英勇以對]]></LOCALISED_TEXT>
  </TITLE>
  <MULTIVERSEID value="100391950" />
  <ARTID value="100391950" />
  <ARTIST name="Willian Murai" />
  <CASTING_COST cost="{1}{W}" />
  <FLAVOURTEXT>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[“Every choice alters the path of fate.”]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[« Chaque décision modifie le cours du destin. »]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[“Cada elección altera la senda del destino”.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[„Jede Entscheidung beeinflusst den Pfad des Schicksals.”]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[“Ogni scelta modifica il corso del fato.”]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[「すべての選択は、運命の道筋を変える。」]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[“모든 선택은 운명의 길을 바꾼다.”]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[«Каждый сделанный выбор меняет путь судьбы».]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[“Toda escolha altera o caminho do destino.”]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-CN"><![CDATA[「每个选择都会影响命途走向。」]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-HK"><![CDATA[「每個選擇都會影響命途走向。」]]></LOCALISED_TEXT>
  </FLAVOURTEXT>
  <TYPE metaname="Instant" />
  <EXPANSION value="FRF" />
  <RARITY metaname="U" />
  <SPELL_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Choose one —]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Choisissez l’un —]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Elige uno:]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Bestimme eines —]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Scegli uno —]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[以下から１つを選ぶ。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[하나를 선택한다 —]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Выберите одно —]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Escolha um —]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-CN"><![CDATA[选择一项～]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-HK"><![CDATA[選擇一項～]]></LOCALISED_TEXT>
   <SFX text="TARGET_WHITE_MAGIC_PLAY" />
   <MODE_SELECT tag="MODE_CHOOSE_ONE">
      <MODE tag="MODE_CARD_QUERY_VALOROUS_STANCE_TARGET_CREATURE_GAINS_INDESTRUCTIBLE_UNTIL_END_OF_TURN" index="1" />
      <MODE tag="MODE_CARD_QUERY_VALOROUS_STANCE_DESTROY_TARGET_CREATURE_WITH_TOUGHNESS_FOUR_OR_GREATER" index="2" />
   </MODE_SELECT>
   <TARGET tag="CARD_QUERY_VALOROUS_STANCE_CHOOSE_A_TARGET_CREATURE_TO_GAIN_INDESTRUCTIBLE" definition="0" compartment="0" mode="1" count="1" />
   <TARGET_DEFINITION id="0">
    local filter = ClearFilter()
    filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
    </TARGET_DEFINITION>
   <CONTINUOUS_ACTION layer="6" mode="1">
    local target = EffectDC():Get_Targets(1):Get_CardPtr(0)
    if target ~= nil then
       local characteristics = target:GetCurrentCharacteristics()
       characteristics:Bool_Set( CHARACTERISTIC_INDESTRUCTIBLE 1 )
    end
    </CONTINUOUS_ACTION>
   <SFX text="TARGET_WHITE_MAGIC_PLAY" />
   <DURATION simple_duration="UntilEOT" />
   <TARGET tag="CARD_QUERY_VALOROUS_STANCE_CHOOSE_A_TARGET_CREATURE_TO_GAIN_INDESTRUCTIBLE" definition="1" compartment="1" mode="2" count="1" />
   <TARGET_DEFINITION id="1">
    local filter = ClearFilter()
    filter:Add(FE_TYPE, OP_IS, CARD_TYPE_CREATURE)
    filter:Add(FE_TOUGHNESS, OP_GREATER_THAN_OR_EQUAL_TO, 4)
    </TARGET_DEFINITION>
   <RESOLUTION_TIME_ACTION mode="2">
    local target = EffectDC():Get_Targets(1):Get_CardPtr(0)
    if target ~= nil then
       target:Destroy()
    end
    </RESOLUTION_TIME_ACTION>
         <SFX text="TARGET_BLADE_PLAY" />
   <AI_SIMPLIFIED_TARGETING compartment="0" hint="HINT_ENEMY_ONLY" />
   <AI_SIMPLIFIED_TARGETING compartment="1" hint="HINT_ALLIED_ONLY" />
      </SPELL_ABILITY>
  <SPELL_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[• Target creature gains indestructible until end of turn.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[• La créature ciblée acquiert l’indestructible jusqu’à la fin du tour.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[• La criatura objetivo gana la habilidad de indestructible hasta el final del turno.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[• Eine Kreatur deiner Wahl erhält Unzerstörbarkeit bis zum Ende des Zuges.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[• Una creatura bersaglio ha indistruttibile fino alla fine del turno.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[• クリーチャー１体を対象とする。ターン終了時までそれは破壊不能を得る。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[• 생물을 목표로 정한다. 그 생물은 턴종료까지 무적을 얻는다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[• Целевое существо получает Неразрушимость до конца хода.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[• A criatura alvo ganha indestrutível até o final do turno.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-CN"><![CDATA[● 目标生物获得不灭异能直到回合结束。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-HK"><![CDATA[• 目標生物獲得不滅異能直到回合結束。]]></LOCALISED_TEXT>
  </SPELL_ABILITY>
  <SPELL_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[• Destroy target creature with toughness 4 or greater.

|"Every choice alters the path of fate."
—Sarkhan Vol|]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[• Détruisez une créature ciblée d’endurance supérieure ou égale à 4.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[• Destruye la criatura objetivo con resistencia de 4 o más.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[• Zerstöre eine Kreatur deiner Wahl mit Widerstandskraft 4 oder mehr.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[• Distruggi una creatura bersaglio con costituzione pari o superiore a 4.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[• タフネスが４以上のクリーチャー１体を対象とし、それを破壊する。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[• 방어력이 4 이상인 생물을 목표로 정한다. 그 생물을 파괴한다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[• Уничтожьте целевое существо с выносливостью 4 или больше.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[• Destrua a criatura alvo com resistência igual ou superior a 4.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-CN"><![CDATA[● 消灭目标防御力等于或大于4的生物。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-HK"><![CDATA[• 消滅目標防禦力等於或大於4的生物。]]></LOCALISED_TEXT>
  </SPELL_ABILITY>
  <AI_AVAILABILITY window_step="main_1" window_turn="my_turn" type="window" />
  <AI_AVAILABILITY window_step="begin_combat" window_turn="their_turn" type="window" />
  <AI_AVAILABILITY window_step="declare_attackers" window_turn="their_turn" type="window" />
  <AI_AVAILABILITY window_step="end_of_turn" type="window" />
  <AI_AVAILABILITY type="in_response" response_source="1" />
  <AI_AVAILABILITY window_step="begin_combat" window_turn="their_turn" type="window" />
  <AI_AVAILABILITY window_step="declare_attackers" window_turn="their_turn" type="window" />
  <AI_AVAILABILITY window_step="main_1" window_turn="my_turn" type="window" />
  <AI_AVAILABILITY window_step="declare_blockers" type="window" />
  <AI_AVAILABILITY window_step="end_of_turn" type="window" />
  <AI_AVAILABILITY type="in_response" response_source="1" response_target="1" />
  <AI_AVAILABILITY window_step="declare_blockers" type="window" />
  <AI_AVAILABILITY type="in_response" response_target="1" />
  <AI_AVAILABILITY type="in_response" response_source="1" />
  <HELP title="MORE_INFO_BADGE_TITLE_2" body="MORE_INFO_BADGE_BODY_2" zone="ZONE_ANY" />
  <HELP title="MORE_INFO_BADGE_TITLE_8" body="MORE_INFO_BADGE_BODY_8" zone="ZONE_ANY" />
  <AI_BASE_SCORE score="900" zone="ZONE_HAND" />
</CARD_V2>

[nivmizzet1]

nivmizzet1, I'm not sure if you already have the code but below is the one I use. If you did go ahead and create this card post the post so I can comparitively study it's structure as well.

Valorous Stance

Code: Select all

<?xml version="1.0"?>
<CARD_V2 ExportVersion="1">
  <FILENAME text="TEJAHN_FRF_VALOROUS_STANCE_100391950" />
  <CARDNAME text="VALOROUS_STANCE" />
  <TITLE>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Valorous Stance]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Posture valeureuse]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Postura valerosa]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Tapfere Haltung]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Posizione Valorosa]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[勇敢な姿勢]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[대담한 태세]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Доблестная Стойка]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Postura Valente]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-CN"><![CDATA[英勇以对]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-HK"><![CDATA[英勇以對]]></LOCALISED_TEXT>
  </TITLE>
  <MULTIVERSEID value="100391950" />
  <ARTID value="100391950" />
  <ARTIST name="Willian Murai" />
  <CASTING_COST cost="{1}{W}" />
  <FLAVOURTEXT>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[“Every choice alters the path of fate.”]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[« Chaque décision modifie le cours du destin. »]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[“Cada elección altera la senda del destino”.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[„Jede Entscheidung beeinflusst den Pfad des Schicksals.”]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[“Ogni scelta modifica il corso del fato.”]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[「すべての選択は、運命の道筋を変える。」]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[“모든 선택은 운명의 길을 바꾼다.”]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[«Каждый сделанный выбор меняет путь судьбы».]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[“Toda escolha altera o caminho do destino.”]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-CN"><![CDATA[「每个选择都会影响命途走向。」]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-HK"><![CDATA[「每個選擇都會影響命途走向。」]]></LOCALISED_TEXT>
  </FLAVOURTEXT>
  <TYPE metaname="Instant" />
  <EXPANSION value="FRF" />
  <RARITY metaname="U" />
  <SPELL_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Choose one —]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Choisissez l’un —]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Elige uno:]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Bestimme eines —]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Scegli uno —]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[以下から１つを選ぶ。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[하나를 선택한다 —]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Выберите одно —]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Escolha um —]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-CN"><![CDATA[选择一项～]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-HK"><![CDATA[選擇一項～]]></LOCALISED_TEXT>
   <SFX text="TARGET_WHITE_MAGIC_PLAY" />
   <MODE_SELECT tag="MODE_CHOOSE_ONE">
      <MODE tag="MODE_CARD_QUERY_VALOROUS_STANCE_TARGET_CREATURE_GAINS_INDESTRUCTIBLE_UNTIL_END_OF_TURN" index="1" />
      <MODE tag="MODE_CARD_QUERY_VALOROUS_STANCE_DESTROY_TARGET_CREATURE_WITH_TOUGHNESS_FOUR_OR_GREATER" index="2" />
   </MODE_SELECT>
   <TARGET tag="CARD_QUERY_VALOROUS_STANCE_CHOOSE_A_TARGET_CREATURE_TO_GAIN_INDESTRUCTIBLE" definition="0" compartment="0" mode="1" count="1" />
   <TARGET_DEFINITION id="0">
    local filter = ClearFilter()
    filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
    </TARGET_DEFINITION>
   <CONTINUOUS_ACTION layer="6" mode="1">
    local target = EffectDC():Get_Targets(1):Get_CardPtr(0)
    if target ~= nil then
       local characteristics = target:GetCurrentCharacteristics()
       characteristics:Bool_Set( CHARACTERISTIC_INDESTRUCTIBLE 1 )
    end
    </CONTINUOUS_ACTION>
   <SFX text="TARGET_WHITE_MAGIC_PLAY" />
   <DURATION simple_duration="UntilEOT" />
   <TARGET tag="CARD_QUERY_VALOROUS_STANCE_CHOOSE_A_TARGET_CREATURE_TO_GAIN_INDESTRUCTIBLE" definition="1" compartment="1" mode="2" count="1" />
   <TARGET_DEFINITION id="1">
    local filter = ClearFilter()
    filter:Add(FE_TYPE, OP_IS, CARD_TYPE_CREATURE)
    filter:Add(FE_TOUGHNESS, OP_GREATER_THAN_OR_EQUAL_TO, 4)
    </TARGET_DEFINITION>
   <RESOLUTION_TIME_ACTION mode="2">
    local target = EffectDC():Get_Targets(1):Get_CardPtr(0)
    if target ~= nil then
       target:Destroy()
    end
    </RESOLUTION_TIME_ACTION>
         <SFX text="TARGET_BLADE_PLAY" />
   <AI_SIMPLIFIED_TARGETING compartment="0" hint="HINT_ENEMY_ONLY" />
   <AI_SIMPLIFIED_TARGETING compartment="1" hint="HINT_ALLIED_ONLY" />
      </SPELL_ABILITY>
  <SPELL_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[• Target creature gains indestructible until end of turn.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[• La créature ciblée acquiert l’indestructible jusqu’à la fin du tour.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[• La criatura objetivo gana la habilidad de indestructible hasta el final del turno.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[• Eine Kreatur deiner Wahl erhält Unzerstörbarkeit bis zum Ende des Zuges.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[• Una creatura bersaglio ha indistruttibile fino alla fine del turno.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[• クリーチャー１体を対象とする。ターン終了時までそれは破壊不能を得る。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[• 생물을 목표로 정한다. 그 생물은 턴종료까지 무적을 얻는다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[• Целевое существо получает Неразрушимость до конца хода.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[• A criatura alvo ganha indestrutível até o final do turno.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-CN"><![CDATA[● 目标生物获得不灭异能直到回合结束。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-HK"><![CDATA[• 目標生物獲得不滅異能直到回合結束。]]></LOCALISED_TEXT>
  </SPELL_ABILITY>
  <SPELL_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[• Destroy target creature with toughness 4 or greater.

|"Every choice alters the path of fate."
—Sarkhan Vol|]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[• Détruisez une créature ciblée d’endurance supérieure ou égale à 4.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[• Destruye la criatura objetivo con resistencia de 4 o más.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[• Zerstöre eine Kreatur deiner Wahl mit Widerstandskraft 4 oder mehr.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[• Distruggi una creatura bersaglio con costituzione pari o superiore a 4.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[• タフネスが４以上のクリーチャー１体を対象とし、それを破壊する。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[• 방어력이 4 이상인 생물을 목표로 정한다. 그 생물을 파괴한다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[• Уничтожьте целевое существо с выносливостью 4 или больше.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[• Destrua a criatura alvo com resistência igual ou superior a 4.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-CN"><![CDATA[● 消灭目标防御力等于或大于4的生物。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="zh-HK"><![CDATA[• 消滅目標防禦力等於或大於4的生物。]]></LOCALISED_TEXT>
  </SPELL_ABILITY>
  <AI_AVAILABILITY window_step="main_1" window_turn="my_turn" type="window" />
  <AI_AVAILABILITY window_step="begin_combat" window_turn="their_turn" type="window" />
  <AI_AVAILABILITY window_step="declare_attackers" window_turn="their_turn" type="window" />
  <AI_AVAILABILITY window_step="end_of_turn" type="window" />
  <AI_AVAILABILITY type="in_response" response_source="1" />
  <AI_AVAILABILITY window_step="begin_combat" window_turn="their_turn" type="window" />
  <AI_AVAILABILITY window_step="declare_attackers" window_turn="their_turn" type="window" />
  <AI_AVAILABILITY window_step="main_1" window_turn="my_turn" type="window" />
  <AI_AVAILABILITY window_step="declare_blockers" type="window" />
  <AI_AVAILABILITY window_step="end_of_turn" type="window" />
  <AI_AVAILABILITY type="in_response" response_source="1" response_target="1" />
  <AI_AVAILABILITY window_step="declare_blockers" type="window" />
  <AI_AVAILABILITY type="in_response" response_target="1" />
  <AI_AVAILABILITY type="in_response" response_source="1" />
  <HELP title="MORE_INFO_BADGE_TITLE_2" body="MORE_INFO_BADGE_BODY_2" zone="ZONE_ANY" />
  <HELP title="MORE_INFO_BADGE_TITLE_8" body="MORE_INFO_BADGE_BODY_8" zone="ZONE_ANY" />
  <AI_BASE_SCORE score="900" zone="ZONE_HAND" />
</CARD_V2>

I can already see some problems in your code Tejahn, are you sure you tested it?

You have the tag for indestructible for both effects (i.e. you have the indestuctible tag for destroy creature ability). You also have the target for the destroy creature ability as "ALLIED ONLY". Other than that, with the exception of the added SFX in your code, our codes are virtually identical, so I really can't see why yours would work but mine won't.

EDIT: and I just realised mine was defining targets as creatures with power over 4, not toughness.

[nivmizzet1]

OK. I finally got it working

It didn't like that I had the duration following the first ability and before the second (which logically I guess are part of a single ability, which is why it doesn't like it).

here is my final code:

Code: Select all

<?xml version='1.0' encoding='UTF-8'?>
<CARD_V2 ExportVersion="1">
  <FILENAME text="VALOROUS_STANCE_SM_399105" />
  <CARDNAME text="VALOROUS_STANCE" />
  <TITLE>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Valorous Stance]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Posture valeureuse]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Postura valerosa]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Tapfere Haltung]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Posizione Valorosa]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[勇敢な姿勢]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[대담한 태세]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Доблестная Стойка]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Postura Valente]]></LOCALISED_TEXT>
  </TITLE>
  <MULTIVERSEID value="399105" />
  <ARTID value="SM399105" />
  <ARTIST name="Willian Murai" />
  <CASTING_COST cost="{1}{W}" />
  <FLAVOURTEXT>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[“Every choice alters the path of fate.”
—Sarkhan Vol]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[« Chaque décision modifie le cours du destin. »
—Sarkhan Vol]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[“Cada elección altera la senda del destino”.
—Sarkhan Vol]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[„Jede Entscheidung beeinflusst den Pfad des Schicksals.”
—Sarkhan Vol]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[“Ogni scelta modifica il corso del fato.”
—Sarkhan Vol]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[「すべての選択は、運命の道筋を変える。」
――サルカン・ヴォル]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[“모든 선택은 운명의 길을 바꾼다.”
—사르칸 볼]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[«Каждый сделанный выбор меняет путь судьбы».
— Сархан Воль]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[“Toda escolha altera o caminho do destino.”
— Sarkhan Vol]]></LOCALISED_TEXT>
  </FLAVOURTEXT>
  <TYPE metaname="Instant" />
  <EXPANSION value="FRF" />
  <RARITY metaname="U" />
  <SPELL_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Choose one — Target creature gains indestructible until end of turn; or destroy target creature with toughness 4 or greater.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Choisissez l’un — La créature ciblée acquiert l’indestructible jusqu’à la fin du tour; or détruisez une créature ciblée d’endurance supérieure ou égale à 4]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Elige uno: La criatura objetivo gana la habilidad de indestructible hasta el final del turno; or estruye la criatura objetivo con resistencia de 4 o más.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Bestimme eines — Eine Kreatur deiner Wahl erhält Unzerstörbarkeit bis zum Ende des Zuges; or zerstöre eine Kreatur deiner Wahl mit Widerstandskraft 4 oder mehr.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Scegli uno - Una creatura bersaglio ha indistruttibile fino alla fine del turno; or distruggi una creatura bersaglio con costituzione pari o superiore a 4.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[以下から１つを選ぶ。クリーチャー１体を対象とする。ターン終了時までそれは破壊不能を得る。 タフネスが４以上のクリーチャー１体を対象とし、それを破壊する。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[하나를 선택한다 — 생물을 목표로 정한다. 그 생물은 턴종료까지 무적을 얻는다. 방어력이 4 이상인 생물을 목표로 정한다. 그 생물을 파괴한다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Выберите одно — Целевое существо получает Неразрушимость до конца хода. Уничтожьте целевое существо с выносливостью 4 или больше.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Escolha um — A criatura alvo ganha indestrutível até o final do turno; or destrua a criatura alvo com resistência igual ou superior a 4.]]></LOCALISED_TEXT>
      <SFX text="TARGET_WHITE_MAGIC_PLAY" />
      <MODE_SELECT tag="MODE_CHOOSE_ONE">
         <MODE tag="MODE_VALOROUS_INDESTRUCTIBLE" index="1" />
         <MODE tag="MODE_VALOROUS_DESTROY_CREATURE" index="2" />
      </MODE_SELECT>

      <TARGET tag="CARD_QUERY_CHOOSE_CREATURE_IS_INDESTRUCTIBLE" definition="0" compartment="1" mode="1" count="1" />
    <TARGET_DEFINITION id="0">
    local filter = ClearFilter()
    filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
    </TARGET_DEFINITION>
    <CONTINUOUS_ACTION layer="6" mode="1">
    local target = EffectDC():Get_Targets(1):Get_CardPtr(0)
    if target ~= nil then
       local characteristics = target:GetCurrentCharacteristics()
       characteristics:Bool_Set( CHARACTERISTIC_INDESTRUCTIBLE, 1 )
    end
    </CONTINUOUS_ACTION>
      
   <TARGET tag="CARD_QUERY_CHOOSE_CREATURE_TO_DESTROY" definition="1" compartment="0" mode="2" count="1" />
      <TARGET_DEFINITION id="1">
         local filter = ClearFilter()
         filter:Add(FE_TYPE, OP_IS, CARD_TYPE_CREATURE)
         filter:Add(FE_TOUGHNESS, OP_GREATER_THAN_OR_EQUAL_TO, 4)
      </TARGET_DEFINITION>
      <RESOLUTION_TIME_ACTION mode="2">
         local target = EffectDC():Get_Targets(0):Get_CardPtr(0)
         if target ~= nil then
            target:Destroy()
         end
      </RESOLUTION_TIME_ACTION>
      
      <DURATION simple_duration="UntilEOT" />
      <AI_SIMPLIFIED_TARGETING compartment="0" hint="HINT_ENEMY_ONLY" />
      <AI_SIMPLIFIED_TARGETING compartment="1" hint="HINT_ALLIED_ONLY" />
      </SPELL_ABILITY>
      
   <AI_AVAILABILITY type="in_response" response_source="1" />
   <AI_AVAILABILITY window_step="main_2" window_turn="my_turn" type="window" />
   <AI_AVAILABILITY window_step="begin_combat" window_turn="their_turn" type="window" />
   <AI_AVAILABILITY window_step="declare_attackers" window_turn="their_turn" type="window" />
   <AI_AVAILABILITY window_step="declare_blockers" type="window" />
   <AI_AVAILABILITY window_step="end_of_turn" type="window" />
   <AI_AVAILABILITY type="in_response" response_source="1" response_target="1" />
   <HELP title="MORE_INFO_BADGE_TITLE_4" body="MORE_INFO_BADGE_BODY_4" zone="ZONE_ANY" />
   <AI_BASE_SCORE score="900" zone="ZONE_HAND" />
   
   <AUTHOR><![CDATA[NivMizzet1]]></AUTHOR>
   <EDITORS><![CDATA[NivMizzet1]]></EDITORS>
   <DATE><![CDATA[11-02-15]]></DATE>
   </CARD_V2>

[Tejahn]

A thousand pardons. I posted the code fot the XML before I went back and corrected errors. Your post prompted me to delete that development folder. Either way, I'm glad you completed it. Can I look forward to downloading some new decks from you?

[nivmizzet1]

A thousand pardons. I posted the code fot the XML before I went back and corrected errors. Your post prompted me to delete that development folder. Either way, I'm glad you completed it. Can I look forward to downloading some new decks from you?

Maybe it's best if I say you shouldn't. When DOTP 2014 was released I planned not to do a release, and I toned down my modding quite a lot, as it was all taking too much of my time. I only recently came back to modding, and DOTP 2014, when I got a craving for DOTP, after not purchasing DOTP 2015 because it abandoned the pre-constructed decks that I liked so much about the DOTP franchise. So I started out just making one or two fun decks to play to pass the time, but it quickly, as it often does, became a good dozen or so decks (I think it's around 20 now) -- getting close to being worthwhile for a release. However, there are still some bugs in cards that I'm trying to iron out, and the game is crashing with some decks for no apparent reason (I think I came close to locating the problem in one particular case, but nobody on here seems to be able to help me and I'm not qualified to solve it on my own), and I wouldn't be happy releasing until these problems were fixed, which may never happen; I also haven't been as careful with my balancing of these decks, and some are purely for myself/friends, with unofficial mtg cards, so with those decks removed the number of decks for release are diminishing (although I'm sure there's ways I could modify these decks, but that's more work). I have considered doing a future release, but the effort required for that is a bit daunting for me at this stage. The fact that 2014 is so old now and the audience is so diminished also makes me wonder if it's worth my time to go to the effort required for releasing them. So I guess only time will tell.

[Kithkin]

A thousand pardons. I posted the code fot the XML before I went back and corrected errors. Your post prompted me to delete that development folder. Either way, I'm glad you completed it. Can I look forward to downloading some new decks from you?

Maybe it's best if I say you shouldn't. When DOTP 2014 was released I planned not to do a release, and I toned down my modding quite a lot, as it was all taking too much of my time. I only recently came back to modding, and DOTP 2014, when I got a craving for DOTP, after not purchasing DOTP 2015 because it abandoned the pre-constructed decks that I liked so much about the DOTP franchise. So I started out just making one or two fun decks to play to pass the time, but it quickly, as it often does, became a good dozen or so decks (I think it's around 20 now) -- getting close to being worthwhile for a release. However, there are still some bugs in cards that I'm trying to iron out, and the game is crashing with some decks for no apparent reason (I think I came close to locating the problem in one particular case, but nobody on here seems to be able to help me and I'm not qualified to solve it on my own), and I wouldn't be happy releasing until these problems were fixed, which may never happen; I also haven't been as careful with my balancing of these decks, and some are purely for myself/friends, with unofficial mtg cards, so with those decks removed the number of decks for release are diminishing (although I'm sure there's ways I could modify these decks, but that's more work). I have considered doing a future release, but the effort required for that is a bit daunting for me at this stage. The fact that 2014 is so old now and the audience is so diminished also makes me wonder if it's worth my time to go to the effort required for releasing them. So I guess only time will tell.

Well, I would be very much interested in your decks. But as you said, general interest does not seem to be very high. I estimate 5 people. The community may prove me wrong.

[Tejahn]

I understand. Thanks for the explanation.