Hour of Devastation development -- 176/186 uploaded

[Xander9009]

I've modified both Nicol Bolas, God-Pharaoh and Nicol Bolas the Deceiver.

Nicol Bolas, God-Pharaoh:

• +2 ability wasn't working. It was calling the function to grant the utility cast ability but didn't actually have the cast ability, so didn't do anything. I also made it so the card that can be cast is nailed onto it so it's easier to see and access. It goes back to the exile zone area when its utility cast ability expires at the end of the turn.
• -4 ability was using EffectSource() to deal damage instead of EffectSourceLKI().

Nicol Bolas the Deceiver:

• +3 ability was completely replaced with the code I made for Torment of Hailfire. It wasn't working, and I could have debugged it instead of just replacing, but I was feeling lazy, and I knew for sure the hailfire code worked, since I'd already tested it a bunch. I did however, make sure to keep the same text permanent tags.
• -11 ability, like the other planeswalker's -4 ability, was using EffectSource() instead of EffectSourceLKI() to deal damage. This is important because it means that if you activate this ability while it has exactly 11 coutners (or activate the other while it has 4) then it'll go to the graveyard and be nil by the time it tries to deal damage, meaning no damage is dealt.

[Splinterverse]

I've modified both Nicol Bolas, God-Pharaoh and Nicol Bolas the Deceiver.

Nicol Bolas, God-Pharaoh:

• +2 ability wasn't working. It was calling the function to grant the utility cast ability but didn't actually have the cast ability, so didn't do anything. I also made it so the card that can be cast is nailed onto it so it's easier to see and access. It goes back to the exile zone area when its utility cast ability expires at the end of the turn.
• -4 ability was using EffectSource() to deal damage instead of EffectSourceLKI().

Nicol Bolas the Deceiver:

• +3 ability was completely replaced with the code I made for Torment of Hailfire. It wasn't working, and I could have debugged it instead of just replacing, but I was feeling lazy, and I knew for sure the hailfire code worked, since I'd already tested it a bunch. I did however, make sure to keep the same text permanent tags.
• -11 ability, like the other planeswalker's -4 ability, was using EffectSource() instead of EffectSourceLKI() to deal damage. This is important because it means that if you activate this ability while it has exactly 11 coutners (or activate the other while it has 4) then it'll go to the graveyard and be nil by the time it tries to deal damage, meaning no damage is dealt.

Thanks for the creating the triggers and characteristics, Xander. Much appreciated.

Thanks for fixing the above as well. Oddly the abilities you cite as not working worked for me in testing. It could be that once they were added to the PLW lol file something changed.

[Splinterverse]

I have finished coding for today. Will be coding again tomorrow morning.

OP updated.

Art has been added for all of the newly spoiled cards, including HQ for Open Fire.

Coded and uploaded but NOT tested:
Bloodwater Entity
Crested Sunmare + token
Eternal of Harsh Truths
Frontline Devasator
God-Pharaoh's Faithful
Hazoret's Undying Fury
Hour of Eternity
Kefnet's Last Word -- was coded using Bontu's Last Reckoning land tap code
Majestic Myriarch

In progress:
Vizier of the Anointed

I have no plans to code Abandoned Sarcophagus, so if anyone else wants to, feel free.

[Xander9009]

For Abandoned Sarcophagus, it's not as complex as it looks.

The first ability just means you'll pick a card that allows you to normal-cast cards from your graveyard and copy that code. Just make sure that when choosing which cards to apply the effect to, you make sure they have CW_CHARACTERISTIC_CYCLING.

The second might be a little tricker. But they should fire the cycled trigger BEFORE goign to the graveyard, so you should be able to have it check for the cycling trigger. Whenever a card is cycled, add it to a chest. Whenever a card goes to the graveyard from the stack, if it has teh cycling characteristic, then check if it's in the list. If it is, then do nothing. If it's not, then exile it. All that's left is to figure out exactly out to reset the list, but that should probably just be set up so that when it's added to the list, it also creates a delayed trigger for when it ends a zone-change ("it" being the card with cycling, and the zone change being from the stack to anywhere). When this happens, remove it from the list.

I'm not home, so I can't code it right now, but if neither of you do by the time I get home tonight, I'll give it a shot.

EDIT: For the EffectSource() vs EffectSourceLKI() issues, they're only seen if you activate the ability while it has exactlyt hat many counters on it. That could have prevented it from being an issue during testing. I didn't initially catch it; I only caught it when I went to use one of them in a deck and he did no damage.

Fo rthe others, I'm not sure why they would have stopped working. They're working now, so hopefully they stay that way.

[Splinterverse]

I have uploaded art for all cards spoiled today, including HQ for Strategic Planning, Hour of Devastation, and Life Goes On. Also uploaded HQ art for the Insect token, Horse token, and Adnored Pouncer token. LQ art for several other tokens also uploaded.

OP has been updated.

Back tomorrow morning for more coding.

[Splinterverse]

I have coded some additional spoilers. I will be coding throughout the day as new spoilers are released.

OP has been updated.

Coded/tested/uploaded:
Avid Reclaimer
Dutiful Servants
God-Pharaoh's Gift
Life Goes On
Manticore Eternal
Mummy Paramount
Rhonas's Stalwart
Seer of the Last Tomorrow
Sifter Wurm
Survivors' Encampment
Tragic Lesson
Wretched Camel

I also upgraded some LQ art to HQ.

Issues:

-- Eternalize does not appear to be working at the moment. I had not tested it since we switched to "TOKEN_ETERNALIZE_CARD_NAME" format. I'm guessing that is where the issue lies. I did confirm that I am using the latest CW and that there are no leftover LOL files in my test area.

-- Hour of Devastation https://pastebin.com/3UTjEU50 The majority of the card works but it is not damaging planeswalkers. I had Nissa, Worldwaker in play as well as a Bolas and both took no damage.

-- Vizier of the Anointed https://pastebin.com/Xx3nwh6W None of its triggers are firing -- battlefield entry or on eternalize. I did try it with embalm commented out since I only had eternalize cards in the deck to see if that worked and it didn't. I confirmed that the new triggers are in constants file of the CW that I am using (the latest).

[fallenangle]

For Hour of Devastation, all of your filters have id 0. The card is probably using the first one when it comes time to hit the planeswalkers, which explains why nothing would happen. Try changing the filter ids of the PW filters and see if it works.

[Xander9009]

For Vizier of the Anointed, "Whenever you Eternalize or Embalm, draw a card." should be in its own ability. It's only part of the previous one because it's a spoiler.

Regardless, that alone wouldn't make it not work, of course. I noticed that the first triggered ability doesn't have a trigger, which would explain why it never triggers.

For the latter, that card looks like it's coded right. The problem is that the embalm and eternalize cards themselves lack the code that fires the trigger.

"CW_General_FireTrigger(CW_TRIGGER_EMBALM, EffectSource())" needs to be added to the embalm cards, and CW_TRIGGER_ETERNALIZE to eternalize cards.

EDIT: I've updated the card generator output file to include the needed functions for both the triggers and the characteristics.

I noticed one card had the trigger, but it was missing the second parameter, which is what determines what TriggerObject() will be.

I also went ahead and renamed all of the embalm and eternalize tokens since I had the files open.

[Splinterverse]

I have completed my work for today. All of the spoilers have been coded except for 2 (see below). There are a few that I plan to test before uploading.

There are two that I do not plan to code:
Abandoned Sarcophagus
Saving Grace

Hopefully someone else will code those.

There are a lot that need testing if anyone would like to help out.

@Xander9009 -- have you added the eternalize and emblam trigger/characteristic code to all of the cards that apply? If not, which one did you correct? I might have time tomorrow to go through them and add that code if you didn't do it.

I will code the basic lands once The Gatherer has been updated.

[Xander9009]

I added the code to all of them, and I also added it to the generator plugin if you want it.

[Splinterverse2]

Thanks for updating the plug-in. Today was the last day for HOU spoilers so I just need to update the one that I was testing when I test tomorrow and we should be good.

[Splinterverse]

Upgraded the art from LQ to HQ for 14 cards. OP updated.

[Splinterverse]

Completed testing for today.

Coded/tested/uploaded:
Countervailing Winds
Dagger of the Worthy
Hour of Devastation
Sunscourge Champion

OP has been updated.

The Eternalize cards had EMBALM for their characteristic, so I fixed all of them and uploaded.

I am having issues with Vizier of the Anointed. I made sure to use the latest copy of the CW and there were no extra LOL files. None of its abilities are working. I tested it with Eternalize and Embalm in the deck.

Here's the latest code: https://pastebin.com/Q7zu64hW

[tmxk2012917]

7/1/2017 16:25:38: Low: Card (ACT_OF_HEROISM_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009999489

7/1/2017 16:25:38: Low: Card (AMBUSCADE_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009998438

7/1/2017 16:25:39: Low: Card (AVEN_OF_ENDURING_HOPE_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009996482

7/1/2017 16:25:39: Low: Card (BANEWHIP_PUNISHER_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009994476

7/1/2017 16:25:39: Low: Card (BENEATH_THE_SANDS_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009995066

7/1/2017 16:25:39: Low: Card (BITTERBOW_SHARPSHOOTERS_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009991162

7/1/2017 16:25:40: Low: Card (DAUNTLESS_AVEN_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009993162

7/1/2017 16:25:40: Low: Card (DEVOTEE_OF_STRENGTH_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009994905

7/1/2017 16:25:40: Low: Card (DISPOSAL_MUMMY_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009996827

7/1/2017 16:25:41: Low: Card (DUNE_DIVINER_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009990641

7/1/2017 16:25:41: Low: Card (DUTIFUL_SERVANTS_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009993167

7/1/2017 16:25:41: Low: Card (FERAL_PROWLER_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009991304

7/1/2017 16:25:41: Low: Card (FRILLED_SANDWALLA_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009994696

7/1/2017 16:25:42: Low: Card (GRISLY_SURVIVOR_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009992762

7/1/2017 16:25:43: Low: Card (LETHAL_STING_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009991434

7/1/2017 16:25:43: Low: Card (LIFE_GOES_ON_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009997032

7/1/2017 16:25:44: Low: Card (LURCHING_ROTBEAST_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009997096

7/1/2017 16:25:44: Low: Card (MANTICORE_ETERNAL_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009992654

7/1/2017 16:25:44: Low: Card (MUMMY_PARAMOUNT_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009993499

7/1/2017 16:25:46: Low: Card (RHONASS_STALWART_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009993046

7/1/2017 16:25:46: Low: Card (SEER_OF_THE_LAST_TOMORROW_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009999989

7/1/2017 16:25:47: Low: Card (SIFTER_WURM_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009994739

7/1/2017 16:25:48: Low: Card (SURVIVORS_ENCAMPMENT_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009996025

7/1/2017 16:25:49: Low: Card (TRAGIC_LESSON_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009995666

7/1/2017 16:25:50: Low: Card (WRETCHED_CAMEL_CW in DATA_DLC_COMMUNITY_CORE) has a multiverse id that is problematic: 9009998205

Edit: I also uploaded the image of The Scarab God given that the old one in CW was the image of The Scorpion God

[merdok]

Fraying Sanity has a bug, it always puts only 1 card into the player's graveyard no matter how many cards entered his graveyard on a turn.
The Scorpion God - art missing?