[fixed] Game hang - prob Scrap Trawler & Treasure Keeper

by **Wally** » 20 May 2020, 04:41

Describe the Bug:
Game freeze in attached save, Mechanized Production about to create clone?

Which card behaved improperly?
Mechanized Production?

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
version 5-2020 10bda4ca0, duel

Also in attached save, there is a (possibly unnecessary?) legacy card effect floating around for Scrap Trawler (seen in screenshot)

by **drool66** » 20 May 2020, 19:06

The Scrap Trawler legacy is very much necessary, but it should be attached to something & invisible. My guess is the crash has something to do with that - do you remember how and when it appeared? I can't even load this save in either my working copy or the release folder.

by **Wally** » 21 May 2020, 00:06

The Scrap Trawler legacy card appears the turn after it has been cast. There is an instance of it in the (non-crashing) savegame I've attached. In this game Scrap Trawler was drawn normally and it was cast normally (not cheated into play or anything unusual) and no artifacts have gone to the graveyard since it was cast

by **drool66** » 21 May 2020, 00:24

I made Scrap Trawler a while ago - just took a look at the code for it and I don't know what I was thinking - I'm surprised it works at all. Doing a rewrite now. Not sure if that's the cause of the hang or not though.

by **Wally** » 21 May 2020, 00:24

Continuing that testgame above ("ST.zip") its developed into a complete game freeze twice within a few turns. On both ocassions the freeze point was on me having declared attackers. Possibly the AI was about to make what would have been a lethal block and sent my attacker to the graveyard.

I've attached a savegame from one of those freezepoints "ST2.zip", the attacker in this instance was a Treasure Keeper, on my attack a parameters error was generated (below)

bad parameters
get_card_instance(0, -1)
0: 0x02509628
1: 0x024C041E
2: 0x02506FC6
3: 0x021BB374
4: 0x02519635
5: 0x024F731D
6: 0x024D0C9F
7: 0x00457E4A
8: 0x02519635
9: 0x024F731D
10: 0x024F7E5E
11: 0x024F8206
12: 0x004367C3
13: 0x024F8340
14: 0x004766DC
15: 0x024F75A6
16: 0x024F7C37
17: 0x004371B4
18: 0x00477B1A
19: 0x004B37D7
20: 0x0043CD3D
21: 0x004399BD
22: 0x0047902C
23: 0x004946E9
24: 0x76186359
25: 0x77367C24
26: 0x77367BF4

On closing the parameters window a second error was displayed (seen in screenshot) and then the game froze completely

EDIT: I've isolated this in further testing, there are two separate bugs

1. Scrap Trawler with probable related game freeze on attacking
2. Treasure Keeper - this is independent and unconnected to presence of Scrap Trawler, if you isolate down to Treasure Keeper vs a vanilla blocker, you get the parameters error listed above but the game continues

by **drool66** » 21 May 2020, 19:22

Thanks again, Wally

I rewrote Scrap Trawler & fixed Treasure Keeper. Mechanized Production looks fine. I'll mark this fixed in a4e39141a ("Fix AER bugs", 2020-05-21).