[fixed]meddling mage & nevermore AI can select land

[Althuna]

Describe the Bug:
meddling mage hangs game fixed

Which card behaved improperly?
meddling mage

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
latest, running gauntlet in challenge

What exactly should be the correct behavior/interaction?
it should let you choose a card

Are any other cards possibly affected by this bug?
nevermore

[Aswan jaguar]

Please capitalize first letters (write name as in gatherer so the auto rules text feature works, thanks.
Meddling Mage, Nevermore.

[Aswan jaguar]

Finally after a lot of effort (just at my last attempt before I quit found a solution) fixed in commit 8b3268a. Affected around 15 cards that "name a card" some of them both when human or AI cast them and others just for AI that made game freeze.
However AI can steal with some of these cards and select a land although the card says otherwise.

[drool66]

Impressive fix

Using the old card_from_list seems to properly enforce the land selection, ie changing line 1239 to:

csvid = card_from_list(player, 3, TYPE_LAND, 1, 0, 0, 0, 0, 0, 0, -1, 0);

But the prompt then is just "Choose a card" (could maybe be changed in card_from_list 's declaration by changing "Choose a card" to test->message without causing a lot of trouble... maybe, who knows)

So... maybe an underlying issue with new_card_from_list?

[FastEddie]

Commit 040f80a1d fixes it.

The issue was in ai_name_a_random_csvid, namely here:

Code: Select all

if( ! type || (test && new_make_test(t_player, deck_ptr[t_player][count], -1, test) )){
   csvid = cards_data[deck_ptr[t_player][count]].id;
   rounds = 2;
   break;
}


If the function is called with type == 0 so that a supplied test is used the first condition ! type is always true and the test is never executed.
I also changed the selection mechanism a bit so that the AI has a good chance to pick something meaningful (choose at random 10 times which gives decent enough odds even if only a small portion of player's deck is eligible). Also added a few comments to explain how the function works as I found a variety of uses.

Other affected cards are: Council of the Absolute, Conjurer's Ban, Desperate Research, Null Chamber, Phyrexian Revoker, Slaughter Games, Memoricide, Booby Trap, Voidstone Gargoyle, Pithing Needle.