[fixed]Phage the Untouchable trample damage & die no trigger
Moderators: BAgate, drool66, Aswan jaguar, gmzombie, stassy, CCGHQ Admins
[fixed]Phage the Untouchable trample damage & die no trigger
by Aswan jaguar » 10 Mar 2017, 16:58
Describe the Bug:
I had a Loxodon Warhammer equipped on Phage the Untouchable, she attacked and was killed but she killed blocker and damage through trample passed to opponent but her ability didn't trigger and I didn't win the game.
Note: If you regenerate Phage the Untouchable in the above scenario then it triggers correctly.
Which card did behave improperly?
Phage the Untouchable - Trample damage mechanism?
Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Manalink 2016/08/27: Eldritch Moon v2, duel
What exactly should be the correct behavior/interaction?
Phage the Untouchable with trample even if she dies in combat if damage spills to opponent her ability triggers and you win the game.
Are any other cards possibly affected by this bug?
I have already reported the same problem with:Rapacious One viewtopic.php?f=86&t=19386&p=204823&hilit=trample#p204823
Barbed Shocker viewtopic.php?f=86&t=19212&p=203398&hilit=trample+trigger#p203398
Fungal Shambler viewtopic.php?f=86&t=17016&hilit=trample+trigger also Liege of the Tangle is bugged.
I guess all cards templated like "Whenever creature* deals combat damage to a player...." are bugged.
Similarly most creature cards that are templated "whenever creature* deal combat damage to creature....." or "whenever creature* deal combat damage..." if die and kill others simultaneously their abilities don't trigger.
I had a Loxodon Warhammer equipped on Phage the Untouchable, she attacked and was killed but she killed blocker and damage through trample passed to opponent but her ability didn't trigger and I didn't win the game.
Note: If you regenerate Phage the Untouchable in the above scenario then it triggers correctly.
Which card did behave improperly?
Phage the Untouchable - Trample damage mechanism?
Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Manalink 2016/08/27: Eldritch Moon v2, duel
What exactly should be the correct behavior/interaction?
Phage the Untouchable with trample even if she dies in combat if damage spills to opponent her ability triggers and you win the game.
Are any other cards possibly affected by this bug?
I have already reported the same problem with:Rapacious One viewtopic.php?f=86&t=19386&p=204823&hilit=trample#p204823
Barbed Shocker viewtopic.php?f=86&t=19212&p=203398&hilit=trample+trigger#p203398
Fungal Shambler viewtopic.php?f=86&t=17016&hilit=trample+trigger also Liege of the Tangle is bugged.
I guess all cards templated like "Whenever creature* deals combat damage to a player...." are bugged.
Similarly most creature cards that are templated "whenever creature* deal combat damage to creature....." or "whenever creature* deal combat damage..." if die and kill others simultaneously their abilities don't trigger.
- Attachments
-
phage the untouchable-trample dmage no win.rar
- (2.71 KiB) Downloaded 260 times
Last edited by Aswan jaguar on 07 Feb 2021, 19:48, edited 6 times in total.
Reason: fixed-added topic icon
Reason: fixed-added topic icon
---
Trying to squash some bugs and playtesting.
Trying to squash some bugs and playtesting.
-
Aswan jaguar - Super Tester Elite
- Posts: 8129
- Joined: 13 May 2010, 12:17
- Has thanked: 748 times
- Been thanked: 477 times
Re: [fixed]Phage the Untouchable trample damage & die no tri
by drool66 » 05 Feb 2021, 17:01
I have a fix for these creatures. The way it works is damage_dealt_by_me_arbitrary() now checks for the triggering creature to die, and if it does, create an invisible token copy of the creature and switch damage_source_card for all damage cards to the token, then obliterate the token on EVENT_RESOLVE_TRIGGER or EVENT_PHASE_CHANGED. That way the token is around to get TRIGGER_DEAL_DAMAGE. Issue is it won't work for attached cards(eg. cipher), though I could do a sweep for those to switch as well.
Looks like the git server is down? I'll push once it's back up & I'm done testing MH1.
[EDIT]: Equipment was already working, but will have to update attached_creature_deals_damage() for auras.
[EDIT 2]: Committed in eeee5d7, including fix for auras. Could possibly be improved - there seems to be an issue with the auras not being sent to gy right away when attached creature dies, but everything else seems to work ok - probably a regen status somewhere will fix it
Looks like the git server is down? I'll push once it's back up & I'm done testing MH1.
[EDIT]: Equipment was already working, but will have to update attached_creature_deals_damage() for auras.
[EDIT 2]: Committed in eeee5d7, including fix for auras. Could possibly be improved - there seems to be an issue with the auras not being sent to gy right away when attached creature dies, but everything else seems to work ok - probably a regen status somewhere will fix it
The latest images for Manalink will be here.
The latest Manalink installation directory will be here. Well, not quite, anymore. Check the latest patches.
The latest Manalink installation directory will be here. Well, not quite, anymore. Check the latest patches.
-
drool66 - Programmer
- Posts: 1185
- Joined: 25 Nov 2010, 22:38
- Has thanked: 187 times
- Been thanked: 280 times
2 posts
• Page 1 of 1
Who is online
Users browsing this forum: No registered users and 39 guests