[fix/closed]Nissa's Judgment target timing & errors

[Aswan jaguar]

Describe the Bug:
Nissa's Judgment when cast prompts for an opponent's creature to deal damage to but when opponent's creatures are found illegal targets only your creatures are found legal.If you target your own crature then you are prompt to select 2 to support them,they get the counters and no damage is done.
However AI can make it work sometimes.See savegame "working".
Which card did behave improperly ?
Nissa's Judgment

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Manalink 2016/08/27: Eldritch Moon v2, duel

What exactly should be the correct behavior/interaction ?
Nissa's Judgment target opponent's creature to deal damage to finds opponent's creatures legal targets.

Are any other cards possibly affected by this bug ?
-

[Aswan jaguar]

I fixed both bugs by changing the "td.allowed_controller" to 1-player (which is the opponent right?) but I get the following errors:

error | Open

bad parameters
get_card_instance(-1, -1)
0: 0x024E0C88
1: 0x0249816E
2: 0x024E7340
3: 0x02095123
4: 0x020A3807
5: 0x024F06B5
6: 0x024CEBED
7: 0x024CF316
8: 0x004368C6
9: 0x024A5FC7
10: 0x0043BFAA
11: 0x004399BD
12: 0x0047902C
13: 0x004946E9
14: 0x7C80B729

code | Open

Code: Select all

int card_nissas_judgement(int player, int card, event_t event){
   /* Nissa's Judgment   |4|G   0x200e68e
    * Sorcery
    * Support 2.
    * Choose up to one target creature an opponent controls. Each creature you control with a +1/+1 counter on it deals damage equal
    * to its power to that creature. */

   if( ! IS_GS_EVENT(player, card, event) ){
      return 0;
   }

   target_definition_t td;
   default_target_definition(player, card, &td, TYPE_CREATURE);
   td.allowed_controller = td.preferred_controller = 1-player;
   td.allow_cancel = 2; //"Done" button

   card_instance_t *instance = get_card_instance( player, card);

   if( event == EVENT_RESOLVE_SPELL ){
      int t_card = -1;
      if( instance->number_of_targets == 1 && valid_target(&td) ){
         t_card = instance->targets[0].card;
      }

      support(player, card, 2);

      if( t_card > -1 ){
         int c;
         for(c=active_cards_count[player]-1; c>-1; c--){
            if( in_play(player, c) && is_what(player, c, TYPE_CREATURE) && count_1_1_counters(player, c) ){
               damage_creature(1-player, t_card, get_power(player, c), player, c);
            }
         }
      }

      kill_card(player, card, KILL_DESTROY);
   }
   return generic_spell(player, card, event, GS_OPTIONAL_TARGET | GS_LITERAL_PROMPT, &td, "Select target creature an opponent controls.", 1, NULL);
}

Any ideas what else needs to be changed?

Fixed allowed controller in commit 7fa4a4a1.

[Korath]

Besides making it choose its targets at announcement instead of midway through resolution?

support() blithely assumes its card's ->number_of_targets == 0. Clear that first and at least it won't crash.

[drool66]

Should be fixed in bbf4f08
See https://www.slightlymagic.net/forum/viewtopic.php?f=86&t=19480