[Fixed] Bug Archive

[stassy]

confirmed, also Moonit Strider don't have a legacy card like others Soulshift cards (eg Promised Kannushi)

[Aswan jaguar]

I don't remember if Gargaroz said anything about (possible coding problems)why he decided to use an "Effect/legacy Card" for Shoulshift as the effect triggers as card goes to graveyard and you have the card itself to show you this info.(it isn't like others that the effect goes on till end of turn or upkeep,or at any later time)

Of course the really important stuff is that it works and the only disadvantage is that you have an "Effect Card" for Shoulshift and another "Legacy Card"like in this case of Moonlit Strider that has an ability that gives ability to another creature and be attached to that creature.You can't interact with the first but certainly you can interact with the 2nd (disabling the protection,changing it to another colour ,etc)

[Aswan jaguar]

Describe the Bug:
Knighthood gives first strike to creatures in hand,too.

Which card did behave improperly ?
Knighthood

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
ML3-MAY\2013

What exactly should be the correct behavior/interaction ?


Are any other cards possibly affected by this bug ?

[Korath]

Describe the Bug:
My Undead Horde Awakens chooses from opponent's library instead of graveyard, and if a creature is chosen, two textless effect cards are put on the battlefield instead.

Which card did behave improperly ?
Archenemy.

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Planeswalking to Modern 05182013.rar on top of CirothUngol. Solo duel/none.

What exactly should be the correct behavior/interaction ?
At the beginning of your end step, you may put target creature card from an opponent's graveyard onto the battlefield under your control. When a creature put onto the battlefield with this scheme dies, abandon this scheme.

Are any other cards possibly affected by this bug ?
Nope.

Code: Select all

diff --git a/src/cards/archenemy.c b/src/cards/archenemy.c
index 41a28a8..0aa73c4 100644
--- a/src/cards/archenemy.c
+++ b/src/cards/archenemy.c
@@ -831,7 +831,7 @@ int card_archenemy(int player, int card, event_t event){

         //My Undead Horde Awakens
         if( current_turn == player && (instance->targets[10].card & 1) ){
-           int selected = select_a_card(player, 1-player, 1, 0, 2, -1, TYPE_CREATURE, 0, 0, 0, 0, 0, 0, 0, -1, 0);
+           int selected = select_a_card(player, 1-player, TUTOR_FROM_GRAVE, 0, 2, -1, TYPE_CREATURE, 0, 0, 0, 0, 0, 0, 0, -1, 0);
            if( selected != -1 ){
                int reanimated = reanimate_permanent(player, card, 1-player, selected, 0, 2);
                card_instance_t *zombie = get_card_instance(player, reanimated);


[Aswan jaguar]

Describe the Bug:
Necromancer's Magemark is returning to hand non-enchanted creatures that die,too.

Which card did behave improperly ?
Necromancer's Magemark

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
ML3-MAY\2013

What exactly should be the correct behavior/interaction ?
Only enchanted creatures that die will return to hand

Are any other cards possibly affected by this bug ?

[Korath]

Describe the Bug:
My Wish Is Your Command copies the wrong spell based on its position in the opponent's hand, e.g. it casts Air Elemental if the first card is picked, or Ancestral Recall if the second card is.

Which card did behave improperly ?
Archenemy.

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Planeswalking to Modern 05182013.rar on top of CirothUngol. Solo duel/none.

What exactly should be the correct behavior/interaction ?
When you set this scheme in motion, each opponent reveals his or her hand. You may choose a noncreature, nonland card revealed this way and cast it without paying its mana cost.

Are any other cards possibly affected by this bug ?
No. The problem here's that effect_coercion(), contrary to its documentation, always returns an index into the player's hand instead of a card id. The other cards with a similar effect (Reversal of Fortune, Mindclaw Shaman, Silent-Blade Oni, Mindleech Mass) all find the correct id and then destroy the card themselves, instead of relying on effect_coercion() to do it.

Code: Select all

diff --git a/src/cards/archenemy.c b/src/cards/archenemy.c
index 41a28a8..0ee9404 100644
--- a/src/cards/archenemy.c
+++ b/src/cards/archenemy.c
@@ -444,11 +444,13 @@ int set_scheme_in_motion(int player, int card, event_t event, int cheat_code){
                  int selected = -1;
                  if( hand_count[1-player] > 0 ){
                                        int type = TYPE_ARTIFACT | TYPE_ENCHANTMENT | TYPE_INSTANT | TYPE_SORCERY;
-                    selected = effect_coercion(1-player, player, 9, 1, type, 2, 0, 0, 0, 0, 0, 0, -1, 0);
+                    selected = effect_coercion(1-player, player, EC_SELECT_CARD, 1, type, 2, 0, 0, 0, 0, 0, 0, -1, 0);
                  }

                  if( selected != -1 ){
-                     copy_spell(player, selected);
+                     int id = get_id(1-player, selected);
+                     kill_card(1-player, selected, KILL_DESTROY);
+                     copy_spell(player, id);
                  }
         }



[Gargaroz]

Fixed.

[Gargaroz]

All fixed.

[Gargaroz]

Fixed.

[Gargaroz]

Fixed.

[Gargaroz]

Fixed.

[Gargaroz]

Fixed.
Also the "legacy card" is required as asking a target or making a player draw while a creature is dying of combat damage generates always some errors (duplicate cards in grave, decking and so).

[Gargaroz]

Well, here's another global bug yet to discover. It probably happens with Slivers and such. It's fixed now.

[Aswan jaguar]

Thanks for the explanation Gargaroz.

[Aswan jaguar]

I have seen this with other cards that give flying and probably others,is it now fixed for all or if I come up with others,report them?