It is currently 22 Nov 2025, 21:20
   
Text Size

[Fixed] Bug Archive

Moderators: Aswan jaguar, gmzombie, stassy, BAgate, drool66, CCGHQ Admins

Re: [confirmed]My Undead Horde Awakens

Postby Gargaroz » 13 Jun 2013, 14:57

Fixed.
----
- Current / medium term task: adjusting the code for making Misdirection and such usable
- Long term task: inserting all the good stuff I left out from the "Golden Years" mod
Gargaroz
Programmer
 
Posts: 7097
Joined: 06 Nov 2009, 11:11
Has thanked: 82 times
Been thanked: 595 times

Re: Necromancer's Magemark

Postby Gargaroz » 13 Jun 2013, 15:05

Fixed.
----
- Current / medium term task: adjusting the code for making Misdirection and such usable
- Long term task: inserting all the good stuff I left out from the "Golden Years" mod
Gargaroz
Programmer
 
Posts: 7097
Joined: 06 Nov 2009, 11:11
Has thanked: 82 times
Been thanked: 595 times

Re: [confirmed]My Wish Is Your Command

Postby Gargaroz » 13 Jun 2013, 15:10

Fixed.
----
- Current / medium term task: adjusting the code for making Misdirection and such usable
- Long term task: inserting all the good stuff I left out from the "Golden Years" mod
Gargaroz
Programmer
 
Posts: 7097
Joined: 06 Nov 2009, 11:11
Has thanked: 82 times
Been thanked: 595 times

Re: [fixed by Gargaroz]Knighthood

Postby Gargaroz » 13 Jun 2013, 23:52

No, it should be fixed for all.
----
- Current / medium term task: adjusting the code for making Misdirection and such usable
- Long term task: inserting all the good stuff I left out from the "Golden Years" mod
Gargaroz
Programmer
 
Posts: 7097
Joined: 06 Nov 2009, 11:11
Has thanked: 82 times
Been thanked: 595 times

[fixed by Gargaroz]Urborg, Tomb of Yawgmoth

Postby Korath » 14 Jun 2013, 13:49

Describe the Bug:
I control a Mountain and Urborg, Tomb of Yawgmoth. I activate urborg and target itself; it taps and produces {B}. I then activate urborg and target the mountain; the mountain taps and produces {B}, but urborg untaps.

Which card did behave improperly ?
Urborg, Tomb of Yawgmoth.

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Planeswalking to Modern 05182013.rar on top of CirothUngol. Solo duel/none.

What exactly should be the correct behavior/interaction ?
Urborg, Tomb of Yawgmoth should neither tap nor untap itself when activating to tap another land for {B}.

Are any other cards possibly affected by this bug ?
No.

Code: Select all
diff --git a/src/cards/planar_chaos.c b/src/cards/planar_chaos.c
index 18c6f91..8a1c531 100644
--- a/src/cards/planar_chaos.c
+++ b/src/cards/planar_chaos.c
@@ -2833,10 +2833,12 @@ int card_urborg_tomb_of_yawgmoth(int player, int card, event_t event){

        if(event == EVENT_ACTIVATE ){
                if( pick_target(&td, "TARGET_LAND") ){
+                       int was_tapped;
                        tap_card(instance->targets[0].player, instance->targets[0].card);
                        instance->number_of_targets = 1;
+                       was_tapped = instance->state & STATE_TAPPED;
                        mana_producer(player, card, event);
-                       if( ! (instance->targets[0].player == player && instance->targets[0].card == card) ){
+                       if( !was_tapped ){
                                untap_card(player, card);
                        }
                }
Attachments
urborg_tomb_of_yawgmoth.zip
(1.48 KiB) Downloaded 398 times
Last edited by stassy on 15 Jun 2013, 05:48, edited 2 times in total.
Reason: bug fixed
User avatar
Korath
DEVELOPER
 
Posts: 3708
Joined: 02 Jun 2013, 05:57
Has thanked: 496 times
Been thanked: 1108 times

[fixed by Gargaroz]Sowing Salt

Postby Aswan jaguar » 14 Jun 2013, 15:01

Describe the Bug:
Sowing Salt targets a non-basic land and nothing happens,it stays on hand.

Which card did behave improperly ?
Sowing Salt

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
ML3-MAY\2013

What exactly should be the correct behavior/interaction ?


Are any other cards possibly affected by this bug ?
Attachments
SOWING SALT.rar
the card is debugged in hand,so cheat red mana to cast it
(1.9 KiB) Downloaded 332 times
Last edited by stassy on 15 Jun 2013, 18:50, edited 4 times in total.
Reason: bug fixed
---
Trying to squash some bugs and playtesting.
User avatar
Aswan jaguar
Super Tester Elite
 
Posts: 8144
Joined: 13 May 2010, 12:17
Has thanked: 751 times
Been thanked: 486 times

[fixed by Korath]Spreading Seas

Postby Korath » 14 Jun 2013, 15:26

Describe the Bug:
Spreading Seas makes its enchanted land into a swamp.

Which card did behave improperly ?
Spreading Seas.

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Planeswalking to Modern 05182013.rar on top of CirothUngol. Solo duel/none.

What exactly should be the correct behavior/interaction ?
The enchanted land should be an island.

Are any other cards possibly affected by this bug ?
No. Evil Presence and Contaminated Ground work properly, and other similar cards (Lingering Mirage and Sea's Claim) aren't coded.

Code: Select all
diff --git a/src/cards/zendikar.c b/src/cards/zendikar.c
index 181d256..b5fae9a 100644
--- a/src/cards/zendikar.c
+++ b/src/cards/zendikar.c
@@ -4723,6 +4723,14 @@ int card_spreading_seas(int player, int card, event_t event){
         instance->info_slot = COLOR_BLUE;
         draw_a_card(player);
     }
+
+    if( event == EVENT_CHANGE_TYPE ){
+        if (affect_me(instance->targets[0].player, instance->targets[0].card)){
+            event_result = get_hacked_color(player, card, 2) - 1;
+        }
+        return 0;
+    }
+
     return card_evil_presence(player, card, event);
 }

card_evil_presence() in the exe also does some other stuff (a call to 0x401A40 and a check for !(land_can_be_played & 2)) in its EVENT_CHANGE_TYPE handler. I haven't a clue what they do, but can't find any obvious side effects of omitting them.
Attachments
spreading_seas.zip
(1.74 KiB) Downloaded 342 times
Last edited by stassy on 15 Jun 2013, 05:51, edited 3 times in total.
Reason: bug fixed
User avatar
Korath
DEVELOPER
 
Posts: 3708
Joined: 02 Jun 2013, 05:57
Has thanked: 496 times
Been thanked: 1108 times

[fixed by Gargaroz]Cloudpost

Postby Korath » 14 Jun 2013, 15:54

Describe the Bug:
Cloudpost doesn't tap when activated, and only adds {1} for each Locus you control.

Which card did behave improperly ?
Cloudpost.

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Planeswalking to Modern 05182013.rar on top of CirothUngol. Solo duel/none.

What exactly should be the correct behavior/interaction ?
It should tap, and should add {1} for each Locus on the battlefield (including the other player's).

Are any other cards possibly affected by this bug ?
No. Glimmerpost correctly counts the number of Locuses.

Code: Select all
diff --git a/src/cards/lands.c b/src/cards/lands.c
index bed9124..acada6e 100644
--- a/src/cards/lands.c
+++ b/src/cards/lands.c
@@ -436,13 +436,14 @@ int card_cloudpost(int player, int card, event_t event){
     comes_into_play_tapped(player, card, event);

     if( event == EVENT_COUNT_MANA && !(is_tapped(player, card)) && affect_me(player, card) ){
-        declare_mana_available(player, COLOR_COLORLESS, count_subtype(player, TYPE_LAND, SUBTYPE_LOCUS) );
+        declare_mana_available(player, COLOR_COLORLESS, count_subtype(2, TYPE_LAND, SUBTYPE_LOCUS) );
     }
     else if(event == EVENT_CAN_ACTIVATE && !(is_tapped(player, card)) ){
                        return 1;
     }
     else if( event == EVENT_ACTIVATE){
+                       tap_card(player, card);
-                       produce_mana(player, COLOR_COLORLESS, count_subtype(player, TYPE_LAND, SUBTYPE_LOCUS));
+                       produce_mana(player, COLOR_COLORLESS, count_subtype(2, TYPE_LAND, SUBTYPE_LOCUS));
     }

     return 0;
edit:struck already-fixed parts
Attachments
cloudpost.zip
(1.87 KiB) Downloaded 339 times
Last edited by stassy on 15 Jun 2013, 05:50, edited 4 times in total.
Reason: bug fixed
User avatar
Korath
DEVELOPER
 
Posts: 3708
Joined: 02 Jun 2013, 05:57
Has thanked: 496 times
Been thanked: 1108 times

Re: Spreading Seas

Postby Aswan jaguar » 14 Jun 2013, 15:57

Thanks,this bug was a pain in the ass for years thanks for fixing it.I imagine you tested the fix,right? =D>
---
Trying to squash some bugs and playtesting.
User avatar
Aswan jaguar
Super Tester Elite
 
Posts: 8144
Joined: 13 May 2010, 12:17
Has thanked: 751 times
Been thanked: 486 times

Re: Sowing Salt

Postby Korath » 14 Jun 2013, 16:01

If actually only works on basic lands, though it can't be cast unless there's a nonbasic land in play.
Code: Select all
diff --git a/src/cards/urza_destiny.c b/src/cards/urza_destiny.c
index 7f5b1f3..44f7f74 100644
--- a/src/cards/urza_destiny.c
+++ b/src/cards/urza_destiny.c
@@ -2229,7 +2229,7 @@ int card_sowing_salt(int player, int card, event_t event){
     else if( event == EVENT_CAST_SPELL && affect_me(player, card) ){
             if( pick_target(&td, "TARGET_LAND") ){
                                instance->number_of_targets = 1;
-                if( ! is_basic_land(instance->targets[0].player, instance->targets[0].card) ){
+                if( is_basic_land(instance->targets[0].player, instance->targets[0].card) ){
                                        spell_fizzled = 1;
                 }
             }
User avatar
Korath
DEVELOPER
 
Posts: 3708
Joined: 02 Jun 2013, 05:57
Has thanked: 496 times
Been thanked: 1108 times

Re: Spreading Seas

Postby Korath » 14 Jun 2013, 16:01

Yes, and with Magical Hacks altering it also.
User avatar
Korath
DEVELOPER
 
Posts: 3708
Joined: 02 Jun 2013, 05:57
Has thanked: 496 times
Been thanked: 1108 times

Re: Cloudpost

Postby stassy » 14 Jun 2013, 17:35

Already reported and fixed here
stassy
Moderator
 
Posts: 5274
Joined: 25 Feb 2009, 07:06
Has thanked: 471 times
Been thanked: 337 times

Re: [already reported-fixed]Cloudpost

Postby Korath » 14 Jun 2013, 17:44

Ack, sorry - I did search, and somehow overlooked that.

The other half, that it doesn't count the opponent's Locuses, wasn't reported there, though.
User avatar
Korath
DEVELOPER
 
Posts: 3708
Joined: 02 Jun 2013, 05:57
Has thanked: 496 times
Been thanked: 1108 times

Re: [already reported-fixed]Cloudpost

Postby stassy » 14 Jun 2013, 17:48

Ah right, adding bug then, will have to check if Gargaroz noticed it too.
stassy
Moderator
 
Posts: 5274
Joined: 25 Feb 2009, 07:06
Has thanked: 471 times
Been thanked: 337 times

[fixed by Gargaroz]Mindlock Orb

Postby stassy » 14 Jun 2013, 18:05

Describe the Bug:
Mindlock Orb is highlighted as castable even if the mana requirement is not met

Which card did behave improperly ?
Mindlock Orb

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
PM

What exactly should be the correct behavior/interaction ?
Mindlock Orb is not highlighted as castable if the mana requirement is not met

Are any other cards possibly affected by this bug ?
-

Image
Last edited by stassy on 15 Jun 2013, 05:49, edited 1 time in total.
Reason: bug fixed
stassy
Moderator
 
Posts: 5274
Joined: 25 Feb 2009, 07:06
Has thanked: 471 times
Been thanked: 337 times

PreviousNext

Return to Archived Reports

Who is online

Users browsing this forum: No registered users and 42 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 42 users online :: 0 registered, 0 hidden and 42 guests (based on users active over the past 10 minutes)
Most users ever online was 9824 on 10 Nov 2025, 04:33

Users browsing this forum: No registered users and 42 guests

Login Form