[Fixed] Bug Archive

[xJEDIx]

Describe the Bug:
Zhur-taa Druid gives G or R mana

Which card did behave improperly ?
Zhur-taa Druid

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
06162013_v2
Duel

What exactly should be the correct behavior/interaction ?
It should only give G mana.

Are any other cards possibly affected by this bug ?
The cards that would be cast.

[xJEDIx]

Describe the Bug:
Cackling Counterpart copies a critter but doesn't make it a token

Which card did behave improperly ?
Cackling Counterpart

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
06162013_v2
Duel

What exactly should be the correct behavior/interaction ?
The critter copied by Cackling Counterpart should be considered a token, and be populated.

Are any other cards possibly affected by this bug ?
The whole Biovisionary combo deck.

[Gargaroz]

Fixed.

[Gargaroz]

Fixed.

[Gargaroz]

Already reported and fixed. Sorry for Desecration Demon, it's really great in Varolz deck, but currently there's no way of reproducing its ability with correct timing.

[Gargaroz]

Fixed.

[Gargaroz]

Well, the code of Cackling Counterpart is fine, so it's another interaction with a card with Populate. Test more and let me know.

[Aswan jaguar]

Attch a savegame or screenshot,please.

[stassy]

confirmed, in fact Cackling Counterpart create a fully fledged card with no "token" as a type, that is why populate has no effect





Tested with Growing Ranks and Druid's Deliverance, I suspect anything that create a token that is a copy of target creature like Back from the Brink has the same issue.

[Korath]

How are you testing whether it's a token? Just by populating? I just cast Cackling Counterpart on a Flying Men, then Unsummon on the new creature; it was correctly removed entirely from the game instead of going to my hand.

Edit: and I was able to populate it too (with Druid's Deliverance).
And edit again: With a Biovisionary, though, Druid's Deliverance doesn't find it to populate. Unsummon still sees the token bit and rfgs it.

[stassy]

For the 1st screenshot, I casted Growing Ranks, then Cackling Counterpart on Biovisionary then waited next upkeep : Growing Ranks should have triggered and automatically make a copy of the Biovisionary token (the second one on the right), but it didn't (you also can't see which one is the original and which one is the token)

For the second, Cackling Counterpart on Biovisionary then casted Druid's Deliverance, nothing happened while it should create a copy of the 2nd one which is supposed to be a token.

Edit: Ok so it seems Populate is the culprit then

[Korath]

The bug here is with populate seeing tokens, not with whatever's making them. Suspect there's either a problem in check_battlefield_for_special_card() (which is too complex for me to assess at a glance), or its call to real_validate_target() (which I'm about halfway done rewriting).

[stassy]

I might eventually be able to wrangle the demon into shape. Right place is sub_43B110, a bit after LABEL_282; likely either just before the call to sub_4B02C0 or within it. Keep a bug open for him and I'll get to it.

Do you mean that we create a thread for him separately of this one?

[Korath]

Whatever else is happening, the token created by Cackling Counterpart doesn't have all the targets set that copy_token() (as called from populate()) expects.

backtrace | Open

Code: Select all

#1  0x022db8dd in get_card_instance (player=0, card=-1) at functions/functions.c:24
#2  0x02306a61 in generate_token (token=0x966f48c) at functions/token_generation.c:150
#3  0x02306e26 in copy_token (player=0, card=4, tok_player=0, tok_card=17) at functions/token_generation.c:234
#4  0x021fded9 in populate (card=4, player=0) at cards/return_to_ravnica.c:50
#5  populate (player=0, card=4) at cards/return_to_ravnica.c:24
#6  0x02204b50 in card_druids_deliverance (player=0, card=4, event=EVENT_RESOLVE_SPELL) at cards/return_to_ravnica.c:2473
(gdb) frame 2
#2  0x02306a61 in generate_token (token=0x966f48c)
    at functions/token_generation.c:150
150         card_instance_t *source = get_card_instance(token->s_player, token->s_card);
(gdb) p *token
$1 = {id = 420, s_player = 0, s_card = -1, t_player = 0, qty = 1, pow = -1, tou = 0, key_plus = 0, s_key_plus = 0, color_plus = 0,
  color_forced = 0, special_infos = 0, action = 0, legacy = 0, keep_track_of_tokens_generated = 0,
  special_code_for_legacy = 0x22db7d0 <empty>, special_code_for_token = 0}
(gdb) frame 3
#3  0x02306e26 in copy_token (player=0, card=4, tok_player=0, tok_card=17)
    at functions/token_generation.c:234
234             int result = generate_token(&token);
(gdb) p *instance
$2 = {special_counters = 0, damage_target_card = -1, state = 130, damage_source_player = 65791, damage_on_card = 0, counter_power = 0,
  unknown0x14 = 0, token_status = 16, counter_toughness = 0, dummy31 = 4, dummy3 = 0, blocking = 255, extra_ability = 0,
  regen_status = 134217760, unknown0x2C = 0, unknown0x2E = 0, unknown0x30 = 0, power = 1, number_of_targets = 0 '\000',
  unknown0x37 = 0 '\000', info_slot = 0, unknown0x3C = 2457, unknown0x40 = 0 '\000', padding1 = "\000\000", unknown0x44 = 0 '\000',
  padding2 = "\000\000", damage_source_card = -1, eot_toughness = 0, damage_target_player = 255, unknown0x54 = 20, mana_color = 4 '\004',
  card_color = 4 '\004', padding3 = "\000", unknown0x5C = 0, unknown0x60 = 54, unknown0x64 = 0, kill_code = 0, internal_card_id = 2457,
  unknown0x70 = 0, targets = {{player = -1, card = -1}, {player = -1, card = -1}, {player = -1, card = -1}, {player = -1, card = -1},
      {player = 0, card = -1}, {player = -1, card = 0}, {player = 0, card = 0}, {player = 0, card = 0}, {player = 0, card = -1},
      {player = -1, card = -1}, {player = -1, card = -1}, {player = -1, card = -1}, {player = -1, card = -1}, {player = -1, card = -1},
      {player = 0, card = -1}, {player = -1, card = -1}, {player = -1, card = -1}, {player = -1, card = -1}, {player = -1, card = -1}},
  parent_controller = -1, parent_card = -1, hack_mode = 0, unknown0x118 = 0, untap_status = 0, counters = 0 '\000', unknown0x121 = 0 '\000',
  unknown0x122 = 0, upkeep_colorless = 0 '\000', upkeep_black = 0 '\000', upkeep_blue = 0 '\000', upkeep_green = 0 '\000',
  upkeep_red = 0 '\000', upkeep_white = 0 '\000', unknown0x12A = 0}

[Korath]

Either works, just so long as it doesn't get closed, archived, and forgotten.