[fixed/closed]Wrong Parameters in damage_effects()

[Korath]

It needs to be done when building ManalinkEh.dll.

[triol]

Thanks

[triol]

I add a new pop up, different than the 0x223b5af address, so I report it

I don't know what AI was trying to do...

I post another screen to show opponent's hand, it could be that AI tried to cast Breakthrough...

[triol]

This one happened when I was damaged by Psychic Venom.
Game crashes after this bug

PS : Don't hesitate to tell me if my reports are not usefull

[triol]

And one more while AI casts a fireball...

[Korath]

0x4017d4 and 0x477ea4 are in the exe. It's not immediately obvious what their functions (starting at 0x401730 and 0x477d90 respectively) are doing.

0x223b66f is in the wrapper for in_play(). It's got a lot of the same issues as get_card_instance(), and might benefit from having a stacktrace dumper inserted as well.

[triol]

Can anyone translate into basic words what Korath just said??

Hum! I don't know what a stacktrace is either...

[stassy]

Prolly what he meant some post ago, aka modify ManalinkEh.dll to log what happen and try to locate the error (in the src folder you have tools to compile the dll)

[triol]

Well... Has I don't know how to do this, I'll let professionals make reports

[gmzombie]

hey Korath im just curious what is your programming experience? im not questioning it or anything just curious. Do u do ASM by chance?

[Gargaroz]

Korath, thanx a lot for your work, but I don't really like the "lot of spam produced when building the DLL" part. Could you make something wrote in C to emulate the stuff you put in the patch ? We could add a check for "player == -1" or "card == -1" before the actual calling of the "real_get_card_instance".

[Korath]

The extra output during the build is needed only to translate hex addresses into function names. MSVC puts this debugging data into a .pdb file; gcc only lets you put it into the file itself (which doesn't work here, since it interferes with the addresses in manalink.asm) or to write it to stdout. It can be disabled for all but the final public build by not linking with the "MAP = -Wl,-M" I added to src/Makefile.

What I attached before isn't a binary patch; it's just output from git diff like I've been posting on other bugs. All of it is in C except for the perl script to translate dump.dmp files into function names.

hey Korath im just curious what is your programming experience? im not questioning it or anything just curious. Do u do ASM by chance?

I only speak baby asm. I took a one-semester course in 68000 assembly almost twenty years ago and haven't ever used it. No experience with x86 assembly except for what I google while puzzling out decompiler output.

[Sonic]

I only speak baby asm.

Well you're one up on most of us - we only speak stem cell asm.

[BAgate]

Korath, has this patch been applied, i.e. can we archive this issue or are you guys still working on it?

[Gargaroz]

Archive this, we overcome this through coding.