Page 1 of 1

[fixed/closed]Titania's Song

PostPosted: 18 Jun 2013, 03:42
by Althuna
Describe the Bug:
I bounced opponents Titania's Song back to his hand with Reality Strobe, but the artifacts it affect while it was in play, remained like that forever. (Although new artifacts came in to play as normal)

Which card did behave improperly ?
Titania's Song

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Latest, normal game.


What exactly should be the correct behavior/interaction ?
If Titania's Song leaves the battlefield, this effect continues until end of turn.

Are any other cards possibly affected by this bug ?
Not sure

Re: Titania's Song

PostPosted: 18 Jun 2013, 08:02
by stassy
confirmed in PDMNv2, seems spell that return target permanent to owner hand like Disperse will bug Titania's Song effect.

Reality Strobe also has some bugs :

- When casting Reality Strobe with suspend, if player cancel the cast, game still ask for target permanent (targeting or not just cancel the spell)

- After casting Reality Strobe with suspend and once the legacy effect is in the bf, game ask again for target permanent (targeting or not do nothing)

- After casting Reality Strobe you no longer be able to cast non artifact spell (sorcery or enchantment afaik), until you cast at least one artifact.

Image

Re: [confirmed]Titania's Song

PostPosted: 18 Jun 2013, 13:46
by Gargaroz
Hardcoded bugs are hardcoded. And the kind of artifact animation of Titania's Song is still obscure. Waitlisted.

Re: [confirmed-wait]Titania's Song

PostPosted: 26 Jun 2013, 18:58
by gmzombie
i dont know if this will help but i took the code directly from ollydbg at least this what one of my older ct files says it is. maybe korath can take a peak since he can read baby asm?

Re: [confirmed-wait]Titania's Song

PostPosted: 26 Jun 2013, 21:40
by Korath
I actually looked at Titania's Song in passing yesterday. It seems to create a new card type for each artifact it sees, then modifies it into a creature, the same way Kormus Bell and Living Lands do. (This is a real problem; there were definitely only 16 slots available for dynamically-created card types before the 2k barrier was broken, and seems to be only about that many now, too.)

And yes, it only recognizes EVENT_GRAVEYARD_FROM_PLAY to turn its effect off. What else needs to be looked for? EVENT_RESOLVE_TRIGGER with TRIGGER_BOUNCE_PERMANENT? Any others?

Re: [confirmed-wait]Titania's Song

PostPosted: 26 Jun 2013, 22:05
by gmzombie
hey Korath if you need this i have a list of card pointers in the magic.exe for the original cards that we coded into the exe. i dont know if it will help at all maybe it will reduce time looking for stuff. here it is

Re: [confirmed-wait]Titania's Song

PostPosted: 27 Jun 2013, 15:12
by Gargaroz
Well, Titania's Song could be almost recoded (the flag for disabling abilities is already there, the code for animating an artifact too). The only drawback will be that cards not coded in C wouldn't be affected by the "disable abilities" part.
@ Korath : so, there's already a code for :
1) Animated Artifact
2) Animated Lands
3) Nonartifact turn into artifact (Ashnod's Trasmogrant)
And then ? There were others ?
We already borrowed the code for Animated Artifact, I hope we could do that for Animated Lands too...

Re: [confirmed-wait]Titania's Song

PostPosted: 27 Jun 2013, 17:13
by Korath
Well, card_animate_artifact() and card_ashnods_transmogrant() in the exe work by creating a card type, too, so no help there. (So do the multi-block creatures, Blaze of Glory, and Copy Artifact.) My understanding was that self-animating lands like Celestial Colonnade work by having a different card for the animated version.

Re: [confirmed-wait]Titania's Song

PostPosted: 28 Jun 2013, 00:05
by Gargaroz
Yup, right Korath, for each "animable" land / enchantemt we have a "double" which is invoked by altering the "internal_card_id" (check the "double_faced_card" and "cloning" functions for more infos). Living Lands is doing the same thing ?

Re: [confirmed-wait]Titania's Song

PostPosted: 28 Jun 2013, 00:54
by Korath
Yes, except it's actually constructing a new entry in cards_data[] for each land type it affects, rather than using a pre-built one.

Re: [waitlist]Titania's Song

PostPosted: 22 Mar 2014, 01:09
by Gargaroz
Made a new code in 63a37e1. Consider this fixed.

Re: [fixed]Titania's Song

PostPosted: 22 Mar 2014, 07:39
by Korath
Doesn't even sort of work.

Re: [confirmed]Titania's Song

PostPosted: 27 Mar 2014, 14:20
by Gargaroz
Fixe & tested in efdf9a8