It is currently 08 Jul 2021, 04:57
   
Text Size

[fixed/closed]Maelstrom Wanderer

Moderators: BAgate, drool66, stassy, Aswan jaguar, gmzombie, CCGHQ Admins

[fixed/closed]Maelstrom Wanderer

Postby quox » 29 Sep 2013, 11:32

Describe the Bug:

Cascade doesnt trigger when maelstrom wanderer is cast from command zone, Also doesnt act like a legendary creature

Which card did behave improperly ?

Maelstrom Wanderer

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
September V2, commander game.


What exactly should be the correct behavior/interaction ?

Cast maelstrom wanderer from command zone, get cascade, cascade trigger. Also should count as legendary.

Are any other cards possibly affected by this bug ?
All other cascade cards seem to work, casting maelstrom from hand works too.
Last edited by Aswan jaguar on 14 Sep 2014, 13:00, edited 7 times in total.
Reason: fixed/closed
quox
 
Posts: 10
Joined: 30 Apr 2013, 04:01
Has thanked: 0 time
Been thanked: 0 time

Re: Maelstrom Wanderer

Postby Gargaroz » 29 Sep 2013, 14:06

Fixed both.
----
- Current / medium term task: adjusting the code for making Misdirection and such usable
- Long term task: inserting all the good stuff I left out from the "Golden Years" mod
Gargaroz
Programmer
 
Posts: 7095
Joined: 06 Nov 2009, 11:11
Has thanked: 82 times
Been thanked: 593 times

Re: [fixed both Gargaroz]Maelstrom Wanderer

Postby Nexhro » 16 Mar 2014, 11:15

Still doesn't trigger, but legend rule applies. BotG v2
User avatar
Nexhro
 
Posts: 1613
Joined: 23 Jan 2014, 18:08
Location: HRO, UTC +1
Has thanked: 78 times
Been thanked: 103 times

Re: [still bugged]Maelstrom Wanderer

Postby Gargaroz » 18 Mar 2014, 16:35

Fixed in 79697e4.
Also fixed the inverse problem for the other creatures with Cascade (they will trigger if copied or putted into play) in 2c46d5b
----
- Current / medium term task: adjusting the code for making Misdirection and such usable
- Long term task: inserting all the good stuff I left out from the "Golden Years" mod
Gargaroz
Programmer
 
Posts: 7095
Joined: 06 Nov 2009, 11:11
Has thanked: 82 times
Been thanked: 593 times

Re: [fixed by Gargaroz]Maelstrom Wanderer

Postby Korath » 18 Mar 2014, 23:32

Looks like it'll trigger now if it's animated, put into play by Elvish Piper, etc - is_token(), as it currently uses, will only detect token creatures and copied spells, which are only a small subset of ways to put it into play without casting it.

It's a harder problem than it appears. I suspect the way forward is to make a SF_WASNT_CAST flag and use that explicitly for this sort of check, instead of reusing various combinations of SF_PLAYED_FOR_FREE (which is set in far too many cases), SF_NOT_PLAYED_FROM_HAND, !is_token(), etc. Where a card was played from, whether its mana cost was paid, and whether the card was cast are all independent from each other.

Initially-reported bug affects at least the Eldrazi legends too, btw.
---
Now that I've read further commits, it looks like it'll do exactly the same as it was before - you're just checking SF_NOT_PLAYED_FROM_HAND directly now instead of through not_played_from_hand().
User avatar
Korath
DEVELOPER
 
Posts: 3522
Joined: 02 Jun 2013, 05:57
Has thanked: 491 times
Been thanked: 1037 times

Re: [confirmed]Maelstrom Wanderer

Postby Gargaroz » 19 Mar 2014, 17:44

Actually, the "SF_NOT_PLAYED_FROM_HAND" was designed specifically to be used in the frontend function for "put_into_play_exe", which is "put_into_play".
And yes, it's a bad name, I'll change it, however is applied only by that function, which should be used instead on "put_into_play_exe" in all the case in which the spell is not strictly "played" (put into play from any zone and similar).
I'd have to devise something more specifical to be used with Phage, the Untouchable...
----
- Current / medium term task: adjusting the code for making Misdirection and such usable
- Long term task: inserting all the good stuff I left out from the "Golden Years" mod
Gargaroz
Programmer
 
Posts: 7095
Joined: 06 Nov 2009, 11:11
Has thanked: 82 times
Been thanked: 593 times

Re: [confirmed]Maelstrom Wanderer

Postby Korath » 20 Mar 2014, 12:57

Current usage is much closer to "not played from hand" than "not cast". Commit 6964149b is relevant.
User avatar
Korath
DEVELOPER
 
Posts: 3522
Joined: 02 Jun 2013, 05:57
Has thanked: 491 times
Been thanked: 1037 times

Re: [confirmed]Maelstrom Wanderer

Postby Gargaroz » 22 Mar 2014, 13:37

Well, it seems we'll require to have separate functions for each zone from wich a card is "played for free" and dedicated flags. I'll look into it.
----
- Current / medium term task: adjusting the code for making Misdirection and such usable
- Long term task: inserting all the good stuff I left out from the "Golden Years" mod
Gargaroz
Programmer
 
Posts: 7095
Joined: 06 Nov 2009, 11:11
Has thanked: 82 times
Been thanked: 593 times

Re: [confirmed]Maelstrom Wanderer

Postby Gargaroz » 09 Jul 2014, 15:43

As now, we're able to identify from which zone a spell was played, so this bug is fixed.
----
- Current / medium term task: adjusting the code for making Misdirection and such usable
- Long term task: inserting all the good stuff I left out from the "Golden Years" mod
Gargaroz
Programmer
 
Posts: 7095
Joined: 06 Nov 2009, 11:11
Has thanked: 82 times
Been thanked: 593 times

Re: [fixed]Maelstrom Wanderer

Postby Nexhro » 14 Sep 2014, 12:35

As of CoRM15, cascade works as intended when Maelstrom Wanderer is cast from its owner's command zone.
User avatar
Nexhro
 
Posts: 1613
Joined: 23 Jan 2014, 18:08
Location: HRO, UTC +1
Has thanked: 78 times
Been thanked: 103 times


Return to Archived Reports

Who is online

Users browsing this forum: No registered users and 5 guests


Who is online

In total there are 5 users online :: 0 registered, 0 hidden and 5 guests (based on users active over the past 10 minutes)
Most users ever online was 1922 on 07 Jun 2021, 06:01

Users browsing this forum: No registered users and 5 guests

Login Form