Collectible Card Game Headquarters

Describe the Bug:

Cascade doesnt trigger when maelstrom wanderer is cast from command zone, Also doesnt act like a legendary creature

Which card did behave improperly ?

Maelstrom Wanderer

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
September V2, commander game.


What exactly should be the correct behavior/interaction ?

Cast maelstrom wanderer from command zone, get cascade, cascade trigger. Also should count as legendary.

Are any other cards possibly affected by this bug ?
All other cascade cards seem to work, casting maelstrom from hand works too.

Fixed both.

Still doesn't trigger, but legend rule applies. BotG v2

Fixed in 79697e4.
Also fixed the inverse problem for the other creatures with Cascade (they will trigger if copied or putted into play) in 2c46d5b

Looks like it'll trigger now if it's animated, put into play by Elvish Piper, etc - is_token(), as it currently uses, will only detect token creatures and copied spells, which are only a small subset of ways to put it into play without casting it.

It's a harder problem than it appears. I suspect the way forward is to make a SF_WASNT_CAST flag and use that explicitly for this sort of check, instead of reusing various combinations of SF_PLAYED_FOR_FREE (which is set in far too many cases), SF_NOT_PLAYED_FROM_HAND, !is_token(), etc. Where a card was played from, whether its mana cost was paid, and whether the card was cast are all independent from each other.

Initially-reported bug affects at least the Eldrazi legends too, btw.
---
Now that I've read further commits, it looks like it'll do exactly the same as it was before - you're just checking SF_NOT_PLAYED_FROM_HAND directly now instead of through not_played_from_hand().

Actually, the "SF_NOT_PLAYED_FROM_HAND" was designed specifically to be used in the frontend function for "put_into_play_exe", which is "put_into_play".
And yes, it's a bad name, I'll change it, however is applied only by that function, which should be used instead on "put_into_play_exe" in all the case in which the spell is not strictly "played" (put into play from any zone and similar).
I'd have to devise something more specifical to be used with Phage, the Untouchable...

Current usage is much closer to "not played from hand" than "not cast". Commit 6964149b is relevant.

Well, it seems we'll require to have separate functions for each zone from wich a card is "played for free" and dedicated flags. I'll look into it.

As now, we're able to identify from which zone a spell was played, so this bug is fixed.

As of CoRM15, cascade works as intended when Maelstrom Wanderer is cast from its owner's command zone.