[fixed/closed]Qasali Ambusher

by **HarlequinCasts** » 11 Nov 2013, 09:36

Describe the Bug:
Qasali Ambusher seems to be uncastable during main phase although it lights up yellow as castable.

Previous bug I reported delt with the Qasali Ambusher showing up as castable via flash even when it was not. This still appears to be a problem for example during the end step of an opponents turn it lights up.

Previous Bug

Which card did behave improperly ?
Qasali Ambusher

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
OoAv2

What exactly should be the correct behavior/interaction ?
Flash alternate cost, otherwise normal casting cost.

Are any other cards possibly affected by this bug ?
NA

by **Korath** » 11 Nov 2013, 10:08

OoAv2 was deployed 28 Sep 2013.

by **HarlequinCasts** » 11 Nov 2013, 11:06

>.< My bad

by **Aswan jaguar** » 11 Nov 2013, 15:46

Korath was the Cip - flash creatures that target- disenchant issue fixed also?

Korath said:
The bit about disenchanting at cip is clearly out of place, and the ai modifier just delays casting (sometimes, and not very well); the only important bit seems to be the EVENT_CAN_CAST handler. I'll experiment.
---
Turns out the yellow "you can cast this" text and whether you can actually cast the card don't use the same logic for cards that are both (instants/interrupts/sorceries/enchantments) and (artifacts/creatures) - the yellow text doesn't check EVENT_CAN_CAST for these, while actually clicking on them to cast them does, which is why not calling flash() didn't suppress the text color. Fixed d2b2dc6.

by **Korath** » 11 Nov 2013, 20:28

I copied flash() into C, mostly for clarity, and removed that part. The only things calling the asm version now are Ashcoat Bear, Benalish Knight, Havenwood Wurm, Nephalia Seakite, Skyline Predator, Spire Monitor (all directly) and Bogardan Hellkite (indirectly). I can't see how any of those can get a target while being cast - the hellkite's cip trigger is implemented as a trigger, not as part of casting like most cip triggers are in C - so there's nothing disenchanting that shouldn't anymore. (A good test case for the bug is Indomitable Will and either artifact creatures or Enchanted Evening.)

There's some small chance that a card in C actually relied on this behavior, in which case I broke it. I'll try to remember to look.