Collectible Card Game Headquarters

As with any update I have been looking for bugs regarding edh, this is what I have found.

Theros gods can't be used as generals.
All "Add X mana of any color..." cards are broken as they have ilegal mana symbols, including Nykthos.
Jenara cannot be used as a general.

I'll keep testing for more bugs.

*** thread closed, issue now in http://www.slightlymagic.net/forum/viewtopic.php?f=86&t=13382. ***

Not a bug but a case of outdated construction rules: Kokusho is no longer banned as one of the 99.

Well, I updated the banlists and enabled God cards as generals.
Nykthos had bad values in "ct_all" and is fixed, but I need a list of the other cards that report incorrectly illegal mana symbols.
Also Jenara seems fine, I really don't know why is rejected...

Sorry, my fault. I failed to add the Theros Legendary Creatures to the '(HI / EDH) Legal as Commander' column in the manalink file.

Nothing's looking at those set/rarity columns except for draft and drawcardlib; the gods needed hardcoding because they're not creatures while not in play.

My concern was that because the Theros God/Legendary cards didn't show up in the deck builder 'Legal as Commander' filter, Stroggoii may have got the impression that the God cards weren't available to EDH. Whereas it was simply a case of the data for the filter needing updating.

Stroggoii wrote:Not a bug but a case of outdated construction rules: Kokusho is no longer banned as one of the 99.

Not according to the EDH web site Deck Construction banned list (updated Oct 29th, 2013)

http://mtgcommander.net/rules.php

Additionally the following legends may not be used as a Commander:

Braids, Cabal Minion
Rofellos, Llanowar Emissary
Erayo, Soratami Ascendant
Kokusho, the Evening Star

Sonic, there it says "Kokusho is no longer banned as one of the 99", which she isn't. She used to be banned both as a general and as a card, now it's only banned as a general, and that's the rule that was outdated.

@Gargaroz, the cards I've found to have ilegal symbols are:
Gemstone Mine
Glimmervoid
Rupture Spire
Thran Quarry
Rainbow Vale
Forbidden Orchard
Transguild Pomenade
City of Brass
Grand Coliseum
Undiscovered Paradise
Unknown Shores
Phyrexian Altar
Lotus Petal
Chromatic Lantern
Vessel of Endless Rest
Manalith
Coalition Relic
Mox Opal
Mox Diamond
Darksteel Ingot

Pseudocode:

Code: Select all

int color = /* general's colors */;
...
int c2 = cards_data[deck[i]].color;
if (/* not a special card, a land, or a mana-generating artifact */){
    if (/* (c2 & color) != c2 */){
        /* complain("Illegal color") */
    }
}
c2 |= get_color_from_remainder_text(id); // i.e., c2 = cards_data[deck[i]].color | get_color_from_remainder_text(id)
if (/* (c2 & color) != c2 */){
    /* complain("Illegal mana symbols in text") */
}

Stroggoii wrote:Sonic, there it says "Kokusho is no longer banned as one of the 99", which she isn't. She used to be banned both as a general and as a card, now it's only banned as a general, and that's the rule that was outdated.

Ah, got it. I couldn't find the specific rule change on the EDH website, but a number of other MTG card sites mention the change. The card is already filtered correctly as per the rule change in the Deckbuilder Tournament filter, and I've now removed Jenara from the 'Legal as Commander' filtering.

Inserted Korath's suggestion. Hope everything is fine now. Korath, could you please double check ?

Is this fix a global fix and covers all cases as people keep reporting bugs from cards that are found illegal for EDH but are not normally?Or each card has to be inserted in a list or recoded?

What I posted earlier was what was currently being done; I'd hoped to make it obvious by hiding all the boilerplate.

You're carefully not rejecting cards based on card_data_t::color if they're lands/non-mana-producing-artifacts/planes. This much is good.

Then you parse the rules text for e.g. |B symbols. This is also right.

But instead of comparing just the parsed results to your bitset of legal colors, you compare the parsed results and card_data_t::color again against it.

So City of Brass, whose card_data_t::color is COLOR_TEST_WHITE|COLOR_TEST_BLUE|COLOR_TEST_BLACK|COLOR_TEST_RED|COLOR_TEST_GREEN, isn't rejected in the first pass (because it's a land, and you check for that), but is in the second - get_color_from_remainder_text() returns 0, c2 is still COLOR_TEST_WHITE|COLOR_TEST_BLUE|COLOR_TEST_BLACK|COLOR_TEST_RED|COLOR_TEST_GREEN, you bitwise or that with 0 and get COLOR_TEST_WHITE|COLOR_TEST_BLUE|COLOR_TEST_BLACK|COLOR_TEST_RED|COLOR_TEST_GREEN, and reject that for having illegal colors.

Just set c2 = get_color_from_remainder_text() in the middle there, instead of |=, and all should be well.

Stroggoii wrote:
@Gargaroz, the cards I've found to have ilegal symbols are:
Gemstone Mine
Glimmervoid
Rupture Spire
Thran Quarry
Rainbow Vale
Forbidden Orchard
Transguild Pomenade
City of Brass
Grand Coliseum
Undiscovered Paradise
Unknown Shores
Phyrexian Altar
Lotus Petal
Chromatic Lantern
Vessel of Endless Rest
Manalith
Coalition Relic
Mox Opal
Mox Diamond
Darksteel Ingot

You aren't saying these are to be illegal in EDH are you? I noticed these are no longer usable in my decks, but according to mtgcommander.net Rule 4 states:

4.A deck may not generate mana outside its colours. If an effect would generate mana of an illegal colour, it generates colourless mana instead.

Strangely enough, many of the installed decks that came with the game use Power 9 which are banned and is frustrating to see slide by.

Are you saying that it produces colors that it's not meant to in the game?

I hope they fix this soon. Many of my decks are not usable now...

The latest EDH banlist will be enforced with the next patch.
Darkgaizat, that cards are not illegal in EDH, they're just considered illegal as there were a bug in the color parsing code, although I didn't understand what you were talking about when you mentioned the Moxes.