Page 1 of 2

[fixed/closed]Jace, Architect of Thought Ultimate Crashes

PostPosted: 20 Jan 2014, 21:30
by HarlequinCasts
Describe the Bug:
Activating Jace, Architect of Thought 's ultimate will sometimes cause the game to crash.I definitely have had it work correctly numerous times, but this save file seems to be an example where it will crash.

Sorry I don't have more to go on. The deck I use it with is a Battle of Wits deck, and like I said, it has worked plenty of times before. I do not know which AI deck is used in this particular game.

EDIT: The problem seems to be activating it during the first main phase for some reason. This save works fine if you activate it during phase 2. And also the problem seems to be only when activating the ultimate would destroy jace. If he has more counters than needed it works fine in phase 1...

EDIT (Journey into Nyx May 2014): Seems to crash everytime it is activated now.

EDIT (M15 Sept 2014): Game locks up upon activation of ultimate

Which card did behave improperly ?
Jace, Architect of Thought

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
CIAv2 Jan 2014
Gauntlet

What exactly should be the correct behavior/interaction ?
Jace, Architect of Thought

Are any other cards possibly affected by this bug ?
NA

Re: Jace, Architect of Thought

PostPosted: 20 Jan 2014, 21:36
by Korath
I can't load your save. Able to get me a crash offset (like this)?

Re: Jace, Architect of Thought

PostPosted: 20 Jan 2014, 21:45
by HarlequinCasts
Bam!

Problem signature:
Problem Event Name: APPCRASH
Application Name: Magic.exe
Application Version: 7.0.0.0
Application Timestamp: 4e000000
Fault Module Name: manalinkeh.dll
Fault Module Version: 0.0.0.0
Fault Module Timestamp: 52d2a673
Exception Code: c0000005
Exception Offset: 00302cae
OS Version: 6.1.7601.2.1.0.768.3
Locale ID: 1033
Additional Information 1: 0a9e
Additional Information 2: 0a9e372d3b4ad19135b953a78882e789
Additional Information 3: 0a9e
Additional Information 4: 0a9e372d3b4ad19135b953a78882e789

Re: Jace, Architect of Thought

PostPosted: 20 Jan 2014, 22:40
by Korath
OK, hrm. It's crashing in create_card_instance(), at "card_data_t* cd = cards_at_7c7000[iid];". No way to find out what iid was, and I don't know yet whether Jace himself provoked it (though his code looks ok) or whatever spell he tried to copy did. I'll add an assertion in here so that it'll give us a clean backtrace if it happens again. There's also a (small) chance that figuring out the AI's deck might help me reproduce it.

(Besides the crash, he creates extra copies of permanents in their owner's graveyard, doesn't flag the other player's spell as stolen when it becomes a permanent, doesn't exile the spells, doesn't work properly with non-permanent spells that go somewhere other than the graveyard when they resolve, and doesn't give you an option not to cast the chosen spells. Whew.)

Re: Jace, Architect of Thought

PostPosted: 20 Jan 2014, 22:51
by HarlequinCasts
I'll keep watching for the original bug. But I guess it doesn't surprise me that its some interaction with the enemy deck.

However,

OTHER BUG: You can select lands with his ultimate. Should be non-land.

Re: Jace, Architect of Thought

PostPosted: 20 Jan 2014, 23:00
by Korath
Well, that at least is easy to fix, and I've done so in 84f1e93.

Be aware it won't let you select interrupts, either; mostly this is unavoidable due to the way Fork and Counterspell effects are implemented (they'd blow up, since there isn't a spell on top of the stack for them to target), but e.g. Dark Ritual and Cryptic Command and Red Elemental Blast and Sleight of Mind should all in theory be castable in their don't-target-a-spell modes.

Re: Jace, Architect of Thought

PostPosted: 20 Jan 2014, 23:36
by Aswan jaguar
I tried your savegame and I didn't get a crash in 1st main phase even if it used all it's loyalty and went to graveyard later.(according to your edit).
Which cards did you selected with it's ultimate to play for free?Did it crash after you selected cards from both players?or just from you(first-player)?

EDIT :I confirm the bug and I found that it crashes at least with this savegame at any main phase if you have cast previously any spell.If you activate it before you play a spell it works correctly.

Re: [confirmed-new info]Jace, Architect of Thought

PostPosted: 20 Jan 2014, 23:59
by HarlequinCasts
Yeah Aswan, for me (when it does crash) it crashes as soon as I select the ultimate ability from the menu, it never gets to any card prompts.

Re: [confirmed-new info]Jace, Architect of Thought

PostPosted: 21 Jan 2014, 00:26
by Korath
Repro, alas, is restricted to that save game (which I can't get to load even with released CrIAv2) - I can put Jace and a Doubling Season in my hand in a clean game, debug enough mana to cast them both, cast the Doubling Season, cast Jace, active Jace's third ability, and not crash.

Re: [confirmed-new info]Jace, Architect of Thought

PostPosted: 21 Jan 2014, 02:02
by HarlequinCasts
Somewhat of a result: I did a grep search for some of the cards and found the AI's deck based on its library (included).

Gave myself a doubling season and a Jace and it crashed once again in the same way. But it doesn't always crash so I have no clue... (second crash report below -seems the same)

Problem Event Name: APPCRASH
Application Name: Magic.exe
Application Version: 7.0.0.0
Application Timestamp: 4e000000
Fault Module Name: manalinkeh.dll
Fault Module Version: 0.0.0.0
Fault Module Timestamp: 52d2a673
Exception Code: c0000005
Exception Offset: 00302cae
OS Version: 6.1.7601.2.1.0.768.3
Locale ID: 1033
Additional Information 1: 0a9e
Additional Information 2: 0a9e372d3b4ad19135b953a78882e789
Additional Information 3: 0a9e
Additional Information 4: 0a9e372d3b4ad19135b953a78882e789

Re: [confirmed-new info]Jace, Architect of Thought

PostPosted: 22 Jan 2014, 08:43
by HarlequinCasts
Encountered the bug again in a totally different game. Same module/offset.

Attached is the save. Again it does not always crash for whatever reason. But just like Aswan said, the commonality is that the ultimate is the first thing used in main phase 1 prior to casting anything else. Crash happens before targets are chosen, but after Jace is put in the graveyard (as seen in screenshot).

EDIT: Have reproduced multiple times with this save, but sometimes it takes upwards of 5 tries before the save crashes even with the same exact inputs each time.

Re: [confirmed-new info]Jace, Architect of Thought

PostPosted: 27 Jan 2014, 23:31
by HarlequinCasts
Aha! I just had an epiphany! This bug is the exact same as the one about Show and Tell & Engineered Explosives

What's happening is that Jace's ultimate is crashing because it can search your own library and Engineered Explosives is in there in this save game. Tested in a clean game, and removing the Engineered Explosives prevents the Jace ultimate crash.

(This thread can be closed the above link will redirect anyone).

Re: [not a bug]Jace, Architect of Thought

PostPosted: 28 Jan 2014, 04:50
by HarlequinCasts
Damnit I spoke too soon sorry. I can still sometimes crash the game with Jace's ultimate, even without Engineered Explosives in the deck. Same offset as reported before... This may still be a separate bug after all...

Attached a new save where Jace may crash using his ult even without an engineered explosives.

Re: [confirmed]Jace, Architect of Thought

PostPosted: 19 Mar 2014, 02:38
by HarlequinCasts
As of BNG v2 Jace, Architect of Thought 's ultimate leaves your library (and presumably your opponent's libary) in alphabetical order.

In the screen shot I used Jace on my turn and then drew a ton of cards with Sphinx's Revelation. As you can see they are alphabetical.

Re: [confirmed]Jace, Architect of Thought

PostPosted: 19 Mar 2014, 03:07
by BAgate
Opponent's library is NOT effected (it is randomized).