Page 1 of 1

[fixed/closed]Stuffy Doll/Vigor/Rite of Passage

PostPosted: 28 Jul 2014, 17:59
by RanDomino
Describe the Bug:
These problems are kind of entangled so I'll describe them together. If that doesn't work I can try to break them up into separate bug reports. I understand that these problems likely stem from Indestructible being kind of as good as it gets.
1) Stuffy Doll + Vigor or Rite of Passage: Stuffy Doll does not get the +1/+1 counter(s).
2) Stuffy Doll + Vigor: When Stuffy Doll would be dealt damage, Vigor is supposed to prevent the damage entirely, meaning Stuffy Doll's trigger shouldn't happen. However, Stuffy Doll still deals the damage to the opponent.
Vigor + Stuffy Doll 1.png
Above: Immediately before activating Thrashing Wumpus while Stuffy Doll and Vigor are in play.
Vigor + Stuffy Doll 3.png
Above: Immediately after the Thrashing Wumpus ability and all replacement effects and triggers resolve. Vigor was dealt 1 point of damage. Thrashing Wumpus would have been dealt 1 damage, but Vigor replaced it with a +1/+1 counter. Both players were dealt 1 damage by Thrashing Wumpus. Stuffy Doll was improperly dealt 1 damage by Thrashing Wumpus, which it then dutifully redirected to the opponent.

3) Rite of Passage: The +1/+1 counter gets added before SBEs get checked, so 1/1s survive being dealt 1 damage, and creatures survive combat when they shouldn't
Rite of Passage.png
Above: The AI attacked with a 1/2 Voyaging Satyr and I blocked with a 1/1 Veteran Explorer. Both creatures survived, having dealt 1 damage to each other.

Which card did behave improperly ?
Stuffy Doll, Rite of Passage, and/or Vigor

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Journey into Nyx, Gauntlet

What exactly should be the correct behavior/interaction ?
1) Stuffy Doll should get the +1/+1 counter(s) and have 1 point of damage marked (of course, the damage mark is mostly cosmetic).
2) Stuffy Doll should not deal damage to the opponent, because Vigor prevents damage that would be dealt to Stuffy Doll, meaning its trigger should not happen.
3) Creatures dealt lethal damage before the Rite of Passage trigger should die.

Are any other cards possibly affected by this bug ?
Surprisingly, Fungus Sliver seems to work properly despite being phrased identically to Rite of Passage (i.e. it gets the counter immediately as a triggered ability, rather than at EoT as a delayed trigger as with Fungusaur). I tested it both in combat and with spell damage, so it may be possible to raid its code to correct Rite of Passage.

Re: Stuffy Doll/Vigor/Rite of Passage

PostPosted: 31 Jul 2014, 14:20
by Gargaroz
The culprit is Stuffy Doll: its code was a bit clumsy and was redone in a0bb71e