Collectible Card Game Headquarters

Describe the Bug:
Oran-Rief, the Vastwood gives counters to all creatures that came into play this turn.

Which card did behave improperly ?
Oran-Rief, the Vastwood

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Manalink 2016/08/27: Eldritch Moon v2, duel

What exactly should be the correct behavior/interaction ?
Just green creatures.

Are any other cards possibly affected by this bug ?
-

Yup, and affects Ruins of Oran-Rief too. In zendikar.c:activate_oran_rief_pump():

Code: Select all

if( color == 0 || (get_sleighted_color_test(p, c, COLOR_TEST_GREEN) & COLOR_TEST_GREEN) ){

What this does is allow the creature in question (represented by the pair {p, c}) to get a counter if either

• No color restrictions have been requested. (Not the same thing as asking for COLOR_TEST_COLORLESS, like Ruins of Oran-Rief does.) Or...
• A "green" appearing in the creature's rules text still means "green" after accounting for Sleight of Mind.

To fix Oran-Rief, the Vastwood, the second half of that condition should look like "get_sleighted_color_test(player, card, color) & get_color(p, c)". (Or, better, just compute get_sleighted_color_test(player, card, color) once, since it'll be the same for all {p, c}.)

Fixing Ruins of Oran-Rief needs an explicit check of color == COLOR_TEST_COLORLESS, in which case we're looking for !(get_color(p, c) & COLOR_TEST_ANY_COLORED).

Fixed Ruins of Oran-Rief in commit 9929ffd4 with new code with targeted ability as it should have.
Edit: Fixed Oran-Rief, the Vastwood doesn't pump anything or everything in commit e3ffeca.
Edit1: separate code for Novijen, Heart of Progress in commit b06c56b7 so they don't conflict with each other.