[fixed]Personal Incarnation damage redirection

[Korath]

Describe the Bug:
1. You can't activate a Personal Incarnation you own unless you also control it. The current wording is admittedly a bit ambiguous; but before its most recent Oracle update in... SOI? (after BFZ and no later than EMN, anyway) the part in question read "Any player may activate this ability, but only if he or she owns Personal Incarnation." and it was flagged as a non-functional wording change.
2. The entire damage card you pick gets redirected. If the AI hits your PI with a Lightning Bolt, you can redirect 3 or 0, but you can't redirect 1 or 2. fixed

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Dev cc940a2, well past EMN.

What exactly should be the correct behavior/interaction ?
1. Whoever owns a given Personal Incarnation can activate it, no matter who controls it.
2. Damage is redirected a point at a time.

Are any other cards possibly affected by this bug ?
Probably not. For the record, the other cards currently in Manalink that can be activated by someone other than their controller are Armageddon Clock, Clergy of the Holy Nimbus, Ifh-Biff Efreet, Knight of the Holy Nimbus, Merseine, and Volrath's Dungeon.

The original MicroProse version of this card (which Shandalar still uses) is even worse, by the way; only its controller can activate it, and it redirects damage to its owner. Fun times with Pariah or Shivan Meteor.

[Aswan jaguar]

The first bug is also mentioned here and if you see last post by Gargaroz he coded it like that:
viewtopic.php?f=110&t=15492&p=167394&hilit=Personal+Incarnation#p161721

[Korath]

It probably needs an effect card with EA_PROTECT set. I'd suggest hijacking either one of the ones that's no longer used, or making GuardianFX generalizeable like Asp Sting and RukhEggFX are.

[Aswan jaguar]

Fixed 2nd bug only in commit 2f6ea5a ("Personal Incarnation fix it prevents all damage.", 2021-03-22).

[drool66]

I'll work on the 1st bug once I can reach the server & get your work Aswan jaguar (assuming you haven't fixed it by that point)

[drool66]

I got everything working, but in order to do so I had to add Flag: Protect to the Naf's Asp legacy (ie. legacy_activate). The only other legacy I can think of that uses this is the Guardian Angel legacy, which also needed some changes to get it to work properly. Anyone see any complications in doing this?

[Korath]

Yes. EA_PROTECT means "can be activated or cast during damage prevention". Setting it on legacy_activate will affect everything that uses it. Take over one of the unused or single-use effect cards instead. Shandalar uses GuardianFX, which you mention, for this combination of flags (EA_PROTECT | EA_ACT_ABILITY); it can even use the same function as Asp Sting.

[drool66]

Thanks again, Korath
Fixed in 935783e