[fixed]Moonlit Strider can sacrifice any creature

by **Aswan jaguar** » 28 Apr 2018, 11:07

Describe the Bug:
Moonlit Strider 's ability prompts and can sacrifice any creature you control to grant protection from a color.

Which card did behave improperly?
Moonlit Strider

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Manalink dev 778ccb5 version - duel

What exactly should be the correct behavior/interaction?
Moonlit Strider 's ability cost is sacrifice Moonlit Strider itself.

Are any other cards possibly affected by this bug?
-

by **Aswan jaguar** » 22 Jun 2019, 08:27

Fixed in commit de54aae0. I noticed that the protection granted can't be sleighted although there is a flag KEYWORD_RECALC_SET_COLOR used with select_a_protection(player) for that and it is used by many cards. Is it Sleight of Mind's fault? was it broken?

by **Korath** » 22 Jun 2019, 12:21

It's not used with select_a_protection(); it's used with pump_ability_until_eot(), which honors Sleight of Mind- and Magical Hack-like effects on its own, and documents KEYWORD_RECALC_SET_COLOR as suppressing that. In this case, it's deliberately suppressed because the Sleight of Mind shouldn't do anything, since the chosen color isn't text on the card: if you sleight a Moonlit Strider from black to blue, then activate it and choose black, the targeted creature is still supposed to get protection from black. Without this flag, all pump_ability_until_eot() would see is the card activating to give the creature protection from black in exactly the same way Willow Priestess does, and update that to protection from blue.