[duplicate]Betrayal of Flesh: return creature doesn't work

[FastEddie]

Describe the Bug:
Betrayal of Flesh's return creature ability doesn't work. I cannot select a creature in my GY. When clicking on thr GY the pile opens but then I can't get farther.

Which card behaved improperly?
Betrayal of Flesh

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Version 5-2020 10bda4ca0
Duel

[Aswan jaguar]

Are you sure the issue is not more like the one I mention here:
viewtopic.php?f=86&t=22028&p=223914#p223914

[FastEddie]

I just gave it a try. Clicking on a land doesn't work and the message box explicitly requests a creature. This is how far I get:

I can open the graveyard but can't pick the Ascendant Evincar.

[Aswan jaguar]

It prompts you for creature to sacrifice.

[Aswan jaguar]

I am closing this as duplicate although it seems little different from the other report in fact they are the same once you fix that it prompts for creature to sacrifice instead of land. I will commit this and then the rest of bug is on the other report.

[FastEddie]

You were right. I fell for the crossed out "creatures", assuming that this part of the bug has been fixed (similar to other partly fixed bugs I saw).

[Aswan jaguar]

Fixed only prompts/needs creatures to sacrifice instead of lands in commit b3ec435 and closing this. I am quite fed up at the moment with this card.

[FastEddie]

Attached is a partial fix. Put it in the cards directory and apply

Code: Select all

patch mirrodin.c mirrodin.diff

The issue was the usage of the & operator. For example

Code: Select all

if (instance->info_slot & CHOICE_ENTWINE)

evaluates the brackets to 1, 2 or 3, depending on the choice stored in instance->info_slot, but this will always be at least 1, i.e. true. Therefore you always had to pay the Entwine cost.

Geek note: applying bitwise and with mask 0b11 (0b says that the following figures will be binary) on 0b01, 0b10 or 0b11 always preserves the input value.

Now the issue is that both kill and reanimate produce a get_card_instance(255,255) dump. Can it be that the stored target is overwritten?