[fix]Crash, get_card_instance(24248861, )

[gnomefry]

Is it helpful to report a crash such as this that happens each time a particular turn is loaded? Call from the Grave is not in either side's deck. Savegame and dump file attached. Thanks!

version 6-2020 v3 a8bbff706 - gauntlet

Code: Select all

bad parameters
get_card_instance(24248861, 24248861)
0: 0x02521348
1: 0x024D693E
2: 0x024E486B
3: 0x0043467C
4: 0x0043C147
5: 0x004399BD
6: 0x0047902C
7: 0x004946E9
8: 0x75F06359
9: 0x77D27B74
10: 0x77D27B44

[Aswan jaguar]

This bug is again about Arcbound Ravager but I don't know if this time is something that we changed lately in sacrifice code or elsewhere because the get_card_instance(24248861, 24248861) I think is quite different than others we had before and nothing has been changed to Arcbound Ravager's own code.

[FastEddie]

This is definitly something different. Usually parameters were (-1,-1) which means something wasn't set on the way. This is also not an overflow, so no simple explanation as of pixel time.

I might have a look into this later and see were I end up, but there are a few other bugs on my list that I would like to tackle first to get to know the code better.

Edit: I just got the same message in connection with Arcbound Ravager. Figures were identical down to position 8, so it looks like a certain function is called in a certain way (going up from 8 to 0) that it doesn't like. At least no randomness.

[gnomefry]

{Edit: I mixed up save files on this second crash. I'll strike this one out and make a new post if I can reproduce the crash. Sorry.}

Here's a crash message I get on the opponent's turn. The first numbers in the dump file are the same as the previous one in this thread. But this time the opponent is using what looks to be a mono-red deck.

The turn begins by the AI casting ball lightning and the crash seems to come with whatever it tries to do next. Savegame and dump file attached. Thanks!

version 6-2020 v3 a8bbff706 - gauntlet

Code: Select all

bad parameters
get_card_instance(24248861, 24248861)
0: 0x02521348
1: 0x024D693E
2: 0x024E486B
3: 0x0043467C
4: 0x0043C147
5: 0x004399BD
6: 0x0047902C
7: 0x004946E9
8: 0x75F06359
9: 0x77D27B74
10: 0x77D27B44


[Aswan jaguar]

When I load your savegame I get a crash but never a dump error.
Also the dump you uploaded is in fact about get_card_instance(24258771, 24258771) and not the one you have copy/pasted which is different in the 5 last numbers from first get_card_instance(24248861, 24248861).

[gnomefry]

Oh crumbs. Sorry, AJ. For this second crash I posted last night I must have mixed up the dump/save files I wanted to post. Which isn't helpful towards figuring it all out!

I'll strike-through the second post and be more careful with my posted files on the next crash.

[FastEddie]

The dump still makes kinda sense as the topmost address is the misbehaving function. Differences lower in the stack mean that the way taken to get this result was different but that doesn't invalidate it.

[drool66]

Jumping on this, maybe the conversation needs to move to the dev forum, but FastEddie, any way you can analyze what's happening in the Arcbound Ravager - Cranial Plating interaction? This is probably the most perplexing problem of all to me right now.

[FastEddie]

I had (resp am still having) a quick first look.

Following your suggestion I opened a new thread in the developers forum here:

https://www.slightlymagic.net/forum/viewtopic.php?f=56&t=29897

[FastEddie]

Can we mark this as partially fixed? Drool66 fixed it such that it doesn't carsh, although the solution is not perfect (but the best we have right now and I am glad for it).

[drool66]

I'm going to go ahead and mark this one fixed as of f0d1eb8 (Fix cases of illegal_state = TARGET_STATE_DYING / _DESTROYED - the one that fixed Arcbound Ravager)