[fixed]Lone Rider doesn't transform

by **gnomefry** » 01 Oct 2020, 19:33

Describe the Bug:

Lone Rider // It That Rides as One doesn't transform

Which card behaved improperly?

Lone Rider

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
version 8-2020 a62926f - gauntlet

What exactly should be the correct behavior/interaction?

At the beginning of the end step during a turn in which Lone Rider's controller gained 3 or more life, Lone Rider should transform into It That Rides as One.

Are any other cards possibly affected by this bug?

No.

by **Aswan jaguar** » 02 Oct 2020, 14:37

I confirm it doesn't transform normally but if ~~there isn't a rules engine in play it transforms like a charm~~ wrong assumption. Possibly the same bug is the main reason or one of the reasons for Luminarch Ascension bug also. I searched a little but couldn't find when this was broken.

EDIT: without the rules engine card goes the opposite way and it triggers all the time so definitely not working like a charm. #-o

by **drool66** » 03 Oct 2020, 05:30

Fixed though it was my fault to begin with. This happened in my fix of Medomai, the Ageless. I moved the traps to be cleared from EVENT_CAN_SKIP_TURN (ie. at the beginning of the next turn), to EVENT_CLEANUP. So the issue is the traps were cleared before these cards would trigger.

They all seem to be working now. I moved most traps to be cleared at EVENT_CAN_SKIP_TURN, switched TRAP_TURN_IS_EXTRA to persistent, and cleared it at EVENT_CLEANUP (which is the only time that it can be cleared and accurately reflect that the next turn is an extra turn). I'm recovering from surgery and on painkillers and I have not been that sharp today (just check my git commits #-o

), so I'll wait to test fully & commit until tomorrow.

EDIT thank you for the well-wishes! I'm doing much better and even back to work already. Committed in f17dfa8

by **Aswan jaguar** » 03 Oct 2020, 08:53

drool66 wrote: I'm recovering from surgery and on painkillers

My best wishes for fast and full recovery.

by **FastEddie** » 03 Oct 2020, 13:16

drool66 wrote:I'm recovering from surgery and on painkillers

Oh my gosh... get well soon! And remember: don't drink and code and I guess the same holds for painkillers

. The only painkiller I would recommend while coding is this one: https://www.youtube.com/watch?v=uie63E4gqno

by **gnomefry** » 04 Oct 2020, 15:02

Best wishes for a speedy and full recovery, drool66!