[fixed]Burning Vengance:no grave trigger for Gravecrawler

by **FastEddie** » 13 Nov 2020, 09:36

Describe the Bug:
Burning Vengeance doesn't trigger when I play Gravecrawler from my graveyard. It works fine for Think Twice and Faithless Looting, though.

Which card behaved improperly?
Burning Vengeance

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Version 10-2020 1.1 ee04575f
Duel

What exactly should be the correct behavior/interaction?
Burning Vengeance should trigger when a creature is played from the graveyard.

Are any other cards possibly affected by this bug?
No.

by **drool66** » 14 Nov 2020, 00:51

It's just because it's a creature & Burning Vengeance tests for TYPE_SPELL, which only includes sorceries, instants, and interrupts. Should be everything but lands. I think that's "TYPE_NONEFFECT ^ TYPE_LAND", right? (or just 1111110B / 126D)

EDIT nevermind, trigger_spell_cast() already checks for lands, so just TYPE_NONEFFECT works, or probably just TYPE_ANY

by **FastEddie** » 14 Nov 2020, 07:00

Use either TYPE_NONEFFECT or TYPE_SPELL | TYPE_CREATURE. TYPE_ANY is too broad and could cause issues in the future as we don't know which new types await us. Also, whenever you have enums don't do the bit math by hand as the enums might change and you will never ever figure that one out while retaining a single non-grey hair

.

Edit: ^ is the XOR operator. Try this with the windows calculator, it has a programmer's mode. You should get an interesting result. What you probably wanted was TYPE_NONEFFECT & ~TYPE_LAND.

by **Aswan jaguar** » 29 Nov 2020, 13:47

Fixed in commit e54a95e. I didn't see you guys pushing this for so many days so I decided to do it so it can be archived.