Page 1 of 1

[fixed] Lucent Liminid isn't castable

PostPosted: 19 Nov 2021, 09:53
by Korath
Describe the Bug:
Lucent Liminid gets highlighted yellow when you have sufficient mana to cast it, but nothing happens when you click on it.

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
dev 913cddcc6.

What exactly should be the correct behavior/interaction?
Same as any other vanilla creature.

Are any other cards possibly affected by this bug?
Any cards with any of TYPE_INTERRUPT, TYPE_INSTANT, TYPE_SORCERY, or TYPE_ENCHANTMENT set has to return 1 from EVENT_CAN_CAST to be playable. (Which is the only thing flash() and global_enchantment() do that accomplishes anything.) So Illusory Ambusher, at least, which doesn't have its trigger either. I could post a complete list of cards flagged one of those, CODED CARD, and at least one of TYPE_ARTIFACT, TYPE_CREATURE, or TYPE_LAND, but there's a lot of them, most are probably ok, and plenty haven't been announced as implemented yet.

Re: Lucent Liminid isn't castable

PostPosted: 19 Nov 2021, 19:01
by drool66
Weird, I could have sworn we had (french) vanilla enchantment creatures covered - didn't we have Nyxborn Colossus et al at one point?
These should probably just use 0x2023ca (Doubling Season)
So Illusory Ambusher, at least, which doesn't have its trigger either.
Looks like it's handled in effect_damage() when it should have a damage_dealt_to_me_arbitrary()
I could post a complete list of cards flagged one of those, CODED CARD, and at least one of TYPE_ARTIFACT, TYPE_CREATURE, or TYPE_LAND
Maybe TYPE_INTERRUPT, TYPE_INSTANT, TYPE_SORCERY, or TYPE_ENCHANTMENT + CODED CARD + CODE POINTER == 0x401000 or 0x000000 ? Certainly wouldn't be exhaustive, but everything on that list would be an error.

Re: Lucent Liminid isn't castable

PostPosted: 19 Nov 2021, 19:52
by Korath
Looks like we lost THB's cycle of five vanilla enchantment creatures and Knight of the Keep in commit 86a599c3f1. My fault. In my inadvertent defense, they used 0x401000 so wouldn't have worked anyway.

Looking specifically for 0x401000 was how I found Illusory Ambusher. It's the only one with that address that matches all the other conditions.

There aren't any cards as of 913cddcc6 marked CODED CARD with null function address; case 23 in test.pl looks specifically for them. It won't see emblems or backs of dfcs or alternate versions of e.g. the Theros bestow cards, though.

Re: [confirmed] Lucent Liminid isn't castable

PostPosted: 28 Nov 2021, 02:47
by drool66
Fixed in 3c76177