[fixed] Quarry Hauler adds/removes only one counter kind
Posted: 26 Nov 2021, 22:56Describe the Bug:
Quarry Hauler prompts to add or remove a counter; then prompts for a single counter kind from among the kinds on it (allowing "cancel"), then adds or removes it.
Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
dev 24315b234, edited locally to fix this bug.
What exactly should be the correct behavior/interaction?
Prompt for each kind of counter that's there; and for each kind, add or remove, but don't allow doing nothing. (In particular, if you've got a 1/1 creature with a -0/-1 counter on it and a +1/+1 counter on it, don't let it die after adding another -0/-1 counter but before you decide to add or remove a +1/+1 one.)
If you want to be extra fancy, list all the kinds that are there in a dialog, and allow toggling of each kind in any order; then add or remove them all at once when you pick "Done" at the end.
Are any other cards possibly affected by this bug?
Skyship Plunderer and Maulfist Revolutionary both do the same, though neither allows (nor should allow) you to pick "remove". They're easier than this; you can just call increment_all_counters() for them when they're targeting permanents.
None of them have a thing to do with proliferate, in any case, and shouldn't be calling proliferate-named functions just in case proliferate gets another round of arbitrary power-level errata.
Quarry Hauler prompts to add or remove a counter; then prompts for a single counter kind from among the kinds on it (allowing "cancel"), then adds or removes it.
Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
dev 24315b234, edited locally to fix this bug.
What exactly should be the correct behavior/interaction?
Prompt for each kind of counter that's there; and for each kind, add or remove, but don't allow doing nothing. (In particular, if you've got a 1/1 creature with a -0/-1 counter on it and a +1/+1 counter on it, don't let it die after adding another -0/-1 counter but before you decide to add or remove a +1/+1 one.)
If you want to be extra fancy, list all the kinds that are there in a dialog, and allow toggling of each kind in any order; then add or remove them all at once when you pick "Done" at the end.
Are any other cards possibly affected by this bug?
Skyship Plunderer and Maulfist Revolutionary both do the same, though neither allows (nor should allow) you to pick "remove". They're easier than this; you can just call increment_all_counters() for them when they're targeting permanents.
None of them have a thing to do with proliferate, in any case, and shouldn't be calling proliferate-named functions just in case proliferate gets another round of arbitrary power-level errata.