[fixed]Golgari Decoy didn't force block

[etphonehome]

When Golgari Decoy attacked it didn't forced all creatures to block it.

THX

[Aswan jaguar]

Yes, I confirm this also in dev. The ability is broken and doesn't force blockers.

[Korath]

Broken in commit 56d942f8af. -1 in a bitfield means all bits set, not none - if lure_effect() is told no abilities are required, it requires everything in keyword_t.

[Aswan jaguar]

The issues I introduced in commit 56d942f8af seem fixed in commit 1b95f21.
However despite commit 56d942f8af something else breaks some auras. This doesn't get fixed by switching to new aura functions tested with Lure.
Broken auras:
Indrik Umbra - totem_armor()
Lure, Seton's Desire - generic_aura()
Tempting Licid - generic_licid()
Auras that work correctly using different functions than above and force block:
Noble Quarry using generic_creature_with_bestow() when it is an aura.
Gift of the Deity using aura_ability_for_color()

[Korath]

For Lure itself, the problem is that generic_aura() isn't calling special_abilities() except during EVENT_ABILITIES. It needs EVENT_TRIGGER and EVENT_RESOLVE_TRIGGER during TRIGGER_MUST_BLOCK, too. (It's a really horrible design. special_abilities() shouldn't need to be called at all - setting the bit should be enough.) I haven't tried the other cards above. Some of the other SP_KEYWORD_* bits will need other events, too.

[drool66]

That's right - I forgot that I needed to, at the very least, take special_abilities() out from under EVENT_ABILITIES
Fixed in 6f817f7 and tested working

[Korath]

Without having looked at your commit, I've got concerns. With the current design of special_abilities(), everything annotated in sp_keyword_t as "can't be added by bit" and/or "must be called continuously" - about a third of the bits - can't be guarded by IS_AURA_EVENT(). That's just begging for more problems like this down the line.

[Aswan jaguar]

drool66 are you doing any more work on this? If not mark it fixed and archive this, please.

[drool66]

I guess so. The cards work, but only because none of them check IS_AURA_EVENT. The bigger issue is the sp_keyword abilities that need to be called outside of EVENT_ABILITIES. I would think we should have a bug report open to address that. For now I'll close this one and put sp_keywords on my to do list.