It is currently 25 Apr 2024, 08:31
   
Text Size

[fixedWrong icon placement on "rules engine" and watermarks.

Moderators: BAgate, drool66, Aswan jaguar, gmzombie, stassy, CCGHQ Admins

[fixedWrong icon placement on "rules engine" and watermarks.

Postby etphonehome » 25 Dec 2021, 00:32

After updating to the newest version of Manalink, the icons on "rules engine" are wrongly placed and watermarks on Big cards.

THX
Attachments
Captura de ecrã 2021-12-25 130219.jpg
Captura de ecrã 2021-12-25 002855.jpg
Last edited by drool66 on 25 Dec 2021, 23:10, edited 2 times in total.
Reason: fixed
etphonehome
 
Posts: 299
Joined: 21 May 2020, 12:50
Has thanked: 270 times
Been thanked: 39 times

Re: Wrong icon placement on "rules engine"

Postby Korath » 25 Dec 2021, 13:00

Works for me. Sounds like Duel.dat wasn't in the release.

(Are releases being packaged manually? Why? Script it.)

You can fix it locally by editing Cardart\Duel.dat, looking for the [Counters] section, and making sure NumColumns is set to 16 and NumRows is set to 12. If they are, then it's not Duel.dat that was missing from the release package, it was the new Cardcounters.png, and you can fix it - temporarily - by changing NumColumns from 16 back to 15.
User avatar
Korath
DEVELOPER
 
Posts: 3707
Joined: 02 Jun 2013, 05:57
Has thanked: 496 times
Been thanked: 1106 times

Re: Wrong icon placement on "rules engine" and watermarks.

Postby drool66 » 25 Dec 2021, 20:24

(Are releases being packaged manually? Why? Script it.)
I'd love to - is there one in the repository or do I have to make one?
User avatar
drool66
Programmer
 
Posts: 1163
Joined: 25 Nov 2010, 22:38
Has thanked: 186 times
Been thanked: 267 times

Re: Wrong icon placement on "rules engine" and watermarks.

Postby Korath » 25 Dec 2021, 21:45

Well, you can look at what I wrote for Shandalar in src/shandalar/Makefile - look for $(DIST) - but that's more complex than it needs to be and doesn't do everything you want, since I didn't bother with making an updates-only package.

Basically, you want to
  1. make install-world
  2. ensure all the files needed to run the game are in your installation dir and are up to date
  3. construct a zip command that compresses only those files
  4. run zipcmp to compare that against your previous release, and use its output to make your updates package.
Step B is a lot easier if you use an updated repository dir to build your release in. Step C is somewhat easier (but much more reliable) if you use a separate one.
User avatar
Korath
DEVELOPER
 
Posts: 3707
Joined: 02 Jun 2013, 05:57
Has thanked: 496 times
Been thanked: 1106 times

Re: [fixedWrong icon placement on "rules engine" and waterma

Postby drool66 » 25 Dec 2021, 23:13

Fixed & links updated - I hadn't included any of the files from CardArt including cardcounters.png and watermarks.pic
User avatar
drool66
Programmer
 
Posts: 1163
Joined: 25 Nov 2010, 22:38
Has thanked: 186 times
Been thanked: 267 times

Re: [fixedWrong icon placement on "rules engine" and waterma

Postby Aswan jaguar » 26 Dec 2021, 08:55

I wish you have also uploaded only the files that were not in the update each in it's file so that people that have already downloaded the new update don't have to download the whole package again, and make a post in release, so they update their files.
---
Trying to squash some bugs and playtesting.
User avatar
Aswan jaguar
Super Tester Elite
 
Posts: 8078
Joined: 13 May 2010, 12:17
Has thanked: 730 times
Been thanked: 458 times

Re: [fixedWrong icon placement on "rules engine" and waterma

Postby Korath » 28 Dec 2021, 13:39

Preliminary script in branch wip/packaging-script. Besides the warnings in its commit message - which definitely deserves a read - it needs a proper dev environment (sh, grep, sed, fully-functional piping, etc), so while cross-compiling from linux or running it under WSL works, and running it under cygwin should, cobbled-together ides from two decades ago are a lost cause. Sorry.
User avatar
Korath
DEVELOPER
 
Posts: 3707
Joined: 02 Jun 2013, 05:57
Has thanked: 496 times
Been thanked: 1106 times


Return to Archived Reports

Who is online

Users browsing this forum: No registered users and 46 guests

cron

Who is online

In total there are 46 users online :: 0 registered, 0 hidden and 46 guests (based on users active over the past 10 minutes)
Most users ever online was 4143 on 23 Jan 2024, 08:21

Users browsing this forum: No registered users and 46 guests

Login Form