[fixed] Zirda and Cycling card

[drool66]

It seems that even creatures with cycling, for example, are not allowed.

Fixed in a6f58a6

I pulled a Shark Typhoon from the deck and was able to make him my companion.

Can I get a decklist or savegame please?

[Korath]

It's because card_zirda_the_dawnwaker() represents "has an activated ability" with "card_data_t::extra_ability & (EA_MANA_SOURCE | EA_ACT_ABILITY)". That only works for instant-speed activated abilities that are activated from the battlefield. It fails for ones activated from the hand (like cycling, as reported here) or graveyard and for interrupt-speed ones like Daring Apprentice, and is a false positive for all those cards with fake activated abilities like Chief Engineer and Future Sight and Oath of Nissa and Hermetic Study.

[drool66]

I did a partial fix in a6f58a6, which contains an error. I'll fix that, add EA_ACT_INTERRUPT to the extra_abilities checked, and add the Companion ability legacy text I forgot to do, all in a future commit. As for the fake activated abilities, I'm aware, I just don't know if there's much I can do about those other than change them all to instead attach a legacy activate.

Konatsu: I understand now - at first I thought you were able to have Shark Typhoon be your Companion, which would be a completely different bug altogether The deck you posted now allows Zirda to be the Companion.

[Korath]

(Yeah, I saw the commit almost immediately after I made that post.)

There's other cards that care about whether a given card has an activated ability - Power Sink and Ravager Wurm spring to mind, and you've got Moonsilver Key and Midnight Arsonist coming up soon - so it's probably worth it to make a dedicated has_an_activated_ability() function (and return different values depending on whether it has mana ones, nonmana ones, or both). You can get a partial list of fakes by looking through shandalar/replace_cards.cpp and looking for where I've removed EA_ACT_ABILITY or EA_ACT_INTERRUPT.

[drool66]

Added has_an_activated_ability() in f3c69f3

Marking this fixed