[fixed] Clone can't be cast

by **Aswan jaguar** » 14 Mar 2022, 09:35

Describe the Bug:
For some strange reason Clone can't be cast, it highlights as ready to cast but nothing happens when you click on it. It works on release. The same happens with the other card that uses it's code address but not with Altered Ego that returns Clone's code.

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
dev based in commit 337996 and on/ duel

What exactly should be the correct behavior/interaction?

Are any other cards possibly affected by this bug?
-

by **drool66** » 14 Mar 2022, 19:59

I think Clone & Vesuvan Doppelganger shouldn't be special-cased in put_card_on_stack(..0) any more, unless we want to do a check for the AI or something. It's still special-cased in the exe version, so I don't know why it could be cast on release but not now.
Anyway, this can be fixed by either taking the special cases out of put_card_on_stack() or just adding the event handler to clone and returning 1, like we've done with Vesuvan Doppelganger. I'm not sure which is better.

by **Korath** » 14 Mar 2022, 20:26

They're only special-cased there (and in the original put_into_play()) because the original versions targeted at announcement. The reason Clone worked before is because we've been using a different csvid for Clone for years - it was originally 39, now 10399 - and your C version of put_card_on_stack() updated the special case to look for the new value instead of the old.

by **drool66** » 15 Mar 2022, 01:31

Cool. Fixed by removing the special-casing.
hash: 1ae7abc